Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128968/ --- (Updated Sept. 22, 2016, 2:14 a.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Submitted with commit 6d1485bece7ad3dbe4c64f517643c50076c68e7d by Ralf Habacker to branch master. Repository: kdoctools Description --- Convert checkxml5 into a qt executable for cross plattform support. Diffs - CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 src/checkXML5.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128968/diff/ Testing --- compiled at https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools Thanks, Ralf Habacker
Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128968/#review99396 --- Ship it! Inviala! - Luigi Toscano On Set. 21, 2016, 11:35 a.m., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128968/ > --- > > (Updated Set. 21, 2016, 11:35 a.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > Convert checkxml5 into a qt executable for cross plattform support. > > > Diffs > - > > CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda > checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 > src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 > src/checkXML5.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128968/diff/ > > > Testing > --- > > compiled at > https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools > > > Thanks, > > Ralf Habacker > >
Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.
> On Sept. 21, 2016, 12:38 nachm., Luigi Toscano wrote: > > Would it make more sense to change meinproc5 to work like checkXML5 if > > invoked with that name (hardlink, copy, etc, a-la busybox)? > > Ralf Habacker wrote: > Sorry, I do not know the reasons why this tool has been created and has > not been integrated into meinproc5. You should ask the original author. > > Luigi Toscano wrote: > The original author (Laurent Montel, > https://websvn.kde.org/?view=revision=505145) don't remember much, > and I guess it's not relevant here. My question was: from a multiplatform > prospective, would this solution have any drawback? Where "this solution" is: > have a checkXML5(.exe) executable which is an hardlink (or a copy, I guess, > on Windows) to meinproc5, but exposing the behavior of the wrapper script? Pro's: - no additional source/cmake target/binary to maintain Neg's: - increase the complexibility of meinproc5 caused by the need to support of additional 'checkXML5' use case - more efforts required to maintain the related man pages caused by the dualism e.g. 'Do I need to update "meinproc5" or "checkXML5" man page - duplicated executable on windows caused by pysical copy (hardlinks are not supported by cmake as far as I know) Seeing this I would stay with the checkXML5 executable introduced with this request. - Ralf --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128968/#review99350 --- On Sept. 21, 2016, 11:35 vorm., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128968/ > --- > > (Updated Sept. 21, 2016, 11:35 vorm.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > Convert checkxml5 into a qt executable for cross plattform support. > > > Diffs > - > > CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda > checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 > src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 > src/checkXML5.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128968/diff/ > > > Testing > --- > > compiled at > https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools > > > Thanks, > > Ralf Habacker > >
Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.
> On Sept. 21, 2016, 12:38 nachm., Luigi Toscano wrote: > > Would it make more sense to change meinproc5 to work like checkXML5 if > > invoked with that name (hardlink, copy, etc, a-la busybox)? Sorry, I do not know the reasons why this tool has been created and has not been integrated into meinproc5. You should ask the original author. - Ralf --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128968/#review99350 --- On Sept. 21, 2016, 11:35 vorm., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128968/ > --- > > (Updated Sept. 21, 2016, 11:35 vorm.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > Convert checkxml5 into a qt executable for cross plattform support. > > > Diffs > - > > CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda > checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 > src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 > src/checkXML5.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128968/diff/ > > > Testing > --- > > compiled at > https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools > > > Thanks, > > Ralf Habacker > >
Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128968/#review99350 --- Would it make more sense to change meinproc5 to work like checkXML5 if invoked with that name (hardlink, copy, etc, a-la busybox)? - Luigi Toscano On Sept. 21, 2016, 11:35 a.m., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128968/ > --- > > (Updated Sept. 21, 2016, 11:35 a.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > Convert checkxml5 into a qt executable for cross plattform support. > > > Diffs > - > > CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda > checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 > src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 > src/checkXML5.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128968/diff/ > > > Testing > --- > > compiled at > https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools > > > Thanks, > > Ralf Habacker > >
