Re: Review Request 129598: fix build, needs QtDBus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129598/ --- (Updated Dec. 2, 2016, 11:09 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 04389b36653b2d0df8a3ac2fc62bafa1b86e by Sebastian Kügler to branch master. Repository: frameworkintegration Description --- The new appstream kpackage handler needs to link Qt DBus, but the find package call is missing. Diffs - CMakeLists.txt e97e698 Diff: https://git.reviewboard.kde.org/r/129598/diff/ Testing --- Builds and works on my machine Thanks, Sebastian Kügler
Re: Review Request 129598: fix build, needs QtDBus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129598/#review101207 --- Ship it! FWIW it's fixed upstream, it just hasn't landed yet... - Aleix Pol Gonzalez On Dec. 2, 2016, 1:09 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129598/ > --- > > (Updated Dec. 2, 2016, 1:09 a.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > --- > > The new appstream kpackage handler needs to link Qt DBus, but the find > package call is missing. > > > Diffs > - > > CMakeLists.txt e97e698 > > Diff: https://git.reviewboard.kde.org/r/129598/diff/ > > > Testing > --- > > Builds and works on my machine > > > Thanks, > > Sebastian Kügler > >
Review Request 129598: fix build, needs QtDBus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129598/ --- Review request for KDE Frameworks. Repository: frameworkintegration Description --- The new appstream kpackage handler needs to link Qt DBus, but the find package call is missing. Diffs - CMakeLists.txt e97e698 Diff: https://git.reviewboard.kde.org/r/129598/diff/ Testing --- Builds and works on my machine Thanks, Sebastian Kügler