[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Jan Beich changed: What|Removed |Added Resolution|--- |Not Accepted Status|New |Closed --- Comment #13 from Jan Beich --- The patch here is not salvageable anymore. Some unintentional consumers are easy to discover due to broken build but in libraries and plugins unless (--no-undefined or -z defs) it may propagate to runtime. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 --- Comment #12 from Jan Beich --- (In reply to Po-Chuan Hsieh from comment #10) Those 8 are marked landmines, more are likely awaiting for someone to step on and waste lots of time debugging. The patch increases reproducibility by making the intent to use libinotify explicit. Avoiding surprises is why FreeBSD long ago removed /usr/local/include default in base compiler. (In reply to mp39590 from comment #11) Originally stalled due to style issues (pkg-config vs. directly adjusting flags) but then Mono upstream started hardcoding /usr/local/include, sabotaging not only this effort but also LOCALBASE != /usr/local. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 --- Comment #11 from mp39...@gmail.com --- What is the status of this bug? It has been up for more than 2 years, can it be closed? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 --- Comment #10 from Sunpoet Po-Chuan Hsieh --- (In reply to Jan Beich from comment #6) There's only 8 CONFIGURE_ENV=ac_cv_header_sys_inotify_h=no in the ports tree. Do we really need such a huge local patch which affects more than 40 ports. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Phillip R. Jaenke changed: What|Removed |Added CC||p...@rootwyrm.com --- Comment #9 from Phillip R. Jaenke --- This will break mono and all mono consumers using the System.IO namespace. We already handled kqueue vs inotify poisoning upstream by specifically looking to /usr/local/include for inotify.h. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Steve Wills changed: What|Removed |Added Flags|maintainer-feedback?(swills |maintainer-feedback+ |@FreeBSD.org) | --- Comment #8 from Steve Wills --- Haven't tested it, but obs-qtwebkit change looks fine. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 --- Comment #7 from Dominik Lisiak --- I didn't apply the patch, but made a compatible fix in bug #236919 for security/ossec-hids-local. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Dominik Lisiak changed: What|Removed |Added Flags|maintainer-feedback?(domini |maintainer-feedback+ |k.lis...@bemsoft.pl)| -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Koop Mast changed: What|Removed |Added Flags|maintainer-feedback?(kwm@Fr |maintainer-feedback+ |eeBSD.org) | -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240
--- Comment #6 from Jan Beich ---
(In reply to Sunpoet Po-Chuan Hsieh from comment #5)
> Could you please give a case that "consumers may opportunistically
> pick it up over kqueue backend or if not required"?
Look for ports with CONFIGURE_ENV=ac_cv_header_sys_inotify_h=no.
> After this change, do we have to teach every new ports how to find the new
> home of inotify.h?
No. Only those not using pkg-config. -linotify doesn't exist on Linux, so it
always comes with a .pc file (unless older than 20170711). autotools and meson
support pkg-config just fine, cmake uses modules to reinvent pkg-config but the
support is good if required module exists, gmake and bmake[1] can cache
pkg-config output via $(shell ...) and ${SH:!...!}.
[1] bmake caching have to be in submake *after* pkg-config is installed as
${SH:!...!} is evaluated at parsing time. gmake isn't affected because it's
only used to parse vendor's Makefile while port's Makefile is parsed by bmake.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 --- Comment #5 from Sunpoet Po-Chuan Hsieh --- (In reply to Jan Beich from comment #0) I'm OK to change where inotify.h installs. But I do not understand why we have to move it. Could you please give a case that "consumers may opportunistically pick it up over kqueue backend or if not required"? After this change, do we have to teach every new ports how to find the new home of inotify.h? Thanks. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Gleb Popov changed: What|Removed |Added Flags|maintainer-feedback?(haskel |maintainer-feedback+ |l...@freebsd.org) | CC||arr...@freebsd.org -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 --- Comment #4 from Josh Paetzel --- I patched devel/libinotify, then installed devel/py-pyinotify and confirmed it works properly. All clear from me. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Bernhard Froehlich changed: What|Removed |Added Flags|maintainer-feedback?(decke@ |maintainer-feedback+ |FreeBSD.org)| -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Yuri Victorovich changed: What|Removed |Added Flags|maintainer-feedback?(yuri@f |maintainer-feedback+ |reebsd.org) | -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Tobias C. Berner changed: What|Removed |Added Flags|maintainer-feedback?(kde@Fr |maintainer-feedback+ |eeBSD.org) | CC||tcber...@freebsd.org --- Comment #3 from Tobias C. Berner --- Looks good for kde@, as long as it is exp-ran. mfg Tobias -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Alexandre C. Guimarães changed: What|Removed |Added Flags|maintainer-feedback?(rigole |maintainer-feedback+ |t...@freebsd.org)| -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Guido Falsi changed: What|Removed |Added Flags|maintainer-feedback?(madpil |maintainer-feedback+ |o...@freebsd.org) | --- Comment #2 from Guido Falsi --- I filed some feedback in the code review. Short version is, I think this could be better addressed creating an inotify USES. I'm restraining my approval until such concern is addressed. Posting here to avoid timing out. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Jan Beich changed: What|Removed |Added Assignee|sunp...@freebsd.org |port...@freebsd.org Flags||exp-run? --- Comment #1 from Jan Beich --- Can you check all ports for hidden consumers? OPTIONS_SET += LIBINOTIFY INOTIFY FSMONITOR -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 Bug ID: 235240 Summary: devel/libinotify: move sys/inotify.h into a subdirectory Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: sunp...@freebsd.org Reporter: jbe...@freebsd.org CC: de...@freebsd.org, dominik.lis...@bemsoft.pl, freebsd-po...@dan.me.uk, hask...@freebsd.org, j...@freebsd.org, joh.hendr...@gmail.com, jpaet...@freebsd.org, juni...@junichi.org, k...@freebsd.org, k...@freebsd.org, lukas.slebod...@intrak.sk, madpi...@freebsd.org, mickael.mail...@gmail.com, m...@freebsd.org, mp39...@gmail.com, m...@freebsd.org, olg...@freebsd.org, rigole...@freebsd.org, sunp...@freebsd.org, swi...@freebsd.org, takumii...@gmail.com, ti...@freebsd.org, ult...@freebsd.org, yo...@fizk.net, y...@freebsd.org Assignee: sunp...@freebsd.org Flags: maintainer-feedback?(sunp...@freebsd.org) Flags: maintainer-feedback?(de...@freebsd.org), maintainer-feedback?(dominik.lis...@bemsoft.pl), maintainer-feedback?(freebsd-po...@dan.me.uk), maintainer-feedback?(hask...@freebsd.org), maintainer-feedback?(j...@freebsd.org), maintainer-feedback?(joh.hendr...@gmail.com), maintainer-feedback?(jpaet...@freebsd.org), maintainer-feedback?(juni...@junichi.org), maintainer-feedback?(k...@freebsd.org), maintainer-feedback?(k...@freebsd.org), maintainer-feedback?(lukas.slebod...@intrak.sk), maintainer-feedback?(madpi...@freebsd.org), maintainer-feedback?(mickael.mail...@gmail.com), maintainer-feedback?(m...@freebsd.org), maintainer-feedback?(mp39...@gmail.com), maintainer-feedback?(m...@freebsd.org), maintainer-feedback?(olg...@freebsd.org), maintainer-feedback?(rigole...@freebsd.org), maintainer-feedback?(sunp...@freebsd.org), maintainer-feedback?(swi...@freebsd.org), maintainer-feedback?(takumii...@gmail.com), maintainer-feedback?(ti...@freebsd.org), maintainer-feedback?(ult...@freebsd.org), maintainer-feedback?(yo...@fizk.net), maintainer-feedback?(y...@freebsd.org) CC: de...@freebsd.org, dominik.lis...@bemsoft.pl, freebsd-po...@dan.me.uk, hask...@freebsd.org, j...@freebsd.org, joh.hendr...@gmail.com, jpaet...@freebsd.org, juni...@junichi.org, k...@freebsd.org, k...@freebsd.org, lukas.slebod...@intrak.sk, madpi...@freebsd.org, mickael.mail...@gmail.com, m...@freebsd.org, mp39...@gmail.com, m...@freebsd.org, olg...@freebsd.org, rigole...@freebsd.org, sunp...@freebsd.org, swi...@freebsd.org, takumii...@gmail.com, ti...@freebsd.org, ult...@freebsd.org, yo...@fizk.net, y...@freebsd.org libinotify installs sys/inotify.h in a common location where regular libraries are. Consumers may opportunistically pick it up over kqueue backend or if not required. Let's limit poisoning like OpenBSD port did. See review D18990 for the patch and check your port didn't regress. -- You are receiving this mail because: You are on the CC list for the bug.
maintainer-feedback requested: [Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory
Jan Beich has asked k...@freebsd.org for maintainer-feedback: Bug 235240: devel/libinotify: move sys/inotify.h into a subdirectory https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240 --- Description --- libinotify installs sys/inotify.h in a common location where regular libraries are. Consumers may opportunistically pick it up over kqueue backend or if not required. Let's limit poisoning like OpenBSD port did. See review D18990 for the patch and check your port didn't regress.
