[Bug 272029] multimedia/phonon: fix build with clang 16
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272029 --- Comment #7 from commit-h...@freebsd.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=73b6e876a9d3bb44fb7560c5efd99f9fe5f334b7 commit 73b6e876a9d3bb44fb7560c5efd99f9fe5f334b7 Author: Raphael Kubo da Costa AuthorDate: 2023-08-05 15:01:50 + Commit: Raphael Kubo da Costa CommitDate: 2023-08-05 15:03:07 + multimedia/phonon: Switch to upstream's fix for clang 16 build issues Instead of passing a compiler flag to work around a clang 16 build issue, adopt the fix that dim@ landed upstream that fixes the code in question. PR: 272029 Approved by:kde (arrowd) Differential Revision: https://reviews.freebsd.org/D41307 multimedia/phonon/Makefile | 9 ++ ...a3eb81bcbc730e44c27a0d060a85cf9213d.patch (new) | 36 ++ 2 files changed, 38 insertions(+), 7 deletions(-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 272029] multimedia/phonon: fix build with clang 16
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272029 --- Comment #6 from Dimitry Andric --- I have submitted https://invent.kde.org/libraries/phonon/-/merge_requests/16 for the future-proof fix. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 272029] multimedia/phonon: fix build with clang 16
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272029 --- Comment #5 from Dimitry Andric --- (In reply to Raphael Kubo da Costa from comment #4) Point them to https://reviews.llvm.org/D150226, where it seems like the possibility of disabling this error is going to go away after clang 17. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 272029] multimedia/phonon: fix build with clang 16
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272029 Raphael Kubo da Costa changed: What|Removed |Added CC||rak...@freebsd.org --- Comment #4 from Raphael Kubo da Costa --- For the record, upstream ended up doing the same thing that's been done in https://cgit.freebsd.org/ports/commit/?id=83e1d12fd0838b9cb38867f54bef20790e05b3af I've posted a comment to https://invent.kde.org/libraries/phonon/-/merge_requests/13 pointing out what dim's mentioned here, hopefully this leads to a proper fix there. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 272029] multimedia/phonon: fix build with clang 16
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272029 --- Comment #3 from Dimitry Andric --- Note that clang upstream plans to make -Wenum-constexpr-conversion a hard error in the future (i.e it cannot be turned off anymore), so at some point actually fixing the problem should be done. In that case, the above patch still applies. :) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 272029] multimedia/phonon: fix build with clang 16
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272029 Gleb Popov changed: What|Removed |Added Status|New |Closed Resolution|--- |FIXED CC||arr...@freebsd.org --- Comment #2 from Gleb Popov --- This is fixed by https://cgit.freebsd.org/ports/commit/?id=83e1d12fd0838b9cb38867f54bef20790e05b3af -- You are receiving this mail because: You are the assignee for the bug.
[Bug 272029] multimedia/phonon: fix build with clang 16
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272029 Dimitry Andric changed: What|Removed |Added Blocks||271047 Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271047 [Bug 271047] [exp-run] Against llvm-16-update branch on GitHub -- You are receiving this mail because: You are the assignee for the bug.
[Bug 272029] multimedia/phonon: fix build with clang 16
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272029 --- Comment #1 from Dimitry Andric --- Created attachment 242814 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=242814=edit multimedia/phonon: fix build with clang 16 -- You are receiving this mail because: You are the assignee for the bug.
maintainer-feedback requested: [Bug 272029] multimedia/phonon: fix build with clang 16
Bugzilla Automation has asked freebsd-kde (Team)
for maintainer-feedback:
Bug 272029: multimedia/phonon: fix build with clang 16
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272029
--- Description ---
Clang 16 has a new error about integer values being outside the valid
range for enum types, which shows up when building multimedia/phonon:
/wrkdirs/usr/ports/multimedia/phonon/work/.build/phonon/experimental/phonon4qt5
experimental_autogen/EWIEGA46WW/../../../../../phonon-4.11.1/phonon/experimenta
l/visualization.h:45:27:
error: integer value 4294967294 is outside the valid range of values [0, 7] for
the enumeration type 'ObjectDescriptionType' [-Wenum-constexpr-conversion]
typedef
ObjectDescription(VisualizationType)
>
VisualizationDescription;
^
/wrkdirs/usr/ports/multimedia/phonon/work/.build/phonon/experimental/phonon4qt5
experimental_autogen/EWIEGA46WW/../../../../../phonon-4.11.1/phonon/experimenta
l/visualization.h:46:32:
error: integer value 4294967294 is outside the valid range of values [0, 7] for
the enumeration type 'ObjectDescriptionType' [-Wenum-constexpr-conversion]
typedef
ObjectDescriptionModel(Visualization
Type)>
VisualizationDescriptionModel;
^
/wrkdirs/usr/ports/multimedia/phonon/work/phonon-4.11.1/phonon/objectdescriptio
n.h:189:41:
error: integer value 4294967294 is outside the valid range of values [0, 7] for
the enumeration type 'ObjectDescriptionType' [-Wenum-constexpr-conversion]
static inline ObjectDescription fromIndex(int index) {
//krazy:exclude=inline
^
/wrkdirs/usr/ports/multimedia/phonon/work/phonon-4.11.1/phonon/objectdescriptio
n.h:260:45:
error: integer value 4294967294 is outside the valid range of values [0, 7] for
the enumeration type 'ObjectDescriptionType' [-Wenum-constexpr-conversion]
friend class ObjectDescriptionModel;
^
This is because enum ObjectDescriptionType only has 6 members, and
therefore only gets 3 bits allocated by default. In that case, values
like 4294967294 (0xfffe) do not fit in it.
Work around the problem by declaring enum ObjectDescriptionType to
explicitly be of type unsigned, so it can fit 32 bits.
[Bug 272029] multimedia/phonon: fix build with clang 16
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272029
Bug ID: 272029
Summary: multimedia/phonon: fix build with clang 16
Product: Ports & Packages
Version: Latest
Hardware: Any
OS: Any
Status: New
Severity: Affects Some People
Priority: ---
Component: Individual Port(s)
Assignee: k...@freebsd.org
Reporter: d...@freebsd.org
Flags: maintainer-feedback?(k...@freebsd.org)
Assignee: k...@freebsd.org
Clang 16 has a new error about integer values being outside the valid
range for enum types, which shows up when building multimedia/phonon:
/wrkdirs/usr/ports/multimedia/phonon/work/.build/phonon/experimental/phonon4qt5experimental_autogen/EWIEGA46WW/../../../../../phonon-4.11.1/phonon/experimental/visualization.h:45:27:
error: integer value 4294967294 is outside the valid range of values [0, 7] for
the enumeration type 'ObjectDescriptionType' [-Wenum-constexpr-conversion]
typedef
ObjectDescription(VisualizationType)>
VisualizationDescription;
^
/wrkdirs/usr/ports/multimedia/phonon/work/.build/phonon/experimental/phonon4qt5experimental_autogen/EWIEGA46WW/../../../../../phonon-4.11.1/phonon/experimental/visualization.h:46:32:
error: integer value 4294967294 is outside the valid range of values [0, 7] for
the enumeration type 'ObjectDescriptionType' [-Wenum-constexpr-conversion]
typedef
ObjectDescriptionModel(VisualizationType)>
VisualizationDescriptionModel;
^
/wrkdirs/usr/ports/multimedia/phonon/work/phonon-4.11.1/phonon/objectdescription.h:189:41:
error: integer value 4294967294 is outside the valid range of values [0, 7] for
the enumeration type 'ObjectDescriptionType' [-Wenum-constexpr-conversion]
static inline ObjectDescription fromIndex(int index) {
//krazy:exclude=inline
^
/wrkdirs/usr/ports/multimedia/phonon/work/phonon-4.11.1/phonon/objectdescription.h:260:45:
error: integer value 4294967294 is outside the valid range of values [0, 7] for
the enumeration type 'ObjectDescriptionType' [-Wenum-constexpr-conversion]
friend class ObjectDescriptionModel;
^
This is because enum ObjectDescriptionType only has 6 members, and
therefore only gets 3 bits allocated by default. In that case, values
like 4294967294 (0xfffe) do not fit in it.
Work around the problem by declaring enum ObjectDescriptionType to
explicitly be of type unsigned, so it can fit 32 bits.
--
You are receiving this mail because:
You are the assignee for the bug.
