Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/ --- (Updated Сен. 16, 2015, 9:49 п.п.) Review request for Plasma and Solid.

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

> On Сен. 16, 2015, 6:57 п.п., Valerio De Angelis wrote: > > File Attachment: Applet with error message - snapshot11.png > > > > > > Could be possible to put the applications list in bold? That would be better, right. But simply adding

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

> On Сен. 16, 2015, 6:57 п.п., Valerio De Angelis wrote: > > File Attachment: Applet with error message - snapshot11.png > > > > > > Could be possible put here: > > 1) the same application list shown in the device page as per the >

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/#review85507 --- File Attachment: Applet with error message - snapshot11.png <

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/ --- (Updated Сен. 16, 2015, 6:07 п.п.) Review request for Plasma and Solid.

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/ --- (Updated Сен. 16, 2015, 10:59 д.п.) Review request for Plasma and Solid.

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

> On Сен. 16, 2015, 10:11 д.п., Kai Uwe Broulik wrote: > > I really like that! > > > > The device notifier UI itself is questionable with the popup telling us > > "the device xyz failed to unmount" rather than just highlighting the device > > and showing the message in the list directly but th

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

> On Sept. 16, 2015, 10:11 vorm., Kai Uwe Broulik wrote: > > I really like that! > > > > The device notifier UI itself is questionable with the popup telling us > > "the device xyz failed to unmount" rather than just highlighting the device > > and showing the message in the list directly but

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/#review85488 --- I really like that! The device notifier UI itself is question

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

> On Сен. 15, 2015, 10:41 п.п., Martin Klapetek wrote: > > dataengines/devicenotifications/ksolidnotify.cpp, line 122 > > > > > > This should be a private method rather than a static method > > > > (and

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/ --- (Updated Сен. 16, 2015, 7:23 д.п.) Review request for Plasma and Solid.

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

> On Сен. 16, 2015, 12:21 д.п., Xuetian Weng wrote: > > dataengines/devicenotifications/ksolidnotify.cpp, line 131 > > > > > > I'd prefer to make it async. Are you talking about whole getBlockingApps function or