Re: [Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

2015-12-14 Thread Martin Klapetek
> On Dec. 14, 2015, 10:06 p.m., Martin Klapetek wrote: > > ...why not stable branch? > > Kai Uwe Broulik wrote: > I fear it might break things, it's also a behavioral change, though I've > been running it for weeks without a problem. > I can merge it to 5.5 once 5.5.1 is tagged. Ah, fa

Re: [Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

2015-12-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126145/#review89497 --- ...why not stable branch? - Martin Klapetek On Dec. 14, 201

Re: [Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

2015-12-14 Thread Kai Uwe Broulik
> On Dez. 14, 2015, 9:06 nachm., Martin Klapetek wrote: > > ...why not stable branch? I fear it might break things, it's also a behavioral change, though I've been running it for weeks without a problem. I can merge it to 5.5 once 5.5.1 is tagged. - Kai Uwe -

Re: [Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

2015-12-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126145/ --- (Updated Dec. 14, 2015, 9:04 p.m.) Status -- This change has been ma

Re: [Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref] and [-Wclazy-reserve-candidates]

2015-12-14 Thread Artur Puzio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126342/ --- (Updated Dec. 14, 2015, 6:38 p.m.) Status -- This change has been ma

Re: [Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref] and [-Wclazy-reserve-candidates]

2015-12-14 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126342/#review89487 --- Ship it! Ship It! - David Rosca On Dec. 14, 2015, 11:15 a.

Re: [Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref] and [-Wclazy-reserve-candidates]

2015-12-14 Thread Artur Puzio
> On Gru 14, 2015, 3:01 po poĊ‚udniu, David Rosca wrote: > > autotests/fakebluez/deviceinterface.cpp, line 30 > > > > > > This is still non-POD static. If it fixes issue in clazy, then it is > > bug in clazy. > >

Re: [Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref] and [-Wclazy-reserve-candidates]

2015-12-14 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126342/#review89476 --- autotests/fakebluez/deviceinterface.cpp (line 30)

Re: [Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref] and [-Wclazy-reserve-candidates]

2015-12-14 Thread Artur Puzio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126342/ --- (Updated Gru 14, 2015, 11:15 rano) Review request for Bluedevil and David

Re: [Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref], [-Wclazy-reserve-candidates] and [-Wclazy-foreach]

2015-12-14 Thread Artur Puzio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126342/ --- (Updated Gru 14, 2015, 11:14 rano) Review request for Bluedevil and David

Re: [Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref]

2015-12-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126342/#review89461 --- +1 looks good. Please, wait for the maintainer to give a fina

[Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref]

2015-12-14 Thread Artur Puzio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126342/ --- Review request for Bluedevil and David Rosca. Repository: bluez-qt Desc