Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

> On Dec. 18, 2015, 6:34 a.m., Johan Ouwerkerk wrote: > > backends/kwayland/waylandconfig.cpp, line 58 > > > > > > Shouldn't m_syncLoop and be captured by reference? > > `[m_thread,m_connection,_syncLoop] {...}`

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89693 --- backends/kwayland/waylandconfig.cpp (line 58)

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89688 --- backends/kwayland/waylandbackend.cpp (line 40)

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89716 --- Looks good to me. Just as a note: the testserver has quite

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

> On Dec. 18, 2015, 9:20 a.m., Martin Gräßlin wrote: > > backends/kwayland/waylandconfig.cpp, line 154 > > > > > > maybe a counter for block signals? Whenever it gets blocked increment > > by 1, and decrement

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/ --- (Updated Dec. 18, 2015, 1:54 p.m.) Review request for Plasma, Solid,

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

> On Dec. 18, 2015, 5:34 a.m., Johan Ouwerkerk wrote: > > backends/kwayland/waylandconfig.cpp, line 58 > > > > > > Shouldn't m_syncLoop and be captured by reference? > > `[m_thread,m_connection,_syncLoop] {...}`