Re: Review Request 129277: Use built-in QByteArrayList type instead of our own.

2016-10-28 Thread Aleix Pol Gonzalez
/udisks2/udisksmanager.cpp (line 51) <https://git.reviewboard.kde.org/r/129277/#comment67368> Remove +1 makes sense - Aleix Pol Gonzalez On Oct. 28, 2016, 6:59 p.m., Gleb Popov wrote: > > --- > This is an automatically g

Re: [Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref]

2015-12-14 Thread Aleix Pol Gonzalez
a final decision though. - Aleix Pol Gonzalez On Dec. 14, 2015, 11:44 a.m., Artur Puzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-09-10 Thread Aleix Pol Gonzalez
> On July 31, 2015, 9:38 p.m., Aleix Pol Gonzalez wrote: > > Is it done yet? What's the status? > > Kai Uwe Broulik wrote: > I don't know, someone marked it as submitted but it cearly isn't. > > Albert Vaca Cintora wrote: > What's left before we can

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-07-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review83263 --- Is it done yet? What's the status? - Aleix Pol Gonzalez

Re: [Kde-hardware-devel] Review Request 123860: Handle backend being deleted during GetConfigOperation

2015-05-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123860/#review80657 --- +1 - Aleix Pol Gonzalez On May 20, 2015, 2:36 p.m., David

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-23 Thread Aleix Pol Gonzalez
) https://git.reviewboard.kde.org/r/123475/#comment54232 Is it fine to use exec() here? - Aleix Pol Gonzalez On April 23, 2015, 1:05 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 119672: Ensure that when we set a primary output, it is primary

2015-02-13 Thread Aleix Pol Gonzalez
it to change from a setup to another using the fake backend. Thanks, Aleix Pol Gonzalez ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions

2014-12-29 Thread Aleix Pol Gonzalez
not convinced there's no space for race conditions here. Maybe we want to use something like QLockFile? http://doc.qt.io/qt-5/qlockfile.html - Aleix Pol Gonzalez On Dec. 28, 2014, 10:33 a.m., David Edmundson wrote: --- This is an automatically

Re: [Kde-hardware-devel] Review Request 121508: Allow turning off keyboard in dim display action

2014-12-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121508/#review72015 --- +1 Do we really need such setting, though? :D - Aleix Pol

Re: [Kde-hardware-devel] Review Request 121446: Ignore child mtp devices

2014-12-11 Thread Aleix Pol Gonzalez
to be. - Aleix Pol Gonzalez On Dec. 11, 2014, 1:05 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121446

Re: [Kde-hardware-devel] Review Request 120823: Fix KScreen when disconnecting a screen

2014-11-23 Thread Aleix Pol Gonzalez
bug reports and patches anyway). Thanks, Aleix Pol Gonzalez ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 120989: Small changes in kscreen_console

2014-11-05 Thread Aleix Pol Gonzalez
console/main.cpp 13660e1 Diff: https://git.reviewboard.kde.org/r/120989/diff/ Testing --- Runs fine. Thanks, Aleix Pol Gonzalez ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 120823: Fix KScreen when disconnecting a screen

2014-11-04 Thread Aleix Pol Gonzalez
of the configuration to be set, so X/Y will never be a bigger number than newSize.width/height. Besides if this is still needed or not, I don't get why Qt is crashing, can you explain a bit more about that? Aleix Pol Gonzalez wrote: Qt crashes because, at some point we get 0 screens on. And Qt

[Kde-hardware-devel] Review Request 120823: Fix KScreen when disconnecting a screen

2014-10-27 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/120823/diff/ Testing --- We managed to reproduce the bug consistently in David and my system up until we figured out why Qt was crashing (which will receive bug reports and patches anyway). Thanks, Aleix Pol Gonzalez ___ Kde

Re: [Kde-hardware-devel] Review Request 120823: Fix KScreen when disconnecting a screen

2014-10-27 Thread Aleix Pol Gonzalez
reports and patches anyway). Thanks, Aleix Pol Gonzalez ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 119672: Ensure that when we set a primary output, it is primary

2014-08-08 Thread Aleix Pol Gonzalez
. Diffs - backends/xrandr/xrandrconfig.cpp 3b37add src/config.cpp 8b9e388 Diff: https://git.reviewboard.kde.org/r/119672/diff/ Testing --- I wanted to make a unit-test, but I didn't see how to do it to change from a setup to another using the fake backend. Thanks, Aleix Pol

[Kde-hardware-devel] Review Request 118973: Ensure we mark batteries as connected when the charge is full too

2014-06-27 Thread Aleix Pol Gonzalez
Diff: https://git.reviewboard.kde.org/r/118973/diff/ Testing --- Seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 118951: Add a convenience Output::geometry method

2014-06-26 Thread Aleix Pol Gonzalez
Diff: https://git.reviewboard.kde.org/r/118951/diff/ Testing --- Played around with it. Thanks, Aleix Pol Gonzalez ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

2014-06-17 Thread Aleix Pol Gonzalez
: https://git.reviewboard.kde.org/r/118799/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

2014-06-17 Thread Aleix Pol Gonzalez
--- On June 17, 2014, 4:02 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118799

Re: [Kde-hardware-devel] Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

2014-06-17 Thread Aleix Pol Gonzalez
-CREATION src/declarativeimports/plasmaextracomponents/qml/qmldir c59e62f Diff: https://git.reviewboard.kde.org/r/118799/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https

Re: [Kde-hardware-devel] Review Request 117806: [WIP] Solid device import with proper model support

2014-05-27 Thread Aleix Pol Gonzalez
named forAleixWithLove (yeah... xD). Maybe you can take a look at it and apply it on master in different patches, properly. - Aleix Pol Gonzalez On April 27, 2014, 9:41 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated

Re: [Kde-hardware-devel] Review Request 118131: Report a change whenever screens are moved around

2014-05-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118131/#review58437 --- Ping? It's been more than a week... - Aleix Pol Gonzalez

[Kde-hardware-devel] Review Request 118131: Report a change whenever screens are moved around

2014-05-14 Thread Aleix Pol Gonzalez
this because it didn't work on the frameworks branch, but it should probably go to the master branch, if I'm not mistaken. Thanks, Aleix Pol Gonzalez ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: [Kde-hardware-devel] Review Request 117806: [WIP] Solid device import with proper model support

2014-04-27 Thread Aleix Pol Gonzalez
/#comment39549 No need to remove anything? src/solid/CMakeLists.txt https://git.reviewboard.kde.org/r/117806/#comment39551 Don't comment, remove, no? - Aleix Pol Gonzalez On April 27, 2014, 9:41 p.m., Kai Uwe Broulik wrote

[Kde-hardware-devel] Review Request 112765: Make udisks2 default

2013-09-16 Thread Aleix Pol Gonzalez
directory and then I didn't have devices support. Alex told me what variable to change and then ordered me to send a patch upgrading the default. :) Diffs - CMakeLists.txt ba11d60 Diff: http://git.reviewboard.kde.org/r/112765/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: [Kde-hardware-devel] Review Request 111964: Basic declarative (QML) interface for Solid

2013-08-28 Thread Aleix Pol Gonzalez
it could provide some other features that might be useful in other use-cases (thinking of the devices plasmoid). - Aleix Pol Gonzalez On Aug. 28, 2013, 2:41 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail

[Kde-hardware-devel] Review Request 109406: Ease addition of debugging info in Solid

2013-03-10 Thread Aleix Pol Gonzalez
it possible to add such information using cmake's cache instead of requiring to edit the code. Diffs - solid/solid/CMakeLists.txt 8142c71 solid/solid/backends/udev/udevmanager.cpp b0c83c9 Diff: http://git.reviewboard.kde.org/r/109406/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: [Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil

2013-01-22 Thread Aleix Pol Gonzalez
On Jan. 17, 2013, 1:03 a.m., Dario Freddi wrote: After a second look, there's a whole load of synchronous things in the backend init, hence I'd waive the .waitForFinished() version to be merged, with a huge note to self to revise that whole init routine for 4.11 (already on it).