Re: Review Request 113587: Add support for x-gvfs style options in fstab

it landed a long time ago. Itook your patch and ported it to Frameworks 5, please see the review at https://phabricator.kde.org/D5034 - Kai Uwe Broulik On Juni 22, 2014, 1:39 vorm., Stefan Brüns wrote: > > --- > This is an auto

Re: Review Request 123263: WIP: KDE Connect backend for Solid

workspace it works pretty well. Thanks, Kai Uwe Broulik

Re: Review Request 123262: ddccontrol support for PowerDevil

://git.reviewboard.kde.org/r/123262/diff/ Testing --- It's working pretty nicely, I can adjust brightness of my desktop monitor through battery monitor and have it automatically dimmed after a timeout. Thanks, Kai Uwe Broulik

Re: Review Request 123418: Add X11 guards

--- Compiles both with and without HAVE_XCB but I don't have a Wayland setup. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 127792: Fix usage of string "shut down"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127792/#review95025 --- Ship it! Ship It! - Kai Uwe Broulik On April 29, 2016

Re: [Kde-hardware-devel] Review Request 127325: Replace all keywords by Qt macros

making the source code ugly but whatever... - Kai Uwe Broulik On März 10, 2016, 8:42 vorm., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

tps://git.reviewboard.kde.org/r/127387/#comment63827> startsWith(QLatin1String(...)) src/backendmanager.cpp (line 182) <https://git.reviewboard.kde.org/r/127387/#comment63828> given paths is const, use range-for - Kai Uwe Broulik On März 15, 2016, 5:57 nachm., Sebastian

Re: [Kde-hardware-devel] Review Request 127263: Add Wireless Energy Saving action

t.reviewboard.kde.org/r/127263/ > --- > > (Updated März 9, 2016, 10:44 vorm.) > > > Review request for Plasma, Solid, KDE Usability, and Kai Uwe Broulik. > > > Repository: powerdevil > > > Description > --- > > This action adds an option to turn off wifi/ww

Re: [Kde-hardware-devel] Review Request 127263: Add Wireless Energy Saving action

> On März 3, 2016, 1:36 nachm., Kai Uwe Broulik wrote: > > > y) Switching to a profile where the action is enabled too and options are > > > turned off -> will turn on the wifi/wwan/bt > > z) Switching to a profile where the action is disabled -> will recover th

Re: [Kde-hardware-devel] Review Request 127263: Add Wireless Energy Saving action

preferences (better wording: but whatever is set in Plasna NM) | Turn on (always enable, maybe you really want Bluetooth to always turn on on AC, if you have a desktop with a BT mouse | Turn off (what the checkbox was previously)] - Kai Uwe Broulik On März 3, 2016, 1:30 nachm., Jan G

Re: [Kde-hardware-devel] Review Request 127263: Add Wireless Energy Saving action

in more detail what it does. So, when I plug back in the cable it turns everything back on unconditionally? While that's fine with WiFi I don't want eg. Bluetooth to turn on every time I plug in AC. Also, the NO_KEYWORDS thing is a huge bummer for me, I really hate the Q_macros - Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 108503: Add link to "Downloaded Files" directory in kio bluetooth

marked as submitted. Review request for Bluedevil and David Rosca. Changes --- Submitted with commit 1f0dc2e3dcd2f098089c0561322e9b5ebf052551 by David Rosca on behalf of Kai Uwe Broulik to branch master. Bugs: 302964 https://bugs.kde.org/show_bug.cgi?id=302964 Repository: bluedevil

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

> On Dez. 20, 2015, 10:38 vorm., Daniel Vrátil wrote: > > tests/kwayland/waylandconfigreader.cpp, line 110 > > > > > > No need for .toList(), Q_FOREACH can iterate over values of a map. > > Sebastian Kügler

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

waylandconfigreader.cpp (line 33) <https://git.reviewboard.kde.org/r/126381/#comment61546> QVector - Kai Uwe Broulik On Dez. 18, 2015, 3:16 nachm., Sebastian Kügler wrote: > > -

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

tps://git.reviewboard.kde.org/r/126381/#comment61512> Why this change? - Kai Uwe Broulik On Dez. 18, 2015, 3:16 nachm., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

ndOutput backends/kwayland/waylandconfig.cpp (lines 234 - 235) <https://git.reviewboard.kde.org/r/126381/#comment61525> m_outputMap.take(kscreen_id) backends/kwayland/waylandconfig.cpp (line 252) <https://git.reviewboard.kde.org/r/126381/#comment61526> if (!m_outputMap.c

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

tps://git.reviewboard.kde.org/r/126381/#comment61443> [=] captures the this pointer and this->m_syncLoop is still the same syncLoop - Kai Uwe Broulik On Dez. 17, 2015, 6:53 nachm., Sebastian Kügler wrote: > > --- > This i

Re: [Kde-hardware-devel] Review Request 106863: Silence "Profile foo could not activate bar which is a non-existent action" message

triggered, though. (Dunno how to get powerdevil debug console output) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

marked as submitted. Review request for Solid. Changes --- Submitted with commit eca79138c15575f6f523a8680919b407f84da2e2 by Kai Uwe Broulik to branch master. Bugs: 352235 https://bugs.kde.org/show_bug.cgi?id=352235 Repository: powerdevil Description --- Whenever Chrome plays

Re: [Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

- Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126145/#review89497 --- On Dez. 14, 2015, 9:04 nachm., Kai Uwe Brou

Re: [Kde-hardware-devel] Review Request 126146: [XRandRBrightness] Don't call for xrandr if it's not available

marked as submitted. Review request for Solid and Thomas Lübking. Changes --- Submitted with commit dde0ecce02259a26655737e6674950e2e303bc6f by Kai Uwe Broulik to branch Plasma/5.5. Bugs: 352462 https://bugs.kde.org/show_bug.cgi?id=352462 Repository: powerdevil Description

Re: [Kde-hardware-devel] Review Request 126146: [XRandRBrightness] Don't call for xrandr if it's not available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126146/#review89281 --- Ping - Kai Uwe Broulik On Nov. 23, 2015, 4 nachm., Kai Uwe

Re: [Kde-hardware-devel] Review Request 126138: Use absolute brightness value in conservative check when loading profile

marked as submitted. Review request for Solid. Changes --- Submitted with commit 6b4ffe32367a6413d8c270480445a4955d63e71f by Kai Uwe Broulik to branch Plasma/5.5. Bugs: 355687 https://bugs.kde.org/show_bug.cgi?id=355687 Repository: powerdevil Description --- There's a check

[Kde-hardware-devel] Review Request 126146: [XRandRBrightness] Don't call for xrandr if it's not available

://git.reviewboard.kde.org/r/126146/diff/ Testing --- Still works, didn't test without xrandr. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 126145: Wait 5s before enforcing inhibition

ck in VLC while Chrome was playing -> got two inhibitions shortly thereafter Closed VLC -> Only Chrome's inhibition left Asked for someone to send me a message, received it -> No inhibition was enforced because the sound was too short Thanks

[Kde-hardware-devel] Review Request 126138: Use absolute brightness value in conservative check when loading profile

- daemon/actions/bundled/brightnesscontrol.cpp d00d6ed daemon/actions/bundled/keyboardbrightnesscontrol.cpp a52dd75 Diff: https://git.reviewboard.kde.org/r/126138/diff/ Testing --- Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing

Re: [Kde-hardware-devel] Install UdevQt headers in Solid

+1 but I guess we should review and cleanup that stuff whilst at it, however I don't really have time to make this stuff Frameworks ready Gesendet von meinem BlackBerry 10-Smartphone.   Originalnachricht   Von: David Rosca Gesendet: Donnerstag, 5. November 2015 14:27 An:

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

59089> if (!pid) { continue; } ? dataengines/devicenotifications/ksolidnotify.cpp (line 157) <https://git.reviewboard.kde.org/r/125248/#comment59091> Could use plural handling: i18np("Could not … are opened in \"%1\".", "Could

Re: [Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

> On Sept. 16, 2015, 10:11 vorm., Kai Uwe Broulik wrote: > > I really like that! > > > > The device notifier UI itself is questionable with the popup telling us > > "the device xyz failed to unmount" rather than just highlighting the device > > a

Re: [Kde-hardware-devel] Review Request 125026: Wayland implementation for DPMS

ult not here? daemon/actions/dpms/powerdevildpmsaction.cpp (line 45) <https://git.reviewboard.kde.org/r/125026/#comment58650> Why this? daemon/actions/dpms/waylanddpmshelper.h (lines 41 - 42) <https://git.reviewboard.kde.org/r/125026/#comment58651> Add space - Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 124730: [solid-device-automounter] Port to KF5

even when I re-attach the same device. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 124730: [solid-device-automounter] Port to KF5

marked as submitted. Review request for Plasma, Solid and Torrie Fischer. Changes --- Submitted with commit e8a571f09557e9cb597b466c1f61bdb4b68a6913 by Kai Uwe Broulik to branch master. Bugs: 351003 https://bugs.kde.org/show_bug.cgi?id=351003 Repository: plasma-desktop Description

Re: [Kde-hardware-devel] Review Request 124778: Suspend using UPower in case of ConsoleKit 1

marked as submitted. Review request for Solid and Eric Koegel. Changes --- Submitted with commit 41d369f7c57b31f13cb120d09b3e9f71119d86f4 by Kai Uwe Broulik to branch Plasma/5.4. Bugs: 351365 https://bugs.kde.org/show_bug.cgi?id=351365 Repository: powerdevil Description

Re: [Kde-hardware-devel] Review Request 124730: [solid-device-automounter] Port to KF5

. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

: https://git.reviewboard.kde.org/r/123263/#review83263 --- On Juli 31, 2015, 7:15 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 124318: Load DPMSAction only on xcb platform

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124318/#review82314 --- Ship it! Thanks! - Kai Uwe Broulik On Juli 10, 2015, 9:21

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

work for me. - Kai Uwe Broulik On Juli 10, 2015, 1:23 nachm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475

Re: [Kde-hardware-devel] Review Request 124037: Allow to cancel critical battery timer

--- On Juni 8, 2015, 5:30 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124037

Re: [Kde-hardware-devel] Review Request 124037: Allow to cancel critical battery timer

marked as submitted. Review request for Plasma, Solid and KDE Usability. Changes --- Submitted with commit 9bb399ef24a3323788ef3084f2e404c8831f251b by Kai Uwe Broulik to branch master. Repository: powerdevil Description --- To prevent David from eventually breaking his bones

[Kde-hardware-devel] Review Request 124037: Allow to cancel critical battery timer

fit into the popup at all now) File Attachments Notification with close button https://git.reviewboard.kde.org/media/uploaded/files/2015/06/07/f99c0164-4436-462f-974b-ddc5df0ce500__powerdevilcanceltimeout.png Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

On Mai 10, 2015, 5:08 nachm., Kai Uwe Broulik wrote: daemon/backends/upower/powerdevilupowerbackend.cpp, line 175 https://git.reviewboard.kde.org/r/123475/diff/2/?file=362775#file362775line175 Somehow that code path is never executed making init stuck when XRandR is not supported

Re: [Kde-hardware-devel] Review Request 123704: Consider overall percentage when emitting battery warning on startup

marked as submitted. Review request for Solid. Changes --- Submitted with commit d3d2ebcfd214a892ac79484cfb8cb6fcbf7fc917 by Kai Uwe Broulik to branch Plasma/5.3. Bugs: 347470 https://bugs.kde.org/show_bug.cgi?id=347470 Repository: powerdevil Description --- When you happened

[Kde-hardware-devel] Review Request 123704: Consider overall percentage when emitting battery warning on startup

/diff/ Testing --- Notification still seems to work fine on my one battery system; I don't have two batteries, so this needs further testing. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review79218 --- On April 5, 2015, 8:56 nachm., Kai Uwe Broulik wrote

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

On April 19, 2015, 8:20 nachm., Albert Vaca Cintora wrote: I don't understand the portable media player part. Does it do something? Besides that, I think we need to fix the issues opened by Lamarque and Alex, but looks good to me :) Kai Uwe Broulik wrote: Solid has been designed

[Kde-hardware-devel] Review Request 123418: Add X11 guards

/xrandrbrightness.cpp f1cd5a5 daemon/kwinkscreenhelpereffect.h 4d0a163 daemon/kwinkscreenhelpereffect.cpp dec5d65 Diff: https://git.reviewboard.kde.org/r/123418/diff/ Testing --- Compiles both with and without HAVE_XCB but I don't have a Wayland setup. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

/#review78538 --- On April 5, 2015, 5:31 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123262

Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

--- On April 5, 2015, 3:44 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123262

Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

/powerdevilupowerbackend.cpp 87b9cc7 Diff: https://git.reviewboard.kde.org/r/123262/diff/ Testing --- It's working pretty nicely, I can adjust brightness of my desktop monitor through battery monitor and have it automatically dimmed after a timeout. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 123256: Hardcode device order

marked as submitted. Review request for Solid. Changes --- Submitted with commit 6219c8e4877b38962af2e0d5db0f8eaa70c03bb8 by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- Rather than going through the device type enum backwards where Battery comes

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

On März 29, 2015, 6 nachm., Kai Uwe Broulik wrote: File Attachment: snapshot4.png - snapshot4.png https://git.reviewboard.kde.org/r/123164/#fcomment383 It's Paired, what would Connect do? David Rosca wrote: It would connect to the device :) That means, connect the HID

Re: [Kde-hardware-devel] Review Request 122414: Port DPMS to XCB

button can turn off the screen, and after timeout turns off and properly wakes up again. Did not test inhibition handling. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: [Kde-hardware-devel] Review Request 121995: Animate screen brightness change

or using the brightness keys, the screen brightness changes smoothly with the OSD reporting the proper value and battery monitor sliders adjusting slightly delayed. Didn't test using the helper rather than XRandr. Thanks, Kai Uwe Broulik ___ Kde-hardware

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/#review75557 --- I suppose this is obsolete now? - Kai Uwe Broulik On Jan

Re: [Kde-hardware-devel] Review Request 122283: Increase the preferred number of screen brightness steps to 20.

it, but now I managed to get the X server use the intel backlight interface instead. Could you rebase this patch to current master? It didn't apply. - Kai Uwe Broulik On Jan. 27, 2015, 11:10 nachm., Nikita Skovoroda wrote

[Kde-hardware-devel] Review Request 122414: Port DPMS to XCB

not test inhibition handling. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122343: Make sure that brightness up/down actions produce visible changes.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122343/#review75135 --- Ship it! Ship It! - Kai Uwe Broulik On Jan. 31, 2015, 7

Re: [Kde-hardware-devel] Review Request 107505: Show Battery Low notification on startup along with Broken Battery notifications so it doesn't appear before workspace is up

, after 30 seconds in the workspace, I got a notification saying my battery is low. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 122316: Fix powerdevil brightness calls breaking kded #2

on the helper now but I was never able to reproduce the problem. The OSD does not show up when changing the brightness through the keys but I don't know whether that was the case without this patch already. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing

Re: [Kde-hardware-devel] Review Request 122316: Fix powerdevil brightness calls breaking kded #2

the problem. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122316: Fix powerdevil brightness calls breaking kded #2

/backends/upower/powerdevilupowerbackend.cpp 51a052a Diff: https://git.reviewboard.kde.org/r/122316/diff/ Testing --- I'm running on the helper now but I was never able to reproduce the problem. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

/uploaded/files/2015/01/24/7ea3d406-0f0a-491b-9539-9de93e42bb4b__powerdevilstuff2.png Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

behavior, and then rethink adding the options. Inline, a few niggles about naming when reading the code and trying to understand it, nothing really major. Kai Uwe Broulik wrote: That's why I added the usability group. :) You are right that actually neither of these features

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

://git.reviewboard.kde.org/r/121386/diff/ Testing --- My hopes were that it would give us a more precise backlight handling but I get a range of 0..10 nonetheless. Other than that seems to work exactly like it did before. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121915/#review74374 --- This has been submitted, right? - Kai Uwe Broulik On Jan

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

://git.reviewboard.kde.org/r/121386/diff/ Testing --- My hopes were that it would give us a more precise backlight handling but I get a range of 0..10 nonetheless. Other than that seems to work exactly like it did before. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 122128: Don't listen for Login1 Lock signal anymore

, visit: https://git.reviewboard.kde.org/r/122128/#review74288 --- On Jan. 18, 2015, 4:05 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

/powerdevilupowerbackend.cpp https://git.reviewboard.kde.org/r/122151/#comment51592 Same here - Kai Uwe Broulik On Jan. 19, 2015, 3:46 nachm., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 122130: Expose inhibitions over dbus

org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement/PolicyAgent org.kde.Solid.PowerManagement.PolicyAgent.ListInhibitions Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

a range of 0..10 nonetheless. Other than that seems to work exactly like it did before. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 122128: Don't listen for Login1 Lock signal anymore

, I have no idea how I could tell Login1 to tell others to lock. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122130: Expose inhibitions over dbus

://git.reviewboard.kde.org/r/122130/diff/ Testing --- Works, I can list the inhibitions using qdbus --literal org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement/PolicyAgent org.kde.Solid.PowerManagement.PolicyAgent.ListInhibitions Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

://git.reviewboard.kde.org/r/122048/#review74001 --- On Jan. 13, 2015, 11:16 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 121992: Add Battery energyFull and energyFullDesign

and Windows as well (and IOKit stubs) but I cannot test these, hence adding kdewin and kde-mac groups. Also, we should really add Q_DECL_OVERRIDE all over the place since adding new methods at 5 different places is quite error-prone. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121992: Add Battery energyFull and energyFullDesign

. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 121992: Add Battery energyFull and energyFullDesign

groups. Also, we should really add Q_DECL_OVERRIDE all over the place since adding new methods at 5 different places is quite error-prone. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman

[Kde-hardware-devel] Review Request 121995: Animate screen brightness change

sliders adjusting slightly delayed. Didn't test using the helper rather than XRandr. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121798: KScreen fade effect connector for PowerDevil

and then tell Logind to suspend which completely takes care of the locking (and more importantly the waiting for the lock to be established *before* powering down). Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org

Re: [Kde-hardware-devel] Review Request 121857: Remove lock screen on suspend and use fade effect

://git.reviewboard.kde.org/r/121857/diff/ Testing --- Suspending the machine invokes the fade effect and the screen locks, if enabled, both if Logind1 is connected or not (fallback). Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121798: KScreen fade effect connector for PowerDevil

Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121798: KScreen fade effect connector for PowerDevil

the fade effect, wait for it to be done and then tell Logind to suspend which completely takes care of the locking (and more importantly the waiting for the lock to be established *before* powering down). Thanks, Kai Uwe Broulik ___ Kde-hardware

[Kde-hardware-devel] Review Request 121857: Remove lock screen on suspend and use fade effect

and the screen locks, if enabled, both if Logind1 is connected or not (fallback). Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121815: Cleanup BrightnessOSDWidget

/brightnessosdwidget.cpp f85e25c Diff: https://git.reviewboard.kde.org/r/121815/diff/ Testing --- Works like it did before. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

[Kde-hardware-devel] Review Request 121798: KScreen fade effect connector for PowerDevil

to be established *before* powering down). Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 121815: Cleanup BrightnessOSDWidget

like it did before. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121693: Wait for notification service before emitting them

of when they have been for the first time. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121791: Get rid of profile migrator

daemon/powerdevilprofilegenerator.h 1882e02 daemon/powerdevilprofilegenerator.cpp 9ae5b73 Diff: https://git.reviewboard.kde.org/r/121791/diff/ Testing --- Removed my powermanagementprofilesrc file, restarted kded, created proper default profile. Thanks, Kai Uwe Broulik

[Kde-hardware-devel] Review Request 121791: Get rid of profile migrator

Diff: https://git.reviewboard.kde.org/r/121791/diff/ Testing --- Removed my powermanagementprofilesrc file, restarted kded, created proper default profile. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org

Re: [Kde-hardware-devel] Review Request 121699: Expose whether a lid is present over dbus

/powerdevilcore.cpp 05ee2e6 Diff: https://git.reviewboard.kde.org/r/121699/diff/ Testing --- isLidPresent is true on my laptop, dunno why the method is not const but the other one isn't either. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel

[Kde-hardware-devel] Review Request 121693: Wait for notification service before emitting them

it was not running (30s timeout), and started plasma shortly after kded (emit once service is there). Works fine, looks much sleeker now, and notifications also only seem to be fired once regardless of when they have been for the first time. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121693: Wait for notification service before emitting them

/121693/#comment50583 Qt 5.4 would allow us to use a lambda instead - Kai Uwe Broulik On Dez. 27, 2014, 12:53 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 121506: Add setBrightnessSilent calls that don't show the OSD

/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 58a1b80 Diff: https://git.reviewboard.kde.org/r/121506/diff/ Testing --- The calls work as expected for both keyboard and screen, both silent and normal. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121506: Add setBrightnessSilent calls that don't show the OSD

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121506/#review72376 --- Ping - Kai Uwe Broulik On Dez. 14, 2014, 1 nachm., Kai Uwe

Re: [Kde-hardware-devel] Review Request 121603: Turn off keyboard in DPMS action

it permitted here. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 121603: Turn off keyboard in DPMS action

in sync with the screen (as much as it can be synced given the dpms is handled by the X server) and turns back on when moving the mouse again. Don't know whether the C++11 initializer list I used it permitted here. Thanks, Kai Uwe Broulik ___ Kde

Re: [Kde-hardware-devel] Review Request 121530: Remove lock screen on suspend

it should become possible to query the backend in advance whether it supports logind and lock manually if not. - Kai Uwe Broulik On Dez. 15, 2014, 10:45 vorm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply

[Kde-hardware-devel] Review Request 121537: Remove systemd version checks

/powerdevilupowerbackend.cpp 263788d Diff: https://git.reviewboard.kde.org/r/121537/diff/ Testing --- Compiles, suspending the session still works and now uses the Login1suspendjob here, although I don't use systemd but I do have logind. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121537: Remove systemd version checks

/ Testing --- Compiles, suspending the session still works and now uses the Login1suspendjob here, although I don't use systemd but I do have logind. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https

Re: [Kde-hardware-devel] Review Request 121538: Add aboutToSuspend signal

--- Not really, signal appears on qdbusviewer though. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

  1   2   >