Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123388/#review79116 --- kded/bluetoothmonitor.h (line 37)

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread David Rosca
On April 17, 2015, 12:41 p.m., Lamarque Souza wrote: kded/bluetoothmonitor.h, line 41 https://git.reviewboard.kde.org/r/123388/diff/2/?file=361568#file361568line41 Is passing connectionName really necessary? The old code queries BlueZ to get the device name and use it as

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread David Rosca
On April 17, 2015, 12:41 p.m., Lamarque Souza wrote: kded/bluetoothmonitor.h, line 41 https://git.reviewboard.kde.org/r/123388/diff/2/?file=361568#file361568line41 Is passing connectionName really necessary? The old code queries BlueZ to get the device name and use it as

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123388/#review79113 --- Looks good in my opinion, but I would like also others to

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread Lamarque Souza
On April 17, 2015, 12:41 p.m., Lamarque Souza wrote: kded/bluetoothmonitor.h, line 41 https://git.reviewboard.kde.org/r/123388/diff/2/?file=361568#file361568line41 Is passing connectionName really necessary? The old code queries BlueZ to get the device name and use it as

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123388/#review79126 --- Ship it! Ship It! - Lamarque Souza On April 17, 2015,