Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-07-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/ --- (Updated July 11, 2015, 8:01 a.m.) Status -- This change has been

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-07-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/#review82337 --- Ship it! Thanks! Both XRandrBrightness and the helper still

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-05-11 Thread Kai Uwe Broulik
On Mai 10, 2015, 5:08 nachm., Kai Uwe Broulik wrote: daemon/backends/upower/powerdevilupowerbackend.cpp, line 175 https://git.reviewboard.kde.org/r/123475/diff/2/?file=362775#file362775line175 Somehow that code path is never executed making init stuck when XRandR is not

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-24 Thread Martin Gräßlin
On April 23, 2015, 1:32 p.m., Aleix Pol Gonzalez wrote: daemon/backends/upower/powerdevilupowerbackend.cpp, line 161 https://git.reviewboard.kde.org/r/123475/diff/1/?file=362676#file362676line161 Is it fine to use exec() here? no, I missed that one :-( - Martin

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/ --- (Updated April 24, 2015, 8:29 a.m.) Review request for Solid and Kai Uwe

[Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/ --- Review request for Plasma, Solid and Kai Uwe Broulik. Repository:

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/#review79375 --- daemon/backends/upower/powerdevilupowerbackend.cpp (line