Re: [Kde-hardware-devel] Review Request 128083: Find CPUs by subsystem rather than driver

2016-06-06 Thread Lamarque Souza 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128083/#review96241
---


Ship it!




Ship It!

- Lamarque Souza


On June 3, 2016, 12:15 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128083/
> ---
> 
> (Updated June 3, 2016, 12:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> The driver "processor" is part of the ACPI module, which isn't used by
> all systems and architectures.
> 
> Detecting devices by CPU subsystem seems to work, and whilst
> theoretically this change could pick up a non CPU device in the same 
> subsystem they
> would be filtered out by the udevmanager which has an extra check
> that CPUs are valid and not just empty sockets.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udev/udevdevice.cpp 
> 9fb5e092679cd3c6860b2055cf3dedb915addfda 
>   src/solid/devices/backends/udev/udevmanager.cpp 
> 3f3a671798e84e6d577df7c3b9b80150ac4d01fc 
> 
> Diff: https://git.reviewboard.kde.org/r/128083/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 128084: Handle reading /proc/cpuinfo for Arm processors

2016-06-06 Thread Lamarque Souza 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128084/#review96240
---




src/solid/devices/backends/udev/cpuinfo.cpp (line 70)


This extracts the current cpu speed, not the maximum. Is that what you 
want? Yes then I think you should rename extractCpuSpeed() to 
extractCurrentCpuSpeed().


- Lamarque Souza


On June 3, 2016, 12:15 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128084/
> ---
> 
> (Updated June 3, 2016, 12:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> The /proc/cpuinfo format is wildly different between architectures, our
> current method for scraping data only works on x86.
> 
> This patch moves all parsing logic into cpuinfo.cpp and adds a fallback
> search that works for arm and arm64 architectures.
> 
> 
> https://github.com/torvalds/linux/blob/master/arch/x86/kernel/cpu/proc.c#L55
> 
> https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c#L104
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udev/cpuinfo.h 
> e8d5dda729535e767b4640f41a01f4d0e27e6542 
>   src/solid/devices/backends/udev/cpuinfo.cpp 
> ecaad58ceee34d46343b67015c03d9a3de87ee72 
>   src/solid/devices/backends/udev/udevdevice.cpp 
> 9fb5e092679cd3c6860b2055cf3dedb915addfda 
>   src/solid/devices/backends/udev/udevprocessor.cpp 
> 80d14f5b40b4478a32d7c113747fe9da50e54b6f 
> 
> Diff: https://git.reviewboard.kde.org/r/128084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 128085: Fix check that CPU is a valid CPU

2016-06-06 Thread Lamarque Souza 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128085/#review96239
---


Ship it!




Ship It!

- Lamarque Souza


On June 3, 2016, 12:15 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128085/
> ---
> 
> (Updated June 3, 2016, 12:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> We have a check that an devices/system/cpu/cpuN entry contains a
> processor and not just an empty socket, however it relies on somewhat
> outdated /sys files.
> 
> cpuN/cpufreq isn't guaranteed to exist as for some systems (my AMD
> processor at least).
> 
> The docs in the linux kernel imply topology/core_id should always exist,
> and should still work as a valid check that we have a populated CPU
> socket.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udev/udevmanager.cpp 
> 3f3a671798e84e6d577df7c3b9b80150ac4d01fc 
> 
> Diff: https://git.reviewboard.kde.org/r/128085/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 128085: Fix check that CPU is a valid CPU

2016-06-06 Thread Rohan Garg 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128085/#review96238
---



Hi
Could we get a shipit on these? I'd really appreciate it if we could have these 
in Frameworks 5.23

- Rohan Garg


On June 3, 2016, 5:45 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128085/
> ---
> 
> (Updated June 3, 2016, 5:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> We have a check that an devices/system/cpu/cpuN entry contains a
> processor and not just an empty socket, however it relies on somewhat
> outdated /sys files.
> 
> cpuN/cpufreq isn't guaranteed to exist as for some systems (my AMD
> processor at least).
> 
> The docs in the linux kernel imply topology/core_id should always exist,
> and should still work as a valid check that we have a populated CPU
> socket.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udev/udevmanager.cpp 
> 3f3a671798e84e6d577df7c3b9b80150ac4d01fc 
> 
> Diff: https://git.reviewboard.kde.org/r/128085/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 128084: Handle reading /proc/cpuinfo for Arm processors

2016-06-06 Thread Rohan Garg 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128084/#review96237
---



Hi
Could we get a shipit on these? I'd really appreciate it if we could have these 
in Frameworks 5.23

- Rohan Garg


On June 3, 2016, 5:45 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128084/
> ---
> 
> (Updated June 3, 2016, 5:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> The /proc/cpuinfo format is wildly different between architectures, our
> current method for scraping data only works on x86.
> 
> This patch moves all parsing logic into cpuinfo.cpp and adds a fallback
> search that works for arm and arm64 architectures.
> 
> 
> https://github.com/torvalds/linux/blob/master/arch/x86/kernel/cpu/proc.c#L55
> 
> https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c#L104
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udev/cpuinfo.h 
> e8d5dda729535e767b4640f41a01f4d0e27e6542 
>   src/solid/devices/backends/udev/cpuinfo.cpp 
> ecaad58ceee34d46343b67015c03d9a3de87ee72 
>   src/solid/devices/backends/udev/udevdevice.cpp 
> 9fb5e092679cd3c6860b2055cf3dedb915addfda 
>   src/solid/devices/backends/udev/udevprocessor.cpp 
> 80d14f5b40b4478a32d7c113747fe9da50e54b6f 
> 
> Diff: https://git.reviewboard.kde.org/r/128084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 128083: Find CPUs by subsystem rather than driver

2016-06-06 Thread Rohan Garg 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128083/#review96236
---



Hi
Could we get a shipit on these? I'd really appreciate it if we could have these 
in Frameworks 5.23

- Rohan Garg


On June 3, 2016, 5:45 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128083/
> ---
> 
> (Updated June 3, 2016, 5:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> The driver "processor" is part of the ACPI module, which isn't used by
> all systems and architectures.
> 
> Detecting devices by CPU subsystem seems to work, and whilst
> theoretically this change could pick up a non CPU device in the same 
> subsystem they
> would be filtered out by the udevmanager which has an extra check
> that CPUs are valid and not just empty sockets.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udev/udevdevice.cpp 
> 9fb5e092679cd3c6860b2055cf3dedb915addfda 
>   src/solid/devices/backends/udev/udevmanager.cpp 
> 3f3a671798e84e6d577df7c3b9b80150ac4d01fc 
> 
> Diff: https://git.reviewboard.kde.org/r/128083/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel