Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-09-10 Thread Aleix Pol Gonzalez
> On July 31, 2015, 9:38 p.m., Aleix Pol Gonzalez wrote: > > Is it done yet? What's the status? > > Kai Uwe Broulik wrote: > I don't know, someone marked it as submitted but it cearly isn't. > > Albert Vaca Cintora wrote: > What's left before we can merge it? Bump. - Aleix

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-07-31 Thread Albert Vaca Cintora
On July 31, 2015, 12:38 p.m., Aleix Pol Gonzalez wrote: Is it done yet? What's the status? Kai Uwe Broulik wrote: I don't know, someone marked it as submitted but it cearly isn't. What's left before we can merge it? - Albert

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-07-31 Thread Kai Uwe Broulik
On Juli 31, 2015, 7:38 nachm., Aleix Pol Gonzalez wrote: Is it done yet? What's the status? I don't know, someone marked it as submitted but it cearly isn't. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit:

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-07-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review83263 --- Is it done yet? What's the status? - Aleix Pol Gonzalez On

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-07-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated jul. 31, 2015, 9:15 p.m.) Status -- This change has been

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-04-26 Thread Kai Uwe Broulik
On April 19, 2015, 8:20 nachm., Albert Vaca Cintora wrote: I don't understand the portable media player part. Does it do something? Besides that, I think we need to fix the issues opened by Lamarque and Alex, but looks good to me :) Solid has been designed in the pre-Smartphone era, it

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-04-26 Thread Markus Slopianka
On April 19, 2015, 8:20 nachm., Albert Vaca Cintora wrote: I don't understand the portable media player part. Does it do something? Besides that, I think we need to fix the issues opened by Lamarque and Alex, but looks good to me :) Kai Uwe Broulik wrote: Solid has been designed

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-04-26 Thread Kai Uwe Broulik
On April 19, 2015, 8:20 nachm., Albert Vaca Cintora wrote: I don't understand the portable media player part. Does it do something? Besides that, I think we need to fix the issues opened by Lamarque and Alex, but looks good to me :) Kai Uwe Broulik wrote: Solid has been designed

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-04-19 Thread Lamarque Souza
On April 5, 2015, 5:54 p.m., Lamarque Souza wrote: src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp, line 79 https://git.reviewboard.kde.org/r/123263/diff/1/?file=360131#file360131line79 Is it possible to retrieve a correct value for this and the other values below

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-04-19 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review79218 --- I don't understand the portable media player part. Does it do

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-04-19 Thread Albert Vaca Cintora
On abr. 5, 2015, 10:54 a.m., Lamarque Souza wrote: src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp, line 79 https://git.reviewboard.kde.org/r/123263/diff/1/?file=360131#file360131line79 Is it possible to retrieve a correct value for this and the other values below

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-04-05 Thread Lamarque Souza
On April 5, 2015, 5:54 p.m., Lamarque Souza wrote: src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp, line 116 https://git.reviewboard.kde.org/r/123263/diff/1/?file=360137#file360137line116 Answering your question from this patch's description: yes, I prefer that you