Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-04-01 Thread Stefan Bruens
On Montag, 13. März 2017 22:37:51 CEST Albert Astals Cid wrote: > > On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote: > > > Sorry for the long wait… I was under the impression it landed a long > > > time ago. > > > > > > Itook your patch and ported it to Frameworks 5, please see the review at

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Ben Cooksley
On Tue, Mar 14, 2017 at 11:28 AM, Brüns, Stefan wrote: > On Montag, 13. März 2017 22:37:51 CET Albert Astals Cid wrote: >> > On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote: >> > > Sorry for the long wait… I was under the impression it landed a long >> > > time

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Brüns , Stefan
On Montag, 13. März 2017 22:37:51 CET Albert Astals Cid wrote: > > On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote: > > > Sorry for the long wait… I was under the impression it landed a long > > > time ago. > > > > > > Itook your patch and ported it to Frameworks 5, please see the review at >

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113587/ --- (Updated March 13, 2017, 9:37 p.m.) Status -- This change has been

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Albert Astals Cid
> On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote: > > Sorry for the long wait… I was under the impression it landed a long time > > ago. > > > > Itook your patch and ported it to Frameworks 5, please see the review at > > https://phabricator.kde.org/D5034 I'll discard this one then. -

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113587/#review102827 --- Sorry for the long wait… I was under the impression it

Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2014-06-21 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113587/ --- (Updated June 22, 2014, 1:39 a.m.) Review request for kdelibs and Solid.

Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-24 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113587/#review44346 --- So, ship it or drop it? - Stefan Brüns On Nov. 3, 2013,

Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113587/#review42884 --- solid/solid/backends/fstab/fstabdevice.cpp

Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-03 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113587/ --- (Updated Nov. 3, 2013, 2:36 p.m.) Review request for Solid. Changes

Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-03 Thread Stefan Brüns
On Nov. 3, 2013, 11:41 a.m., Kai Uwe Broulik wrote: solid/solid/backends/fstab/fstabdevice.cpp, line 60 http://git.reviewboard.kde.org/r/113587/diff/1/?file=208373#file208373line60 Needs i18n(c)? This was leveraged from the old code, but will change ... - Stefan

Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-03 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113587/ --- (Updated Nov. 3, 2013, 2:41 p.m.) Review request for Solid. Repository:

[Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-02 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113587/ --- Review request for Solid. Repository: kdelibs Description ---