Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2017-07-28 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated July 28, 2017, 12:05 p.m.) Status -- This change has been

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2017-02-26 Thread Martin Klapetek
> On Feb. 22, 2017, 8:14 p.m., Martin Klapetek wrote: > > As I have explained many many times, I will *not* accept any patch > > including/extending plugin queue. The whole plugin queue has to go together > > with the mpris2 thing. > > > > I'm sorry but if you don't intend to work towards

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2017-02-26 Thread James Smith
> On Feb. 22, 2017, 12:14 p.m., Martin Klapetek wrote: > > As I have explained many many times, I will *not* accept any patch > > including/extending plugin queue. The whole plugin queue has to go together > > with the mpris2 thing. > > > > I'm sorry but if you don't intend to work towards

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2017-02-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/#review102574 --- As I have explained many many times, I will *not* accept

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2017-02-22 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated Feb. 22, 2017, 11:52 a.m.) Review request for Telepathy,

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2017-02-13 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated Feb. 13, 2017, 7:27 p.m.) Review request for Telepathy, Dominik

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2017-01-29 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated Jan. 29, 2017, 3:20 p.m.) Review request for Telepathy, Dominik

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2017-01-28 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated Jan. 28, 2017, 4:54 p.m.) Review request for Telepathy, Dominik

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-11-25 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated Nov. 25, 2016, 2:36 p.m.) Review request for Telepathy, Dominik

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-11-21 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated Nov. 21, 2016, 10:29 p.m.) Review request for Telepathy,

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-09-22 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated Sept. 22, 2016, 6:41 p.m.) Review request for Telepathy,

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-09-22 Thread James Smith
> On Sept. 21, 2016, 9:23 a.m., Martin Klapetek wrote: > > > Use c++11 for loops instead of Q_FOREACH for new code. > > > > Please don't do that, it's slow. See > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ for > > more details. Q_FOREACH is going away, and we

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-09-17 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated Sept. 17, 2016, 10:03 p.m.) Review request for Telepathy,

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-06-23 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated June 24, 2016, 3:37 a.m.) Review request for Telepathy, Dominik

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-04-21 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated April 21, 2016, 6:09 a.m.) Review request for Telepathy.

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-04-10 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated April 10, 2016, 9:51 p.m.) Review request for Telepathy.

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-04-07 Thread Martin Klapetek
> On April 8, 2016, 12:56 a.m., David Edmundson wrote: > > Ship It! fwiw, I still think this is quite an overkill, especially when there is noone to actually maintain it. We should go the other way, not add more complexity into code that just increases space for bugs that noone will fix. -

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-04-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/#review94406 --- Ship it! Ship It! - David Edmundson On April 4, 2016,

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-04-04 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated April 4, 2016, 6:52 p.m.) Review request for Telepathy.

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-04-03 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated April 4, 2016, 4:20 a.m.) Review request for Telepathy.

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-03-11 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated March 12, 2016, 7:40 a.m.) Review request for Telepathy.

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-03-06 Thread James Smith
> On March 3, 2016, 10:40 p.m., David Edmundson wrote: > > account-status-helper.cpp, line 86 > > > > > > why are we changing presence in the destructor? > > > > that means on logout we'll *start*

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-03-06 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated March 7, 2016, 6:50 a.m.) Review request for Telepathy. Bugs:

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

2016-03-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/#review93144 --- account-status-helper.cpp (line 60)