Re: Review Request 128961: [KTp/Declarative/MessagesModel] Fixed allocation of modelIndex variable in onMessageSent()

2016-09-20 Thread Alexandr Akulich

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128961/
---

(Updated Sept. 20, 2016, 2:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for Telepathy.


Changes
---

Submitted with commit 2706d8d60cedcdcc31067122c909797d506ff629 by Alexandr 
Akulich to branch master.


Repository: ktp-common-internals


Description
---

We actually story the index, so we should not just reference it.


Diffs
-

  KTp/Declarative/messages-model.cpp 6823574 

Diff: https://git.reviewboard.kde.org/r/128961/diff/


Testing
---

It compiles.


Thanks,

Alexandr Akulich



Re: Review Request 128961: [KTp/Declarative/MessagesModel] Fixed allocation of modelIndex variable in onMessageSent()

2016-09-20 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128961/#review99331
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Sept. 20, 2016, 3:34 p.m., Alexandr Akulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128961/
> ---
> 
> (Updated Sept. 20, 2016, 3:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> ---
> 
> We actually story the index, so we should not just reference it.
> 
> 
> Diffs
> -
> 
>   KTp/Declarative/messages-model.cpp 6823574 
> 
> Diff: https://git.reviewboard.kde.org/r/128961/diff/
> 
> 
> Testing
> ---
> 
> It compiles.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>