Re: Review Request 130192: ktp-kded-module improvements

2017-11-21 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130192/ --- (Updated Nov. 22, 2017, 2:04 a.m.) Status -- This change has been

Re: Review Request 130192: ktp-kded-module improvements

2017-08-21 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130192/ --- (Updated Aug. 21, 2017, 10:01 p.m.) Review request for Telepathy.

Re: Review Request 130192: ktp-kded-module improvements

2017-08-10 Thread James Smith
> On Aug. 9, 2017, 10:57 p.m., James Smith wrote: > > config/telepathy-kded-config.cpp, line 250 > > > > > > Should the entire autoconnect enum / text config entry be changed to a > > simple bool config entry?

Re: Review Request 130192: ktp-kded-module improvements

2017-08-01 Thread James Smith
> On July 28, 2017, 2:25 p.m., David Edmundson wrote: > > account-status-helper.cpp, line 60 > > > > > > stick in the top before { please > > > > > > Also, can you make this not leak > > Martin