Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-05 Thread Martin Gräßlin
On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: Any particular reason for not using an abstract class? The D macro makes the code a bit surprising to read. see discussion of https://git.reviewboard.kde.org/r/115225/ (comment thread started by Aaron) - I wanted to keep the same

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 5, 2014, 4:46 p.m.) Review request for KDE Frameworks,

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-05 Thread Aurélien Gâteau
On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: Any particular reason for not using an abstract class? The D macro makes the code a bit surprising to read. Martin Gräßlin wrote: see discussion of https://git.reviewboard.kde.org/r/115225/ (comment thread started by Aaron) - I

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-05 Thread Martin Gräßlin
On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: Any particular reason for not using an abstract class? The D macro makes the code a bit surprising to read. Martin Gräßlin wrote: see discussion of https://git.reviewboard.kde.org/r/115225/ (comment thread started by Aaron) - I

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 5, 2014, 5:55 p.m.) Review request for KDE Frameworks,

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-05 Thread Aurélien Gâteau
On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: Any particular reason for not using an abstract class? The D macro makes the code a bit surprising to read. Martin Gräßlin wrote: see discussion of https://git.reviewboard.kde.org/r/115225/ (comment thread started by Aaron) - I

[kde-windows] [Bug 330824] Entry Point Not Found qgpgme.dll

2014-02-05 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=330824 Christoph Feck christ...@maxiom.de changed: What|Removed |Added Component|Core|general

[kde-windows] [Bug 330827] When I start kde on cygwin64, kded4 seems like go to infinity loop and KDE stucks. If i remove kded, all OK, but all servcies are disabled

2014-02-05 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=330827 Christoph Feck christ...@maxiom.de changed: What|Removed |Added CC||christ...@maxiom.de

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-05 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review49088 --- src/kwindowsystem.cpp

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-05 Thread Andrius da Costa Ribas
On Feb. 6, 2014, 1:14 a.m., Alexander Richardson wrote: src/kwindowsystem.cpp, line 342 https://git.reviewboard.kde.org/r/115459/diff/2-3/?file=242085#file242085line342 The non-MSVC macro has a return statement, I think this one needs it as well Why is this conditioned to

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-05 Thread Martin Gräßlin
On Feb. 6, 2014, 2:14 a.m., Alexander Richardson wrote: src/kwindowsystem.cpp, line 342 https://git.reviewboard.kde.org/r/115459/diff/2-3/?file=242085#file242085line342 The non-MSVC macro has a return statement, I think this one needs it as well Andrius da Costa Ribas wrote: