On April 3, 2015, 5:58 p.m., Andrius da Costa Ribas wrote:
cmake/uriencode.cmake, line 15
https://git.reviewboard.kde.org/r/120648/diff/2/?file=320784#file320784line15
I've tried changing this to:
execute_process(COMMAND perl -MURI::Escape -e print
On April 3, 2015, 3:58 nachm., Andrius da Costa Ribas wrote:
cmake/uriencode.cmake, line 15
https://git.reviewboard.kde.org/r/120648/diff/2/?file=320784#file320784line15
I've tried changing this to:
execute_process(COMMAND perl -MURI::Escape -e print
On Abril 3, 2015, 3:35 p.m., Andrius da Costa Ribas wrote:
src/CMakeLists.txt, line 20
https://git.reviewboard.kde.org/r/120648/diff/2/?file=320785#file320785line20
It's already committed (but there's been a long time since I hadn't
build anything), but now I see that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78445
---
cmake/uriencode.cmake (line 15)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78442
---
src/CMakeLists.txt (line 20)
On April 3, 2015, 5:35 p.m., Andrius da Costa Ribas wrote:
src/CMakeLists.txt, line 20
https://git.reviewboard.kde.org/r/120648/diff/2/?file=320785#file320785line20
It's already committed (but there's been a long time since I hadn't
build anything), but now I see that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review76782
---
Ship it!
Ship It!
- Jeremy Whiting
On Oct. 19, 2014, 6:12
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Feb. 28, 2015, 10:02 p.m.)
Status
--
This change has been
On Oct. 21, 2014, 9:08 p.m., Alex Merry wrote:
Ship It!
Marko Käning wrote:
Hi Alex, did you test this successfully on Windows?
No, I'm expecting Luigi to interpret my shipit as approval of the CMake code in
principle, and to exercise his own judgement in whether it's actually good
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review69055
---
I'll try to set up an OSX/CI VM in such a way that I can test
On Oct. 18, 2014, 8:50 p.m., René J.V. Bertin wrote:
These are both RRs for KF5?
Luigi Toscano wrote:
Yes, otherwise the repository would have been kdelibs. Do you think it
would make sense to backport it?
René J.V. Bertin wrote:
You say that this is for when the path
On Oct. 19, 2014, 10:52 a.m., Alex Merry wrote:
src/CMakeLists.txt, line 19
https://git.reviewboard.kde.org/r/120648/diff/1/?file=320540#file320540line19
You've already included it above...
Luigi Toscano wrote:
This is different, it's in a piece of code inside
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68855
---
Ship it!
Ship It!
- Alex Merry
On Oct. 20, 2014, 12:12
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68696
---
cmake/uriencode.cmake
On Ott. 19, 2014, 12:52 p.m., Alex Merry wrote:
src/CMakeLists.txt, line 19
https://git.reviewboard.kde.org/r/120648/diff/1/?file=320540#file320540line19
You've already included it above...
This is different, it's in a piece of code inside install(CODE...) which is
executed in a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
(Updated Oct. 20, 2014, 2:12 a.m.)
Review request for Build System, KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
---
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68674
---
I guess we're assuming no-one's putting double-quotes in the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68675
---
These are both RRs for KF5?
- René J.V. Bertin
On Oct. 18,
On Ott. 18, 2014, 8:50 p.m., René J.V. Bertin wrote:
These are both RRs for KF5?
Yes, otherwise the repository would have been kdelibs. Do you think it would
make sense to backport it?
- Luigi
---
This is an automatically generated
On Ott. 18, 2014, 8:10 p.m., Alex Merry wrote:
I guess we're assuming no-one's putting double-quotes in the URIs?
It's probably not worth making it more reslient, given the extra complexity
that would entail (you'd either have to do some pre-escaping or write it
out to a temporary
On Oct. 18, 2014, 8:50 p.m., René J.V. Bertin wrote:
These are both RRs for KF5?
Luigi Toscano wrote:
Yes, otherwise the repository would have been kdelibs. Do you think it
would make sense to backport it?
You say that this is for when the path contains spaces, as it happens on
On Ott. 18, 2014, 8:50 p.m., René J.V. Bertin wrote:
These are both RRs for KF5?
Luigi Toscano wrote:
Yes, otherwise the repository would have been kdelibs. Do you think it
would make sense to backport it?
René J.V. Bertin wrote:
You say that this is for when the path
23 matches
Mail list logo
