Re: Review Request 127187: Fix build for MSVC (2013) on Windows

2016-02-29 Thread Thomas Friedrichsmeier
> On Feb. 29, 2016, 2:15 p.m., Ivan Čukić wrote: > > Can you check the latest master - whether it builds - I've removed > > model_updaters from the ActivitiesModel. > > > > I have to say that I really hate MSVC... Yes, latest master builds unmodified. Thanks. Closing. > I have to say that I

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

2016-02-29 Thread Thomas Friedrichsmeier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/ --- (Updated Feb. 29, 2016, 3:07 p.m.) Status -- This change has been

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

2016-02-29 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/#review92909 --- Can you check the latest master - whether it builds - I've

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

2016-02-29 Thread Thomas Friedrichsmeier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/ --- (Updated Feb. 29, 2016, 9:49 a.m.) Review request for KDE Frameworks,

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

2016-02-27 Thread Thomas Friedrichsmeier
> On Feb. 26, 2016, 5:13 p.m., Dāvis Mosāns wrote: > > src/lib/activitiesmodel.h, line 96 > > > > > > Wouldn't it be better to use _MSC_VER <= 1800 /* MSVC2013 */ > > > > as maybe it works for MSVC2015?

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

2016-02-26 Thread Dāvis Mosāns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/#review92814 --- src/lib/activitiesmodel.h (line 96)

Review Request 127187: Fix build for MSVC (2013) on Windows

2016-02-26 Thread Thomas Friedrichsmeier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/ --- Review request for KDE Frameworks, kdewin and Ivan Čukić. Repository: