Re: [Kdenlive-devel] setting mlt property from qstring

2010-09-27 Thread Dan Dennedy
On Sun, Sep 26, 2010 at 3:01 PM, Till Theato wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/31/2010 09:56 PM, Dan Dennedy wrote: >> When working on my latest change, I noticed the Kdenlive code was >> often using qstrdup with QString::toUtf8().data(). The qstrdup is not >> nece

Re: [Kdenlive-devel] setting mlt property from qstring

2010-09-26 Thread Till Theato
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/31/2010 09:56 PM, Dan Dennedy wrote: > When working on my latest change, I noticed the Kdenlive code was > often using qstrdup with QString::toUtf8().data(). The qstrdup is not > necessary because MLT already does a strdup with whatever you provi

[Kdenlive-devel] setting mlt property from qstring

2010-08-31 Thread Dan Dennedy
When working on my latest change, I noticed the Kdenlive code was often using qstrdup with QString::toUtf8().data(). The qstrdup is not necessary because MLT already does a strdup with whatever you provide and then auto-releases it. I did not clean all of these up because I wanted to keep the chang