[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply
https://bugs.kde.org/show_bug.cgi?id=368060 --- Comment #13 from Simon Levitt <kde-b...@whattf.com> --- Is my 'hack', really the correct fix? Why are AttachmentMessagePart objects deemed textual?, that seems wrong to me. -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 369245] KMail 5.3.1: Attachments are included as plain text in forwarded or replied mails
https://bugs.kde.org/show_bug.cgi?id=369245 Simon Levitt <kde-b...@whattf.com> changed: What|Removed |Added CC||kde-b...@whattf.com --- Comment #1 from Simon Levitt <kde-b...@whattf.com> --- Think this might be related to what causes the issue https://bugs.kde.org/show_bug.cgi?id=368060. In looking into that I discovered that the attachment object (in the code) extends a text part (which is why is was being used for the quote text), that could well be why a textual MIME type is being chosen here also. -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 368692] kMail 5.3.x: Wrong MIME part selected as Reply text
https://bugs.kde.org/show_bug.cgi?id=368692 Simon Levitt <kde-b...@whattf.com> changed: What|Removed |Added CC||kde-b...@whattf.com --- Comment #8 from Simon Levitt <kde-b...@whattf.com> --- This is the same problem as https://bugs.kde.org/show_bug.cgi?id=368060. I've put a code hacky fix for this on that ticket. -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply
https://bugs.kde.org/show_bug.cgi?id=368060 --- Comment #8 from Simon Levitt <kde-b...@whattf.com> --- Created attachment 101783 --> https://bugs.kde.org/attachment.cgi?id=101783=edit Code hack After some more digging around, I discovered that toplevelTextNode() in utils.cpp is returning non-text parts. That is because AttachmentMessagePart extends TextMessagePart, and therefore it's been deeming images/etc. as textual. The attached patch hacks a quick fix to not return an AttachmentMessagePart which seems to work around the problem and makes replies work as expected for me. -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply
https://bugs.kde.org/show_bug.cgi?id=368060 Simon Levitt <kde-b...@whattf.com> changed: What|Removed |Added CC||kde-b...@whattf.com --- Comment #7 from Simon Levitt <kde-b...@whattf.com> --- Created attachment 101760 --> https://bugs.kde.org/attachment.cgi?id=101760=edit Example mbox showing problem. I'm also seeing this, specifically for HTML only emails (ie. no text/plain part in the mail) with embedded images. The attached file is a simple email that shows the problem with a multipart/related - On hitting reply the quoted text is 'Image1' which is the data for the first attached image, not the expected 'HTML Text'. -- You are receiving this mail because: You are the assignee for the bug.
