[kleopatra] [Bug 411849] RSA4096 option disabled in Kleopatra on newer smartcards

2019-09-12 Thread Andre Heinecke
https://bugs.kde.org/show_bug.cgi?id=411849

--- Comment #6 from Andre Heinecke  ---
Your bug report was great. Even a bit too detailed like "not tested on MacOS"
and you pointed out a shameful piece of "quick hack". And you had the luck that
I was working on Kleo today anyway.


Regarding the addition: If it is in the spec GnuPG will support it. I'll make
sure of it because I really need something like that. E.g. we want to add
Brainpool to GnuK but how could I determine in the GUI if I could offer that?!

It's even so bad in the card edit interface of GnuPG. It offers all the options
but if you have a card that does not support it you get strange errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[kleopatra] [Bug 411849] RSA4096 option disabled in Kleopatra on newer smartcards

2019-09-12 Thread Trevor B
https://bugs.kde.org/show_bug.cgi?id=411849

--- Comment #5 from Trevor B  ---
Thanks for the super-fast fix!  I'll contact you via e-mail about getting keys.

There is a new DO in version 3.4 of the spec, called "Algorithm Information",
which returns a table of supported algorithms.  That would be the most correct
way to determine what is supported.  But I think it still needs to be plumbed
through GPG, and most devices probably don't support it yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[kleopatra] [Bug 411849] RSA4096 option disabled in Kleopatra on newer smartcards

2019-09-12 Thread Andre Heinecke
https://bugs.kde.org/show_bug.cgi?id=411849

--- Comment #4 from Andre Heinecke  ---
This was a classical case of a todo that lived too long.

The idea behind this was "I have to talk to Werner and Gniibe how we can detect
the capabilities" and in the meantime I do this.

Then we talked about it. Did not reach a conclusion and the code was left.

Btw. As GnuPG master and stable now support generating OpenPGP pubkeys for
S/MIME Smartcards I have to rework the card widgets a bit. In this process I'll
also add some basic ECC support but that will also only check for the version
>.<

I have not tested my commit fully. I only added temporary debug code like "Is
3.0 larger then 2.1" true. To check the basic functionality of the version
parsing. The version parsing code is also old and just refactored now. So it
should be fine.

Btw. Could you also send me a Yubikey for testing? I know Werner got some but
it would help me, too to have one for testing. I only have a 2.0 Test smartcard
all  my others are in productive use. If yes please send a quick mail to
aheine...@gnupg.org asking for my address.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[kleopatra] [Bug 411849] RSA4096 option disabled in Kleopatra on newer smartcards

2019-09-12 Thread Andre Heinecke
https://bugs.kde.org/show_bug.cgi?id=411849

Andre Heinecke  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://commits.kde.org/kle
   ||opatra/d989c281a64dca7cd9f6
   ||ce1081e05f6b4e73f6ab
 Resolution|--- |FIXED

--- Comment #3 from Andre Heinecke  ---
Git commit d989c281a64dca7cd9f6ce1081e05f6b4e73f6ab by Andre Heinecke.
Committed on 12/09/2019 at 11:59.
Pushed by aheinecke into branch 'master'.

Fix version check for pgp cards

The check for card version 2.1 should have been only
temporary. Now it is a bit better by refactoring the
code in gnupg-helper for engine versions a bit so that
it generally works with string versions.

This is probably the millionth implementation of version
parsing but it works for me.

M  +62   -10   src/utils/gnupg-helper.cpp
M  +5-0src/utils/gnupg-helper.h
M  +3-1src/view/pgpcardwidget.cpp

https://commits.kde.org/kleopatra/d989c281a64dca7cd9f6ce1081e05f6b4e73f6ab

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[kleopatra] [Bug 411849] RSA4096 option disabled in Kleopatra on newer smartcards

2019-09-12 Thread Andre Heinecke
https://bugs.kde.org/show_bug.cgi?id=411849

--- Comment #2 from Andre Heinecke  ---
Yeah on it. Just a sec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[kleopatra] [Bug 411849] RSA4096 option disabled in Kleopatra on newer smartcards

2019-09-12 Thread Trevor B
https://bugs.kde.org/show_bug.cgi?id=411849

Trevor B  changed:

   What|Removed |Added

 CC||tre...@yubico.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[kleopatra] [Bug 411849] RSA4096 option disabled in Kleopatra on newer smartcards

2019-09-12 Thread Trevor B
https://bugs.kde.org/show_bug.cgi?id=411849

--- Comment #1 from Trevor B  ---
Whoops, I mean Kleopatra 3.1.8 as part of Gpg4win 3.1.10.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[kleopatra] [Bug 411849] RSA4096 option disabled in Kleopatra on newer smartcards

2019-09-12 Thread Trevor B
https://bugs.kde.org/show_bug.cgi?id=411849

Trevor B  changed:

   What|Removed |Added

Version|unspecified |3.1.8

-- 
You are receiving this mail because:
You are on the CC list for the bug.