[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Sandro Knauß]

https://bugs.kde.org/show_bug.cgi?id=368060

--- Comment #15 from Sandro Knauß  ---
The current class hierarchy has nothing to do with representation of a specific
 "mime"-type. And in this hierarchy AttachmentPart is a subclass of TextPart,
because AttachmentPart has every property of a TextPart.
That's why isTextPart is true for every attachment.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Till Schäfer]

https://bugs.kde.org/show_bug.cgi?id=368060

--- Comment #14 from Till Schäfer  ---
Hmm, it seems fine to not include text attachments either, but there seems to
something else broken, as a rar attachment (see Bug 369245) is definitely no
text.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Simon Levitt]

https://bugs.kde.org/show_bug.cgi?id=368060

--- Comment #13 from Simon Levitt  ---
Is my 'hack', really the correct fix?
Why are AttachmentMessagePart objects deemed textual?, that seems wrong to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Sandro Knauß]

https://bugs.kde.org/show_bug.cgi?id=368060

Sandro Knauß  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.3.4
  Latest Commit||http://commits.kde.org/mess
   ||agelib/bf247fc9e802a39b60c8
   ||828019401569f6ad99fa
 Status|CONFIRMED   |RESOLVED

--- Comment #12 from Sandro Knauß  ---
Git commit bf247fc9e802a39b60c8828019401569f6ad99fa by Sandro Knauß.
Committed on 26/10/2016 at 15:41.
Pushed by knauss into branch 'Applications/16.08'.

Fix: Attachments are included as plain text in replied mails

Thanks to Simon Levitt to point to the corrent part that needs to be
fixed.
FIXED-IN: 5.3.4

M  +2-1mimetreeparser/src/bodyformatter/utils.cpp

http://commits.kde.org/messagelib/bf247fc9e802a39b60c8828019401569f6ad99fa

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Sandro Knauß]

https://bugs.kde.org/show_bug.cgi?id=368060

Sandro Knauß  changed:

   What|Removed |Added

 CC||till2.schaefer@uni-dortmund
   ||.de

--- Comment #10 from Sandro Knauß  ---
*** Bug 369245 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Till Schäfer]

https://bugs.kde.org/show_bug.cgi?id=368060

Till Schäfer  changed:

   What|Removed |Added

Version|unspecified |5.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Sandro Knauß]

https://bugs.kde.org/show_bug.cgi?id=368060

Sandro Knauß  changed:

   What|Removed |Added

 CC||kdeb...@customcdrom.de

--- Comment #11 from Sandro Knauß  ---
*** Bug 368692 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Sandro Knauß]

https://bugs.kde.org/show_bug.cgi?id=368060

Sandro Knauß  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #9 from Sandro Knauß  ---
Can reproduce with 16.08

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Simon Levitt]

https://bugs.kde.org/show_bug.cgi?id=368060

--- Comment #8 from Simon Levitt  ---
Created attachment 101783
  --> https://bugs.kde.org/attachment.cgi?id=101783=edit
Code hack

After some more digging around, I discovered that toplevelTextNode() in
utils.cpp is returning non-text parts.

That is because AttachmentMessagePart extends TextMessagePart, and therefore
it's been deeming images/etc. as textual.

The attached patch hacks a quick fix to not return an AttachmentMessagePart
which seems to work around the problem and makes replies work as expected for
me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Laurent Montel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368060

Laurent Montel  changed:

   What|Removed |Added

 CC||mon...@kde.org,
   ||skna...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Simon Levitt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368060

Simon Levitt  changed:

   What|Removed |Added

 CC||kde-b...@whattf.com

--- Comment #7 from Simon Levitt  ---
Created attachment 101760
  --> https://bugs.kde.org/attachment.cgi?id=101760=edit
Example mbox showing problem.

I'm also seeing this, specifically for HTML only emails (ie. no text/plain part
in the mail) with embedded images.
The attached file is a simple email that shows the problem with a
multipart/related - On hitting reply the quoted text is 'Image1' which is the
data for the first attached image, not the expected 'HTML Text'.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Christian Saemann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368060

Christian Saemann  changed:

   What|Removed |Added

 CC||christian.saem...@gmx.de

--- Comment #6 from Christian Saemann  ---
Can confirm this bug with png attachments as well as the workaround from
comment 1, on Kmail 5.3.0, latest packages from opensuse Tumbleweed. This is a
rather annoying bug in everyday use of kmail. I'm happy to test/provide more
details if this is helpful. It seems that it doesn't recognize the mime type of
the attachment. It simply quotes the binary content of the attachment, and
produces many lines as e.g.:

> ÷$÷É_]±ÓN"2Î<ðDÀ?Âwr:½®*Tá©Äoù¶ü|_

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Johannes Studt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368060

Johannes Studt  changed:

   What|Removed |Added

 CC||johan...@studt.de

--- Comment #5 from Johannes Studt  ---
Can confirm this.

Kmail 16.08.1 on Opensuse Tumbleweed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Ian via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368060

Ian  changed:

   What|Removed |Added

 Resolution|LATER   |---
 Status|RESOLVED|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Stephan Diestelhorst via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368060

--- Comment #4 from Stephan Diestelhorst  ---
What I am saying is: please reopen; thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Stephan Diestelhorst via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368060

--- Comment #3 from Stephan Diestelhorst  ---
Erm... no?  This is still a bug and you closing your account does not make the
bug disappear.  I'll just rereport the same thing. :-S

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Ian via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368060

Ian  changed:

   What|Removed |Added

 Resolution|--- |LATER
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Ian  ---
closing account so closing bugs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 368060] Replying to html email that has a PDF attachment creates junk in the reply

[Stephan Diestelhorst via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368060

Stephan Diestelhorst  changed:

   What|Removed |Added

 CC||stephan.diestelhorst@gmail.
   ||com

--- Comment #1 from Stephan Diestelhorst  ---
Got the same with a PNG attached.  Current workaround: mark the text you are
replying to and then reply -> will only copy out the text of the reply.

-- 
You are receiving this mail because:
You are the assignee for the bug.