[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 Sandro Knauß changed: What|Removed |Added CC||stefandoesin...@gmx.at --- Comment #11 from Sandro Knauß --- *** Bug 432040 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 Sandro Knauß changed: What|Removed |Added Latest Commit|https://invent.kde.org/pim/ |https://invent.kde.org/pim/ |messagelib/commit/3a7114399 |messagelib/commit/c57eb4d95 |b105cbe159355f600b9d3e08ec1 |e67c8b28305c1c0c9e29179530f |0fcb|cd1d --- Comment #10 from Sandro Knauß --- Git commit c57eb4d95e67c8b28305c1c0c9e29179530fcd1d by Sandro Knauß. Committed on 01/02/2021 at 19:19. Pushed by knauss into branch 'release/20.08'. Fix[messagecomposer]: Do copy all mail headers instad of reference them. When dealing with encryption and protected headers it is enough to reference the headers in the messagepart, as the result is encrypted directly. This is different for Sign only and there may be jobs after signing that are changing the mail headers, so we need to copy all headers into the encapsulated part instead of referencing them. FIXED-IN: 5.16.1 M +55 -0messagecomposer/autotests/signjobtest.cpp M +2-0messagecomposer/autotests/signjobtest.h M +5-6messagecomposer/src/job/protectedheaders.cpp https://invent.kde.org/pim/messagelib/commit/c57eb4d95e67c8b28305c1c0c9e29179530fcd1d -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 Sandro Knauß changed: What|Removed |Added Latest Commit||https://invent.kde.org/pim/ ||messagelib/commit/3a7114399 ||b105cbe159355f600b9d3e08ec1 ||0fcb Status|CONFIRMED |RESOLVED Version Fixed In||5.16.1 Resolution|--- |FIXED --- Comment #9 from Sandro Knauß --- Git commit 3a7114399b105cbe159355f600b9d3e08ec10fcb by Sandro Knauß. Committed on 05/01/2021 at 17:50. Pushed by knauss into branch 'release/20.12'. Fix[messagecomposer]: Do copy all mail headers instad of reference them. When dealing with encryption and protected headers it is enough to reference the headers in the messagepart, as the result is encrypted directly. This is different for Sign only and there may be jobs after signing that are changing the mail headers, so we need to copy all headers into the encapsulated part instead of referencing them. FIXED-IN: 5.16.1 M +55 -0messagecomposer/autotests/signjobtest.cpp M +2-0messagecomposer/autotests/signjobtest.h M +5-6messagecomposer/src/job/protectedheadersjob.cpp https://invent.kde.org/pim/messagelib/commit/3a7114399b105cbe159355f600b9d3e08ec10fcb -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 Sandro Knauß changed: What|Removed |Added Status|ASSIGNED|CONFIRMED --- Comment #8 from Sandro Knauß --- (In reply to Ingo Klöcker from comment #6) > By the way, it seems that encrypted+signed messages are not affected by this > problem. On the other hand, looking at the decrypted MIME tree of such a > message it makes me wonder whether protected headers is actually correctly > implemented for encrypted+signed messages. To me it seems as if the > "protected headers" are not part of the signed message part but of the > enclosing multipart/signed message part which means that they are not really > protected by the signature. Ironically, this implementation bug prevents the > signatures of encrypted+signed messages to be broken by the protected > headers feature. It is correct, that the "protected headers" are not signed with encrypted+signed. As it does not use SingEncryptJob but assembles the mail by hand in composerjob, but this is a different issue. But anyways as the content is encrypted there is only a binary blob, that cannot been modified afterwards and this prevents any external modification and a valid signature. The ProtectedHeadersJob was only referencing all the headers, to save some memory and I thought, that the headers are finalized already. This assumption turns out to be wrong, so I copy now all headers see the merge request: https://invent.kde.org/pim/messagelib/-/merge_requests/21 -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/pim/messagelib/-/merge_requests/21 -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 --- Comment #6 from Ingo Klöcker --- By the way, it seems that encrypted+signed messages are not affected by this problem. On the other hand, looking at the decrypted MIME tree of such a message it makes me wonder whether protected headers is actually correctly implemented for encrypted+signed messages. To me it seems as if the "protected headers" are not part of the signed message part but of the enclosing multipart/signed message part which means that they are not really protected by the signature. Ironically, this implementation bug prevents the signatures of encrypted+signed messages to be broken by the protected headers feature. -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 Ingo Klöcker changed: What|Removed |Added Status|REPORTED|CONFIRMED CC||kloec...@kde.org Ever confirmed|0 |1 --- Comment #5 from Ingo Klöcker --- I'm experiencing the same problem because my name also contains a non-ASCII character. -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 Laurent Montel changed: What|Removed |Added CC||mon...@kde.org, ||skna...@kde.org -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 --- Comment #4 from Lukáš Turek <8...@8an.cz> --- Created attachment 133939 --> https://bugs.kde.org/attachment.cgi?id=133939=edit Disable protected headers in messagelib I found a workaround: when protected headers are disabled in messagelib, To: and From: headers don't affect the signature, so it validates OK. -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 Timo Weingärtner changed: What|Removed |Added CC||t...@tiwe.de --- Comment #3 from Timo Weingärtner --- In my config 8859-1 is not in the list, but kmail changes encondig to it anyways. -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 Lukáš Turek <8...@8an.cz> changed: What|Removed |Added CC||8...@8an.cz --- Comment #2 from Lukáš Turek <8...@8an.cz> --- I can confirm the bug, it's a regression after update from 20.04.3 to 20.08.3. -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 l.gae...@gmail.com changed: What|Removed |Added CC||l.gae...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 André M changed: What|Removed |Added CC||andre.vma...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[kmail2] [Bug 427091] Kmail gpg bad signature if From header contains non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=427091 --- Comment #1 from André M --- "To" field suffers of the same problem, making it very hard to write to contacts containing non-ascii characters in name (need to edit and normalize it before signing/sending mail). -- You are receiving this mail because: You are the assignee for the bug.
