Re: [OS-BUILD PATCHv3] mm/sparsemem: Fix 'mem_section' will never be NULL gcc 12 warning

2022-03-07 Thread Mark Salter (via Email Bridge)
From: Mark Salter on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1598#note_866037018 The "if (!*mem_section")" is causing a panic on aarch64 systems (CONFIG_SPARSEMEM_EXTREME=y) which have no memory in the first mem_section root. The original "if (!mem_section)" is the co

Re: [OS-BUILD PATCHv7 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_865862896 Good idea. I've added ``` The next line is throwaway code for transition to parallel processing. Leaving this line in place is harmless, but it can be removed the next time anyo

[OS-BUILD PATCHv7 6/9] redhat/configs/build_configs.sh: Create unique output files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Create unique output files Create unique output files from merge_configs(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs

[OS-BUILD PATCHv7 7/9] redhat/configs/build_configs.sh: Provide better messages

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/build_configs.sh +++

[OS-BUILD PATCHv7 8/9] redhat/configs/build_configs.sh: Parallelize execution

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Parallelize execution Parallelize the execution of each config building. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit Bhargava d

[OS-BUILD PATCHv7 9/9] redhat/configs/process_configs.sh: Fix issue with old error files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Fix issue with old error files Previous to this changeset, running process_configs.sh would result in an .mismatches file being left after execution. If someone has done make dist-configs \# update to latest make -j10 dist-configs the '

[OS-BUILD PATCHv7 4/9] redhat/configs/process_configs.sh: Parallelize execution

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Parallelize execution Parallelize the execution of each config processing. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv7 5/9] redhat/configs/build_configs.sh: Add local variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Add local variables Add local variables to the merge_configs function. This will make future changes for parallel processing easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_confi

[OS-BUILD PATCHv7 3/9] redhat/configs/process_configs.sh: Provide better messages

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/process_confi

[OS-BUILD PATCHv7 1/9] redhat/configs/process_configs.sh: Add processing config function

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Add processing config function Move the code to process a config into its own function. This will make future changes easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_confi

[OS-BUILD PATCHv7 2/9] redhat/configs/process_configs.sh: Create unique output files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Create unique output files Create unique output files from process_config(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 --- a/redhat

[OS-BUILD PATCHv7 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635 The dist-configs target takes an annoying long time. Add parallel processing of configs in dist-configs. Testing Info make dist-configs time 1m22.909s ma

Re: [OS-BUILD PATCHv6 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_865827704 Or at least add a fat blurb that those new lines are throwaway code to transition to the parallel workflow. I just don't want that code lying around and then a year later someone reads th

Re: [OS-BUILD PATCHv6 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_865816812 Ok. That wasn't obvious. So the correct way to fix it, is bring in your last patch now as a standalone MR. Then this MR will remove/replace with new removal code, right?

Re: [OS-BUILD PATCHv6 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638#note_865814597 Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedor

[OS-BUILD PATCHv6 2/2] redhat: Unify genspec.sh and kernel.spec variable names

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Unify genspec.sh and kernel.spec variable names Use common variable names between genspec.sh and kernel.spec. Signed-off-by: Prarit Bhargava diff --git a/redhat/genspec.sh b/redhat/genspec.sh index blahblah..blahblah 100755 --- a/redhat/genspec.sh +++ b/redhat/ge

[OS-BUILD PATCHv6 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638 genspec.sh has _22_ parameters that must be specified on the command line which are generated by the Makefile. Instead of passing these parameters on the command line, export them di

[OS-BUILD PATCHv6 1/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Remove options and use Makefile variables genspec.sh has 22 parameters that must be specified on the command line which are generated by the Makefile. Instead of passing these parameters on the command line, export them directly from the Makefile. Remov

Re: [OS-BUILD PATCHv6 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_865801544 It's hard to explain. The *ONLY* reason for the last commit is to avoid the issue @jmflinuxtx hit because he executed both the old code and the new code in the same tree. If you do

Re: [OS-BUILD PATCHv5 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638#note_865715465 could you also update the changelog of the first patch in the series? ___ kernel mailing list -- kernel@lists.fedoraproject.org To uns

Re: [OS-BUILD PATCHv6 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_865713661 Hmm. If you go 15 lines down it does the same thing but returns an error code. Is that code redundant now or is there an error code to be tracked? ___

Re: [OS-BUILD PATCHv5 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638#note_865690949 I've updated the MR description. Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-l

Re: [OS-BUILD PATCHv5 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638#note_865678257 yes looks good to me now. The changelogs still mention though dist-dump- variables, but you are not using it instead the result of export (the other open thread), but this one is

[OS-BUILD PATCHv5 2/2] redhat: Unify genspec.sh and kernel.spec variable names

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Unify genspec.sh and kernel.spec variable names Use common variable names between genspec.sh and kernel.spec. Signed-off-by: Prarit Bhargava diff --git a/redhat/genspec.sh b/redhat/genspec.sh index blahblah..blahblah 100755 --- a/redhat/genspec.sh +++ b/redhat/ge

[OS-BUILD PATCHv5 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638 genspec.sh has _22_ parameters that must be specified on the command line which are generated by the Makefile. These parameters can be set in the script by using the output of the di

[OS-BUILD PATCHv5 1/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Remove options and use Makefile variables genspec.sh has _22_ parameters that must be specified on the command line which are generated by the Makefile. These parameters can be set in the script by using the output of the dist-dump-variables target which

Re: [OS-BUILD PATCHv4 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638#note_865630233 Actually, just a -f "$SOURCES/$SPECFILE" will work here. If something is wrong we'll know it ;) ___ kernel mailing list -- kernel@lists.fe

Re: [OS-BUILD PATCHv4 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638#note_865625524 Yes, but the test itself needs to change to not only check for NULL but also check if the file exists. I will make that change now. ___ ke

[OS-BUILD PATCHv6 6/9] redhat/configs/build_configs.sh: Create unique output files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Create unique output files Create unique output files from merge_configs(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs

[OS-BUILD PATCHv6 9/9] redhat/configs/process_configs.sh: Fix issue with old error files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Fix issue with old error files Previous to this changeset, running process_configs.sh would result in an .mismatches file being left after execution. If someone has done make dist-configs \# update to latest make -j10 dist-configs the '

[OS-BUILD PATCHv6 8/9] redhat/configs/build_configs.sh: Parallelize execution

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Parallelize execution Parallelize the execution of each config building. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit Bhargava d

[OS-BUILD PATCHv6 7/9] redhat/configs/build_configs.sh: Provide better messages

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/build_configs.sh +++

[OS-BUILD PATCHv6 4/9] redhat/configs/process_configs.sh: Parallelize execution

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Parallelize execution Parallelize the execution of each config processing. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv6 5/9] redhat/configs/build_configs.sh: Add local variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Add local variables Add local variables to the merge_configs function. This will make future changes for parallel processing easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_confi

[OS-BUILD PATCHv6 3/9] redhat/configs/process_configs.sh: Provide better messages

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/process_confi

[OS-BUILD PATCHv6 2/9] redhat/configs/process_configs.sh: Create unique output files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Create unique output files Create unique output files from process_config(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 --- a/redhat

[OS-BUILD PATCHv6 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635 The dist-configs target takes an annoying long time. Add parallel processing of configs in dist-configs. Testing Info make dist-configs time 1m22.909s ma

[OS-BUILD PATCHv6 1/9] redhat/configs/process_configs.sh: Add processing config function

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Add processing config function Move the code to process a config into its own function. This will make future changes easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_confi

Re: [OS-BUILD PATCHv5 0/8] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_865619782 I should add you can test this by doing: touch .mismatches make -j20 dist-configs This will return an error. In any case, pushed one additional patch to fix this situation. ___

Re: [OS-BUILD PATCHv5 0/8] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_865610680 >Actually, weirder, 'make dist-configs-check' works fine in ark-latest, but 'make dist-git' fails as above. If I do a 'make dist-srpm', that succeeds, and afterwards 'make dist-git'