From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
⢠Makefile:
Create new dist-dump-variables target for dynamically deriving variables
from Makefile.common and dumping them.
Create new dist-clean-scripts target to clean up generated scripts.
Create new dist-self-test target and hook up the BATS
self tests.
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
⢠Makefile:
Create new dist-dump-variables target for dynamically deriving variables
from Makefile.common and dumping them.
Create new dist-clean-scripts target to clean up generated scripts.
Create new dist-self-test target and hook up the BATS
self tests.
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: Ben Crocker
⢠Makefile:
Create new dist-dump-variables target for dynamically deriving variables
from Makefile.common and dumping them.
Create new dist-clean-scripts target to clean up generated scripts.
Create new dist-self-test target and hook up the BATS
self tests.
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
⢠Makefile:
Create new dist-dump-variables target for dynamically deriving variables
from Makefile.common and dumping them.
Create new dist-clean-scripts target to clean up generated scripts.
Create new dist-self-test target and hook up the BATS
self tests.
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
⢠Makefile:
Create new dist-dump-variables target for dynamically deriving variables
from Makefile.common and dumping them.
Create new dist-clean-scripts target to clean up generated scripts.
Create new dist-self-test target and hook up the BATS
self tests.
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
⢠Makefile:
Create new dist-dump-variables target for dynamically deriving variables
from Makefile.common and dumping them.
Create new dist-clean-scripts target to clean up generated scripts.
Create new dist-self-test target and hook up the BATS
self tests.
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
⢠Makefile:
Create new dist-dump-variables target for dynamically deriving variables
from Makefile.common and dumping them.
Create new dist-clean-scripts target to clean up generated scripts.
Create new dist-self-test target and hook up the BATS
self tests.
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
⢠Makefile:
Create new dist-self-test target and hook up the BATS
self tests. Check for the presence of /usr/bin/bats
(via 'test -x') and complain if it is not installed.
⢠Makefile.common: make HEAD an overridable variable.
Change
GITID:= $(shell $(GIT) log
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: Ben Crocker
⢠Makefile:
Create new dist-self-test target and hook up the BATS
self tests. Check for the presence of /usr/bin/bats
(via 'test -x') and complain if it is not installed.
⢠Makefile.common: make HEAD an overridable variable.
Change
GITID:= $(shell $(GIT) log
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: Ben Crocker
⢠Makefile:
Create new dist-self-test target and hook up the BATS
self tests. Check for the presence of /usr/bin/bats
(via 'test -x') and complain if it is not installed.
⢠Makefile.common: make HEAD an overridable variable.
Change
GITID:= $(shell $(GIT) log
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
⢠Makefile:
Create new dist-self-test target and hook up the BATS
self tests. Check for the presence of /usr/bin/bats
(via 'test -x') and complain if it is not installed.
⢠Makefile.common: make HEAD an overridable variable.
Change
GITID:= $(shell $(GIT) log
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
Changes actually consist of disabling shellcheck on a few lines:
⢠SC2086: Double quote to prevent globbing and word splitting.
⢠SC2059: Don't use variables in the printf format string. Use printf...
For the former, in the two gitlab commands involved,
GITLAB_CONFIG_OPT
From: Ben Crocker
SC2001: See if you can use ${variable//search/replace} instead.
SC2046: Quote this to prevent word splitting.
SC2086: Double quote to prevent globbing and word splitting.
SC2162: read without -r will mangle backslashes.
SC2181: Check exit code directly with e.g. 'if mycmd;',
From: Ben Crocker
SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
SC2086: Double quote to prevent globbing and word splitting.
SC2196: egrep is non-standard and deprecated. Use grep -E instead.
SC2034: appears unused.
Change to #!/bin/bash explicitly to allow
From: Ben Crocker
SC2162: read without -r will mangle backslashes
SC2086: Double quote to prevent globbing and word splitting
Rewrote main loop so it will work.
Signed-off-by: Ben Crocker
merge-subtrees.h: fix
Signed-off-by: Ben Crocker
---
redhat/scripts/merge-subtrees.sh | 6 +++---
1
From: Ben Crocker
Fix syntax flagged by shellcheck:
SC2086: Double quote to prevent globbing and word splitting.
(There is only one instance.)
Signed-off-by: Ben Crocker
---
redhat/scripts/ci/ark-create-release.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Ben Crocker
SC2086: Double quote to prevent globbing and word splitting.
SC2145: Argument mixes string and array. Use * or separate argument.
SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Signed-off-by: Ben Crocker
---
redhat/scripts/rh-dist-git.sh | 33
From: Ben Crocker
SC2039: bash-isms
SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
Signed-off-by: Ben Crocker
---
redhat/scripts/x86_rngd.sh | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/redhat/scripts/x86_rngd.sh
From: Ben Crocker
SC2231: Quote expansions in this for loop glob to prevent wordsplitting.
SC2086: Double quote to prevent globbing and word splitting.
Signed-off-by: Ben Crocker
---
redhat/update_scripts.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Ben Crocker
SC2086: Double quote to prevent globbing and word splitting.
Signed-off-by: Ben Crocker
---
redhat/parallel_xz.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/parallel_xz.sh b/redhat/parallel_xz.sh
index bc08a548dbee..f1b6cdd1594d 100755
---
From: Ben Crocker
SC2034: tree appears unused. Verify use (or export if used externally).
SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.
SC2086: Double quote to prevent globbing and word splitting.
Signed-off-by: Ben Crocker
---
redhat/scripts/expand_srpm.sh | 7
From: Ben Crocker
SC2006: Use $(...) notation instead of legacy backticked `...`.
SC1083: This { is literal. Check expression (missing ;/\n?) or quote it.
SC2086: Double quote to prevent globbing and word splitting.
BUT:
Disable shellcheck on last step:
On the last step, we DEPEND on word
From: Ben Crocker
SC2007: Use $((..)) instead of deprecated $[..]
SC2086: Double quote to prevent globbing and word splitting.
SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
EVEN BETTER: use [[ p || q ]].
Signed-off-by: Ben Crocker
---
redhat/scripts/new_release.sh | 30
From: Ben Crocker
SC2068: Double quote array expansions to avoid re-splitting elements.
SC2086: Double quote to prevent globbing and word splitting.
SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
Signed-off-by: Ben Crocker
---
redhat/scripts/download_cross.sh
From: Ben Crocker
SC2006: Use $(...) notation instead of legacy backticked `...`.
SC2013: To read lines rather than words, pipe/redirect to a 'while read' loop.
SC2086: Double quote to prevent globbing and word splitting.
SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
EVEN
From: Ben Crocker
SC2086: Double quote to prevent globbing and word splitting.
Ignoring:
SC1091: Not following: /etc/os-release was not specified as input (see
shellcheck -x).
SC2154: bootprefix is referenced but not assigned.
It is perfectly OK for bootprefix not to be assigned in this
From: Ben Crocker
SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
SC2086: Double quote to prevent globbing and word splitting.
Signed-off-by: Ben Crocker
---
redhat/scripts/create_distgit_changelog.sh | 22 ++
1 file changed, 10 insertions(+),
From: Ben Crocker
SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
SC2006: Use $(...) notation instead of legacy backticked `...`.
SC2086: Double quote to prevent globbing and word splitting.
SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with
From: Ben Crocker
SC2039: In POSIX sh, == in place of = is undefined.
SC2086: Double quote to prevent globbing and word splitting.
Ignore:
SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Also, change 'if..elif..else..fi' block to case..esac.
Signed-off-by: Ben Crocker
From: Ben Crocker
SC2006: Use $(...) notation instead of legacy backticked `...`.
SC2013: To read lines rather than words, pipe/redirect to a 'while read' loop.
???
SC2086: Double quote to prevent globbing and word splitting.
SC2144: -f doesn't work with globs. Use a for loop.
SC2155: Declare
From: bcrocker on gitlab.com
Fix syntax flagged by shellcheck in all scripts in the redhat/ subtree.
A complete 'git log -p' of all commits on this branch can be found at:
http://pastebin.test.redhat.com/917268
SC2001: See if you can use ${variable//search/replace} instead.\
SC2002: Useless
From: Ben Crocker
SC2001: See if you can use ${variable//search/replace} instead.
SC2045: Iterating over ls output is fragile. Use globs.
SC2046: Quote this (command) to prevent word splitting.
SC2086: Double quote to prevent globbing and word splitting.
SC2162: read without -r will mangle
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
⢠Makefile:
Create new dist-self-test target and hook up the BATS
self tests. Check for the presence of /usr/bin/bats
(via 'test -x') and complain if it is not installed.
⢠Makefile.common: make HEAD an overridable variable.
Change
GITID:= $(shell $(GIT) log
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
1003-rpminspect.bats: initial commit.
Like the 1001-rpmlint.bats test, this test
⢠tests for exactly one SRPM
⢠runs rpminspect (instead of rpmlint) on that SRPM,
after checking for the presence of the /usr/bin/rpminspect.
Both 1001-rpmlint.bats and 1003-rpminspect.bats
From: Ben Crocker
This is a sample script providing a thin layer over the git command.
It is meant to substitute in redhat/Makefile and Makefile.common via the
GIT macro defined in Makefile.
Each git subcommand currently used by Makefile and Makefile.common can
be broken out into its own case.
From: Ben Crocker
Check via 'test -x' whether /usr/bin/shellcheck is present; if not,
skip the test and print a message.
Signed-off-by: Ben Crocker
---
redhat/self-test/0001-shellcheck.bats | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
From: Ben Crocker
⢠Makefile:
Create new dist-self-test target and hook up the BATS
self tests. Check for the presence of /usr/bin/bats
(via 'test -x') and complain if it is not installed.
⢠Makefile.common: make HEAD an overridable variable.
Change
GITID:= $(shell $(GIT) log
From: Ben Crocker
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).
This change enables us to override 'git' with, e.g., some
arbitrary shell script that prints additional information
and/or does additional processing before and/or after (or
even instead of) invoking
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\
in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does
From: Ben Crocker
Changes actually consist of disabling shellcheck on a few lines:
⢠SC2086: Double quote to prevent globbing and word splitting.
⢠SC2059: Don't use variables in the printf format string. Use printf...
For the former, in the two gitlab commands involved,
GITLAB_CONFIG_OPT
From: Ben Crocker
SC2001: See if you can use ${variable//search/replace} instead.
SC2046: Quote this to prevent word splitting.
SC2086: Double quote to prevent globbing and word splitting.
SC2162: read without -r will mangle backslashes.
SC2181: Check exit code directly with e.g. 'if mycmd;',
From: Ben Crocker
SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
SC2086: Double quote to prevent globbing and word splitting.
SC2196: egrep is non-standard and deprecated. Use grep -E instead.
Change to #!/bin/bash explicitly to allow
SC2039: bash-isms
From: Ben Crocker
Fix syntax flagged by shellcheck:
SC2086: Double quote to prevent globbing and word splitting.
(There is only one instance.)
Signed-off-by: Ben Crocker
---
redhat/scripts/ci/ark-create-release.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Ben Crocker
SC2006: Use $(...) notation instead of legacy backticked `...`.
SC1083: This { is literal. Check expression (missing ;/\n?) or quote it.
SC2086: Double quote to prevent globbing and word splitting.
BUT:
Disable shellcheck on last step:
On the last step, we DEPEND on word
From: Ben Crocker
SC2034: tree appears unused. Verify use (or export if used externally).
SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.
SC2086: Double quote to prevent globbing and word splitting.
Signed-off-by: Ben Crocker
---
redhat/scripts/expand_srpm.sh | 7
From: Ben Crocker
SC2086: Double quote to prevent globbing and word splitting.
SC2145: Argument mixes string and array. Use * or separate argument.
SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Signed-off-by: Ben Crocker
---
redhat/scripts/rh-dist-git.sh | 33
From: Ben Crocker
SC2086: Double quote to prevent globbing and word splitting.
Signed-off-by: Ben Crocker
---
redhat/parallel_xz.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/parallel_xz.sh b/redhat/parallel_xz.sh
index bc08a548dbee..f1b6cdd1594d 100755
---
From: Ben Crocker
SC2231: Quote expansions in this for loop glob to prevent wordsplitting.
SC2086: Double quote to prevent globbing and word splitting.
Signed-off-by: Ben Crocker
---
redhat/update_scripts.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Ben Crocker
SC2006: Use $(...) notation instead of legacy backticked `...`.
SC2013: To read lines rather than words, pipe/redirect to a 'while read' loop.
SC2086: Double quote to prevent globbing and word splitting.
SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
From: Ben Crocker
SC2162: read without -r will mangle backslashes
Globally disable:
SC2086 (Double quote to prevent globbing and word splitting)
WARNING: I don't think this script ever would have worked, before
or after shellcheck-suggested changes; I think the logic should be:
for entry in
From: Ben Crocker
SC2039: bash-isms
SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
Signed-off-by: Ben Crocker
---
redhat/scripts/x86_rngd.sh | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/redhat/scripts/x86_rngd.sh
From: Ben Crocker
SC2039: In POSIX sh, == in place of = is undefined.
SC2086: Double quote to prevent globbing and word splitting.
Ignore:
SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Also, change 'if..elif..else..fi' block to case..esac.
Signed-off-by: Ben Crocker
1 - 100 of 198 matches
Mail list logo
