From: Prarit Bhargava
redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED
Change DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED so that readers
understand it is passed into the spec file.
Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED.
Signed-off-by: Prarit
From: Prarit Bhargava
redhat/Makefile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION
Change RPMKEXTRAVERSION to SPECEXTRAVERSION so that readers understand it is
passed
into the spec file.
Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat
From: Prarit Bhargava
redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG
Change PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG so that readers
understand it is passed into the spec file.
Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG.
Signed-off-by: Prarit Bhargava
From: Prarit Bhargava
redhat/Makefile: Rename PKGRELEASE to SPECBUILD
PKGRELEASE is a confusing variable name, and it really is the BUILD string
for the specfile.
Rename PKGRELEASE to SPECBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah
From: Prarit Bhargava
redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG
Change CHANGELOG to SPECCHANGELOG so that readers understand it is passed
into the spec file. While the CHANGELOG does have use other than in the
spec file it is useful to know that the string is used in the spec file
From: Prarit Bhargava
redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID
Change BUILDID_DEFINE to SPECBUILDID so that readers understand it is passed
into the spec file.
Rename BUILDID_DEFINE to SPECBUILDID.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
From: Prarit Bhargava
redhat/Makefile: Rename KVERSION to SPECVERSION
KVERSION is passed into the spec file and is easy to confuse with the
kernel KVERSION. Change the name to SPECVERSION so that readers
understand it is the %Version field of the specfile.
As a result RPMKSUBLEVEL can
From: Prarit Bhargava
redhat/Makefile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL
Change RPMKSUBLEVEL to SPECSUBLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKSUBLEVEL to SPECKSUBLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
From: Prarit Bhargava
redhat/Makefile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL
Change RPMKPATCHLEVEL to SPECPATCHLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat
From: Prarit Bhargava
redhat/Makefile: Rename RPMKVERSION to SPECKVERSION
Change RPMKVERSION to SPECVERSION so that readers understand it is passed
into the spec file.
Rename RPMKVERSION to SPECKVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/Makefile: Use KVERSION
Use KVERSION where appropriate in the Makefile.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -144,6 +144,9 @@ else
MARKER
From: Prarit Bhargava
redhat/Makefile: Deprecate some simple targets
Deprecate some simple targets.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -420,15 +420,23 @@ $(KABIDW_TARBALL
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647
One of the common complaints about the redhat Makefiles, genspec.sh, and
kernel.spec.template
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_935080527
Y'know, you busted me on this last time too. I swear I was careful this
time and verified that the bodies all had "Makefile" instead of "Makfile".
I
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_935078977
Thanks, fixed.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_935078416
Thanks, fixed.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728#note_932324020
Updated due to merge conflict from Herton's CHANGELOG modifications.
Rebased on top of !1727.
___
kernel mailing list -- kernel
From: Prarit Bhargava
redhat/self-test: Add test to verify Makefile declarations.
The Makefiles have been organized such that only Makefile.variables
contain external variables that can be set on the command line, and
the Makefile only contains variables that can set within the Makefile
itself
From: Prarit Bhargava
redhat/self-test/data: Cleanup data
There have been some additional redhat/Makefile changes that modified
variables. Run 'make dist-self-test-data' to clean these changes up.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7
b
From: Prarit Bhargava
redhat/Makefile: Add RHTEST
For a long time we have wanted a mechanism by which we could do a 'test
run' of Makefile targets. Make has built-in options '-n, --just-print,
--dry-run, --recon' that can be added on the command line that allow users
to show the output
From: Prarit Bhargava
redhat: shellcheck cleanup
Some shellcheck cleanups.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
index blahblah..blahblah 100755
--- a/redhat/genspec.sh
+++ b/redhat/genspec.sh
@@ -114,7 +114,7 @@ cdate="$(LC_ALL=C date +&quo
From: Prarit Bhargava
redhat/self-test: Add test to verify SPEC variables
This test looks at the spec file variable replacement code in
redhat/genspec.sh and confirms that each variable begins with "SPEC".
Signed-off-by: Prarit Bhargava
diff --git a/redhat/docs/makefile-changes.rs
From: Prarit Bhargava
redhat/Makefile: Add 'duplicate' SPEC entries for user set variables
INCLUDE_FEDORA_FILES, INCLUDE_RHEL_FILES, and RELEASED_KERNEL are
specified in Makefile.variables as they can be set in userspace.
Create duplicate entries for these variables that begin with SPEC
From: Prarit Bhargava
redhat/Makefile: Rename TARFILE_RELEASE to SPECTARFILE_RELEASE
Change TARFILE_RELEASE to SPECTARFILE_RELEASE so that readers
understand it is passed into the spec file.
Rename TARFILE_RELEASE to SPECTARFILE_RELEASE.
Signed-off-by: Prarit Bhargava
diff --git a/redhat
From: Prarit Bhargava
redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG
Change PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG so that readers
understand it is passed into the spec file.
Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG.
Signed-off-by: Prarit Bhargava
From: Prarit Bhargava
redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED
Change DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED so that readers
understand it is passed into the spec file.
Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED.
Signed-off-by: Prarit
From: Prarit Bhargava
redhat/Makefile: Rename PKGRELEASE to SPECBUILD
PKGRELEASE is a confusing variable name, and it really is the BUILD string
for the specfile.
Rename PKGRELEASE to SPECBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah
From: Prarit Bhargava
redhat/Makfile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL
Change RPMKPATCHLEVEL to SPECPATCHLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat
From: Prarit Bhargava
redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG
Change CHANGELOG to SPECCHANGELOG so that readers understand it is passed
into the spec file. While the CHANGELOG does have use other than in the
spec file it is useful to know that the string is used in the spec file
From: Prarit Bhargava
redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID
Change BUILDID_DEFINE to SPECBUILDID so that readers understand it is passed
into the spec file.
Rename BUILDID_DEFINE to SPECBUILDID.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
From: Prarit Bhargava
redhat/Makfile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION
Change RPMKEXTRAVERSION to SPECEXTRAVERSION so that readers understand it is
passed
into the spec file.
Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727
Add a test to verify Makefile declarations, and add the RHTEST variable.
The latter of these changes allows
From: Prarit Bhargava
redhat/Makefile: Rename RPMKVERSION to SPECKVERSION
Change RPMKVERSION to SPECVERSION so that readers understand it is passed
into the spec file.
Rename RPMKVERSION to SPECKVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/Makefile: Rename KVERSION to SPECVERSION
KVERSION is passed into the spec file and is easy to confuse with the
kernel KVERSION. Change the name to SPECVERSION so that readers
understand it is the %Version field of the specfile.
As a result RPMKSUBLEVEL can
From: Prarit Bhargava
redhat/Makfile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL
Change RPMKSUBLEVEL to SPECSUBLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKSUBLEVEL to SPECKSUBLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
From: Prarit Bhargava
redhat/Makefile: Deprecate some simple targets
Deprecate some simple targets.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -420,15 +420,23 @@ $(KABIDW_TARBALL
From: Prarit Bhargava
redhat/Makefile: Use KVERSION
Use KVERSION where appropriate in the Makefile.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -144,6 +144,9 @@ else
MARKER
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_932320137
MR commits updated due to merge conflict. I had to rework the code for
Herton's CHANGELOG modifications, and added a cleanup commit for the tests
as well. Successfully tested
From: Prarit Bhargava
redhat/self-test/data: Cleanup data
There have been some additional redhat/Makefile changes that modified
variables. Run 'make dist-self-test-data' to clean these changes up.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7
b
From: Prarit Bhargava
redhat: shellcheck cleanup
Some shellcheck cleanups.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
index blahblah..blahblah 100755
--- a/redhat/genspec.sh
+++ b/redhat/genspec.sh
@@ -114,7 +114,7 @@ cdate="$(LC_ALL=C date +&quo
From: Prarit Bhargava
redhat/Makefile: Add 'duplicate' SPEC entries for user set variables
INCLUDE_FEDORA_FILES, INCLUDE_RHEL_FILES, and RELEASED_KERNEL are
specified in Makefile.variables as they can be set in userspace.
Create duplicate entries for these variables that begin with SPEC
From: Prarit Bhargava
redhat/self-test: Add test to verify SPEC variables
This test looks at the spec file variable replacement code in
redhat/genspec.sh and confirms that each variable begins with "SPEC".
Signed-off-by: Prarit Bhargava
diff --git a/redhat/docs/makefile-changes.rs
From: Prarit Bhargava
redhat/Makefile: Rename TARFILE_RELEASE to SPECTARFILE_RELEASE
Change TARFILE_RELEASE to SPECTARFILE_RELEASE so that readers
understand it is passed into the spec file.
Rename TARFILE_RELEASE to SPECTARFILE_RELEASE.
Signed-off-by: Prarit Bhargava
diff --git a/redhat
From: Prarit Bhargava
redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED
Change DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED so that readers
understand it is passed into the spec file.
Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED.
Signed-off-by: Prarit
From: Prarit Bhargava
redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG
Change PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG so that readers
understand it is passed into the spec file.
Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG.
Signed-off-by: Prarit Bhargava
From: Prarit Bhargava
redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG
Change CHANGELOG to SPECCHANGELOG so that readers understand it is passed
into the spec file. While the CHANGELOG does have use other than in the
spec file it is useful to know that the string is used in the spec file
From: Prarit Bhargava
redhat/Makefile: Rename PKGRELEASE to SPECBUILD
PKGRELEASE is a confusing variable name, and it really is the BUILD string
for the specfile.
Rename PKGRELEASE to SPECBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah
From: Prarit Bhargava
redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID
Change BUILDID_DEFINE to SPECBUILDID so that readers understand it is passed
into the spec file.
Rename BUILDID_DEFINE to SPECBUILDID.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
From: Prarit Bhargava
redhat/Makfile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION
Change RPMKEXTRAVERSION to SPECEXTRAVERSION so that readers understand it is
passed
into the spec file.
Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat
From: Prarit Bhargava
redhat/Makfile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL
Change RPMKPATCHLEVEL to SPECPATCHLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat
From: Prarit Bhargava
redhat/Makefile: Rename RPMKVERSION to SPECKVERSION
Change RPMKVERSION to SPECVERSION so that readers understand it is passed
into the spec file.
Rename RPMKVERSION to SPECKVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/Makfile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL
Change RPMKSUBLEVEL to SPECSUBLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKSUBLEVEL to SPECKSUBLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
From: Prarit Bhargava
redhat/Makefile: Rename KVERSION to SPECVERSION
KVERSION is passed into the spec file and is easy to confuse with the
kernel KVERSION. Change the name to SPECVERSION so that readers
understand it is the %Version field of the specfile.
As a result RPMKSUBLEVEL can
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647
One of the common complaints about the redhat Makefiles, genspec.sh, and
kernel.spec.template
From: Prarit Bhargava
redhat/Makefile: Use KVERSION
Use KVERSION where appropriate in the Makefile.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -144,6 +144,9 @@ else
MARKER
From: Prarit Bhargava
redhat/Makefile: Deprecate some simple targets
Deprecate some simple targets.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -420,15 +420,23 @@ $(KABIDW_TARBALL
From: Prarit Bhargava
redhat/Makefile: Add RHTEST
For a long time we have wanted a mechanism by which we could do a 'test
run' of Makefile targets. Make has built-in options '-n, --just-print,
--dry-run, --recon' that can be added on the command line that allow users
to show the output
From: Prarit Bhargava
redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED
Change DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED so that readers
understand it is passed into the spec file.
Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED.
Signed-off-by: Prarit
From: Prarit Bhargava
redhat/Makefile: Rename RPMKVERSION to SPECKVERSION
Change RPMKVERSION to SPECVERSION so that readers understand it is passed
into the spec file.
Rename RPMKVERSION to SPECKVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/Makefile: Rename KVERSION to SPECVERSION
KVERSION is passed into the spec file and is easy to confuse with the
kernel KVERSION. Change the name to SPECVERSION so that readers
understand it is the %Version field of the specfile.
As a result RPMKSUBLEVEL can
From: Prarit Bhargava
redhat/Makefile: Rename DISTRO_BUILD to SPECDISTROBUILD
Change DISTRO_BUILD to SPECDISTROBUILD so that readers understand it is passed
into the spec file.
Rename DISTRO_BUILD to SPECDISTROBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat
From: Prarit Bhargava
redhat/self-test: Add test to verify Makefile declarations.
The Makefiles have been organized such that only Makefile.variables
contain external variables that can be set on the command line, and
the Makefile only contains variables that can set within the Makefile
itself
From: Prarit Bhargava
redhat/Makfile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL
Change RPMKSUBLEVEL to SPECSUBLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKSUBLEVEL to SPECKSUBLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
On 4/22/22 12:38, Prarit Bhargava (via Email Bridge) wrote:
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727
Damn Email Bridge. I really thought Depends
From: Prarit Bhargava
redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID
Change BUILDID_DEFINE to SPECBUILDID so that readers understand it is passed
into the spec file.
Rename BUILDID_DEFINE to SPECBUILDID.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
From: Prarit Bhargava
redhat/Makefile: Add 'duplicate' SPEC entries for user set variables
INCLUDE_FEDORA_FILES, INCLUDE_RHEL_FILES, and RELEASED_KERNEL are
specified in Makefile.variables as they can be set in userspace.
Create duplicate entries for these variables that begin with SPEC
From: Prarit Bhargava
redhat/Makefile: Rename PKGRELEASE to SPECBUILD
PKGRELEASE is a confusing variable name, and it really is the BUILD string
for the specfile.
Rename PKGRELEASE to SPECBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah
From: Prarit Bhargava
redhat/Makfile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION
Change RPMKEXTRAVERSION to SPECEXTRAVERSION so that readers understand it is
passed
into the spec file.
Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat
From: Prarit Bhargava
redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG
Change PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG so that readers
understand it is passed into the spec file.
Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG.
Signed-off-by: Prarit Bhargava
From: Prarit Bhargava
redhat/Makfile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL
Change RPMKPATCHLEVEL to SPECPATCHLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat
From: Prarit Bhargava
redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG
Change CHANGELOG to SPECCHANGELOG so that readers understand it is passed
into the spec file. While the CHANGELOG does have use other than in the
spec file it is useful to know that the string is used in the spec file
From: Prarit Bhargava
redhat/Makefile: Use KVERSION
Use KVERSION where appropriate in the Makefile.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -144,8 +144,8 @@ else
MARKER
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727
Add a test to verify Makefile declarations, and add the RHTEST variable.
The latter of these changes allows
From: Prarit Bhargava
redhat/Makefile: Rename TARFILE_RELEASE to SPECTARFILE_RELEASE
Change TARFILE_RELEASE to SPECTARFILE_RELEASE so that readers
understand it is passed into the spec file.
Rename TARFILE_RELEASE to SPECTARFILE_RELEASE.
Signed-off-by: Prarit Bhargava
diff --git a/redhat
From: Prarit Bhargava
redhat/self-test: Add test to verify SPEC variables
This test looks at the spec file variable replacement code in
redhat/genspec.sh and confirms that each variable begins with "SPEC".
Signed-off-by: Prarit Bhargava
diff --git a/redhat/docs/makefile-changes.rs
From: Prarit Bhargava
redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED
Change DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED so that readers
understand it is passed into the spec file.
Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED.
Signed-off-by: Prarit
From: Prarit Bhargava
redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG
Change CHANGELOG to SPECCHANGELOG so that readers understand it is passed
into the spec file. While the CHANGELOG does have use other than in the
spec file it is useful to know that the string is used in the spec file
From: Prarit Bhargava
redhat/Makefile: Rename DISTRO_BUILD to SPECDISTROBUILD
Change DISTRO_BUILD to SPECDISTROBUILD so that readers understand it is passed
into the spec file.
Rename DISTRO_BUILD to SPECDISTROBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat
From: Prarit Bhargava
redhat/Makfile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL
Change RPMKPATCHLEVEL to SPECPATCHLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat
From: Prarit Bhargava
redhat/Makfile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL
Change RPMKSUBLEVEL to SPECSUBLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKSUBLEVEL to SPECKSUBLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
From: Prarit Bhargava
redhat/Makefile: Rename PKGRELEASE to SPECBUILD
PKGRELEASE is a confusing variable name, and it really is the BUILD string
for the specfile.
Rename PKGRELEASE to SPECBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah
From: Prarit Bhargava
redhat/Makfile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION
Change RPMKEXTRAVERSION to SPECEXTRAVERSION so that readers understand it is
passed
into the spec file.
Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat
From: Prarit Bhargava
redhat/Makefile: Rename RPMKVERSION to SPECKVERSION
Change RPMKVERSION to SPECVERSION so that readers understand it is passed
into the spec file.
Rename RPMKVERSION to SPECKVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647
One of the common complaints about the redhat Makefiles, genspec.sh, and
kernel.spec.template
From: Prarit Bhargava
redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID
Change BUILDID_DEFINE to SPECBUILDID so that readers understand it is passed
into the spec file.
Rename BUILDID_DEFINE to SPECBUILDID.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
From: Prarit Bhargava
redhat/Makefile: Rename KVERSION to SPECVERSION
KVERSION is passed into the spec file and is easy to confuse with the
kernel KVERSION. Change the name to SPECVERSION so that readers
understand it is the %Version field of the specfile.
As a result RPMKSUBLEVEL can
From: Prarit Bhargava
redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG
Change PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG so that readers
understand it is passed into the spec file.
Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG.
Signed-off-by: Prarit Bhargava
From: Prarit Bhargava
redhat/self-test: Add test to verify SPEC variables
This test looks at the spec file variable replacement code in
redhat/genspec.sh and confirms that each variable begins with "SPEC".
Signed-off-by: Prarit Bhargava
diff --git a/redhat/docs/makefile-changes.rs
From: Prarit Bhargava
redhat/Makefile: Deprecate some simple targets
Deprecate some simple targets.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -418,15 +418,23 @@ $(KABIDW_TARBALL
From: Prarit Bhargava
redhat/Makefile: Deprecate some simple targets
Deprecate some simple targets.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -418,15 +418,23 @@ $(KABIDW_TARBALL
From: Prarit Bhargava
redhat/Makefile: Rename TARFILE_RELEASE to SPECTARFILE_RELEASE
Change TARFILE_RELEASE to SPECTARFILE_RELEASE so that readers
understand it is passed into the spec file.
Rename TARFILE_RELEASE to SPECTARFILE_RELEASE.
Signed-off-by: Prarit Bhargava
diff --git a/redhat
From: Prarit Bhargava
redhat/Makefile: Use KVERSION
Use KVERSION where appropriate in the Makefile.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -144,8 +144,8 @@ else
MARKER
From: Prarit Bhargava
redhat/Makefile: Add 'duplicate' SPEC entries for user set variables
INCLUDE_FEDORA_FILES, INCLUDE_RHEL_FILES, and RELEASED_KERNEL are
specified in Makefile.variables as they can be set in userspace.
Create duplicate entries for these variables that begin with SPEC
From: Prarit Bhargava
redhat/scripts/create-tarball.sh: Use Makefile variables
Use Makefile variables in redhat/scripts/create-tarball.sh.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
From: Prarit Bhargava
redhat/kernel.spec.template: Use RPM_BUILD_NCPUS
RPM_BUILD_NCPUS allows users to modify the max number of cpus used by the
RPM build.
Use the RPM_BUILD_NCPUS variable in the spec file.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/kernel.spec.template b/redhat
From: Prarit Bhargava
redhat/configs/build_configs.sh: Use Makefile variables
Use Makefile variables in build_configs.sh.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -363,8 +363,8
From: Prarit Bhargava
redhat/configs/generate_all_configs.sh: Use Makefile variables
Use Makefile variables in generate_all_configs.sh.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
From: Prarit Bhargava
redhat/Makefile.rhpkg: Remove quotes for RHDISTGIT
Remove the quotes around RHDISTGIT. This causes problems with the bash
scripts in the dist-git-test target.
Signed-off-by: Justin M. Forbes
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile.rhpkg b/redhat
From: Prarit Bhargava
redhat/Makefile: Deprecate SINGLE_TARBALL
We don't know if there are any users of the SINGLE_TARBALL variable. Mark
it for deprection. This commit can be reverted if anyone complains.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/scripts/rh-dist-git.sh: Use Makefile variables
Use Makefile variables in rh-dist-git.sh.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -637,7 +637,7
901 - 1000 of 1815 matches
Mail list logo
