Re: [OS-BUILD PATCH] redhat/Makefile.common: Fix 'fatal: Not a valid object name master' error

2021-04-02 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/588#note_544037237 @prarit Can we close this in favor of https://gitlab.com/cki- project/kernel-ark/-/merge_requests/995? This helps address an issue in the documentation !772 where there is ambiguity

Re: [OS-BUILD PATCH] redhat/Makefile.common: Fix 'fatal: Not a valid object name master' error

2021-04-02 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/588#note_544031220 @prarit Does this work better? ``` diff --git a/redhat/Makefile.common b/redhat/Makefile.common index 64aaa40e5adaf..2fa7a5c8e13f8 100644 --- a/redhat/Makefile.common +++

Re: [OS-BUILD PATCH] redhat/Makefile.common: Fix 'fatal: Not a valid object name master' error

2021-03-22 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/588#note_535156408 @prarit - still need this? I think I would prefer you check for 'master' and generate a graceful exit message then to try and cycle through various possible tree names like 'upstream'.

[OS-BUILD PATCH] redhat/Makefile.common: Fix 'fatal: Not a valid object name master' error

2020-08-17 Thread GitLab Bridge on behalf of prarit
From: Prarit Bhargava Hey everyone, I spent 5-10 mins looking at the 'fatal: Not a valid object name master' error this morning. It comes from the redhat/Makefile.common:45 MERGE_BASE:=$(shell git merge-base HEAD master) There is no master branch so 'git merge-base HEAD master' returns an