Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-14 Thread Patrick Talbert (via Email Bridge)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_600799175  Editing a comment in GL does not generate a webhook event so the ack_nack bot won't be aware of the change until something else triggers a run of it.

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-14 Thread Daniel Horak (via Email Bridge)
From: Daniel Horak on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_600764882 let retry :-) Acked-by: Dan Horák ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-11 Thread Florian Weimer (via Email Bridge)
From: Florian Weimer on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_598979089 Current GCC compiles this code to use the `msrkc` instruction: ```c #include int f (int a, int b) { int result; if (__builtin_mul_overflow (a, b, )) abort (); return

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-11 Thread Daniel Horak (via Email Bridge)
From: Daniel Horak on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_598845029 LGTM Acked-by: Dan Horák [dho...@redhat.com](mailto:dho...@redhat.com) ___ kernel mailing list -- kernel@lists.fedoraproject.org To

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-11 Thread Cornelia Huck (via Email Bridge)
From: Cornelia Huck on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_598834211 Just for the record, re-adding my ack: Acked-by: Cornelia Huck ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-10 Thread Thomas Huth (via Email Bridge)
From: Thomas Huth on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_598697074 If I've got that right, the z14 introduced the "Miscellaneous-Instruction- Extensions Facility 2" which provides a bunch of new instructions: * ADD HALFWORD (AGH) * BRANCH INDIRECT ON

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-10 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_598568514 thanks @jmflinuxtx ! I am fine with this change (namely the dummy-tools). @dhorak1 - any other issues? care to ack? I see @cohuck already acked.

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Justin Forbes (via Email Bridge)
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_596135080 > is it worth throwing a 'include in release' label and seeing if this can build in eln? I have tagged it with "include in release" and done a test build with it against ELN koji:

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595946671 @jmflinuxtx - is it worth throwing a 'include in release' label and seeing if this can build in eln? @veruu - i can probably hack up the gitlab-ci.yml file like i did in another MR to try

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Philipp Rudo (via Email Bridge)
From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595925875 sure. BTW I'm joining RH so the email and accounts will still exist in the future. Nevertheless I guess it would be better if someone else takes over if we there's a delay. Don't know

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Philipp Rudo (via Email Bridge)
From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595920020 @dzickusrh this MR can be build on any machine with an appropriate compiler (IIRC GCC10). Only the resulting kernel requires a z14+ to run. I know that the change is necessary. I was

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Justin Forbes (via Email Bridge)
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595919862 > glibc 2.34 will detect `-march=z14` and refuse to run on z13 or earlier, to avoid hard-to-diagnose crashes later. We learned the hard way that this very desirable during the ppc64le

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Florian Weimer (via Email Bridge)
From: Florian Weimer on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595913747 glibc 2.34 will detect `-march=z14` and refuse to run on z13 or earlier, to avoid hard-to-diagnose crashes later. We learned the hard way that this very desirable during the ppc64le

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Justin Forbes (via Email Bridge)
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595910611 > do we know which s390x machines ELN builds on? The koji builders are Z13. They are running a Fedora kernel to do the build, so the 5.13-rc5 eln build was done in koji running

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread via Email Bridge
From: Veronika Kabátová on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595904290 We should be all set, the containers are all built using qemu's experimental z14 support and we do have a native z14 (or temporary z15 in case of outages...) builder for the tools.

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595897703 @prudo1 - if for some reason you have to leave before this MR is merged, are you ok with RH resubmitting your work and retaining your SOB line?

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595896264 @veruu - this MR will require a z14 or higher to compile ARK. CKI can handle building os-build for that right? The srpm piece doesn't matter. @jmflinuxtx - do we know which s390x

Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Philipp Rudo (via Email Bridge)
From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595402767 Hi, sorry for the late response. here's the v3 with what I picked up from the discussion, in particular improve the wording of the first two commit messages and leave the rest as is.

[OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390

2021-06-08 Thread Philipp Rudo (via Email Bridge)
From: Philipp Rudo on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144 This series aims to update the Architecture Level Set on s390 for ark to Z14. Unfortunately this collides with a workaround introduced with f88717cf44eb ("Temporarily switch