Re: [OS-BUILD PATCH] Make RHJOBS container friendly

2023-03-20 Thread Michael Hofmann (via Email Bridge)
From: Michael Hofmann on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2375#note_1321311286 iiuc, nproc is coreutils -> gnulib -> https://github.com/coreutils/gnulib/blob/master/lib/nproc.c, which doesn't seem to know anything about these newfangled things like cgroups

Re: [OS-BUILD PATCH] Make RHJOBS container friendly

2023-03-20 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2375#note_1321278887 Hmm, as an end user it seems odd to have to know what cgroup version and other quirks are on the system to make correctly calculations. I would think that would be part of nproc's

Re: [OS-BUILD PATCH] Make RHJOBS container friendly

2023-03-20 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2375#note_1321270325 Yeah, I've known about the cgroups problem but never really had time to address it. I think that this change at least makes things no less better or worse that what we currently

Re: [OS-BUILD PATCH] Make RHJOBS container friendly

2023-03-20 Thread Michael Hofmann (via Email Bridge)
From: Michael Hofmann on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2375#note_1321162650 just to be clear, that will still not take cgroup limits into account, so any Docker/Kubernetes deployment that just applies "Limits" will still see all cpus on the host machine.