Re: Fix for rhbz #1409801
On 01/04/2018 12:25 PM, Shaun Assam wrote: Hi Laura, Thanks for the clarification regarding the ACPI specs. If setting the acpi_rev to "yes" causes any issues, could the option be enabled but set to "no"? This would allow users the ability to turn it "on" with kernel parameters in GRUB. Regards, Shaun Assam You always need to enable it with a kernel command line option, if it isn't there the option does nothing and you need to match a machine. My concern is still causing issues for users who want to set it "yes" but nothing has ever shown up there so it's probably fine. Thanks, Laura ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Re: Fix for rhbz #1409801
Hi Laura, Thanks for the clarification regarding the ACPI specs. If setting the acpi_rev to "yes" causes any issues, could the option be enabled but set to "no"? This would allow users the ability to turn it "on" with kernel parameters in GRUB. Regards, Shaun Assam From: Laura Abbott Sent: Wednesday, January 3, 11:24 AM Subject: Re: Fix for rhbz #1409801 To: Shaun Assam, kernel@lists.fedoraproject.org On 12/26/2017 10:11 AM, Shaun Assam wrote: > Hello Kernel Maintainers, > > I would like to submit a fix for bug #1409801 regarding the ethernet > adapter not working on Dell Latitude 3350 (https://bugzilla.redhat.com/ > show_bug.cgi?id=1409801). This issue is only related to the Fedora > kernels from 4.4+, and does not affect the upstream kernels used by > other distributions like Ubuntu or Arch. > > This issue can be resolved by turning on the ACPI_REV_OVERRIDE option > in the kernel config files for i686 and x86_64. Currently the > configuration is set to: > > # CONFIG_ACPI_REV_OVERRIDE_POSSIBLE is not set > > By changing it to: > > CONFIG_ACPI_REV_OVERRIDE_POSSIBLE=y > > The following boot errors no longer occur: > > [ 1.972457] pci :00:1c.2: Error enabling bridge (-16), > continuing > [ 1.973304] r8169 :03:00.0 (unnamed net_device) (uninitialized): > enable failure > > In addition to fixing the ethernet issue, it also fixes an issue with > the Bluetooth device on the laptop automatically switching on after > shutdown/reboot (not when resuming from sleep/hibernate). The Bluetooth > icon would appear in the GNOME System Menu and would have to manually > be turned off. Since applying the ACPI_REV fix, this is no longer a > problem. I have been testing this change for the last three days and > have not encountered any issues resulting from this fix. > > The issue regarding this bug has been patched in the upstream kernel > for sometime and is already included in the code for current versions > of the Fedora kernel (see drivers/acpi/blacklist.c for details -- the > code applies to Dell laptops/computers). > > I would like to request this fix be included in future Fedora kernel > releases so we may close this bug and possibly fix other, opened, bugs > related to this configuration. I have attached the config files to this > email for your convenience (around line 75). So for the longest time we didn't want to turn this option on. While it certainly fixes some problems, overriding the ACPI table like this is questionable from an ACPI spec perspective. When the option was first introduced, it was only supposed to be for the Dell XPS 13 for a sound issue and only until more of the sound framework was updated. Clearly other machines have been added since then and it doesn't seem to be going away. The benefits to users outweigh my personal opinions at this point (it's still a complete hack) so I'll turn it on in rawhide. We're close enough to a new kernel that we can pick it up for F26/F27 when the rebase happens. Thanks, Laura ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Re: [PATCH 0/2] configs: Rename base-{generic,debug} to configs/fedora/
On Thu, Jan 04, 2018 at 11:00:03AM -0800, Laura Abbott wrote:
> On 12/20/2017 04:04 PM, Laura Abbott wrote:
> > On 12/20/2017 09:39 AM, Don Zickus wrote:
> > > On Wed, Dec 13, 2017 at 04:39:26PM -0500, Don Zickus wrote:
> > > > This patchset renames the configs/base-{generic,debug} to
> > > > configs/fedora/{generic,debug} and updates the scripts to reflect that.
> > >
> > > Hi Jarod, Peter,
> > >
> > > Does this approach work better?
> > >
> > > Cheers,
> > > Don
> > >
> >
> > Sorry, I forgot about this last week. I'm pretty much indifferent to
> > what this gets called so I'll wait for feedback from someone before
> > applying.
> >
>
> I haven't heard any more feedback. If you are still interested in having
> these applied, can you rebase to the latest rawhide?
Actually I am as I think it simplifies things on the script side.
https://pagure.io/fedora-kernel-dzickus.git rh_sync2
is a forced update. Nothing on this patchset changed other than moving new
config files to the new directory.
Cheers,
Don
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Re: [PATCH 0/2] configs: Rename base-{generic,debug} to configs/fedora/
On 12/20/2017 04:04 PM, Laura Abbott wrote:
On 12/20/2017 09:39 AM, Don Zickus wrote:
On Wed, Dec 13, 2017 at 04:39:26PM -0500, Don Zickus wrote:
This patchset renames the configs/base-{generic,debug} to
configs/fedora/{generic,debug} and updates the scripts to reflect that.
Hi Jarod, Peter,
Does this approach work better?
Cheers,
Don
Sorry, I forgot about this last week. I'm pretty much indifferent to
what this gets called so I'll wait for feedback from someone before
applying.
I haven't heard any more feedback. If you are still interested in having
these applied, can you rebase to the latest rawhide?
Because the configs rename patch is huge and Laura prefers not to have it
on the list, I am purposely excluding the content of that particular patch.
The script changes are attached for public review.
The code can be reviewed here:
https://pagure.io/fedora-kernel-dzickus.git rh_sync2
Don Zickus (2):
configs: Move base-debug and base-generic to configs/fedora
configs: Update config generation script to use configs/fedora
configs/build_configs.sh | 62 +++---
configs/config_generation | 5 ++
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
