[OS-BUILD PATCH 4/4] redhat: Enable VM kselftests

2022-05-16 Thread Nico Pache (via Email Bridge)
From: Nico Pache redhat: Enable VM kselftests in order to increase code coverage for HMM and GUP we need to build the vm kselftests into our internal testing packages. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1978539 Upstream-status: RHEL-only Signed-off-by: Nico Pache diff

[OS-BUILD PATCH 3/4] redhat: enable CONFIG_TEST_VMALLOC for vm selftests

2022-05-16 Thread Nico Pache (via Email Bridge)
From: Nico Pache redhat: enable CONFIG_TEST_VMALLOC for vm selftests Compile CONFIG_TEST_VMALLOC as a module and isolate it to the internals package only. Upstream-status: RHEL-only Signed-off-by: Nico Pache diff --git a/redhat/configs/common/generic/CONFIG_TEST_VMALLOC

[OS-BUILD PATCH 2/4] redhat: enable GUP TEST for kselftests

2022-05-16 Thread Nico Pache (via Email Bridge)
From: Nico Pache redhat: enable GUP TEST for kselftests Compile the GUP TEST as a module and isolate it to the internals package only. Upstream-status: RHEL-only Signed-off-by: Nico Pache diff --git a/redhat/mod-internal.list b/redhat/mod-internal.list index blahblah..blahblah 100644 ---

[OS-BUILD PATCH 1/4] redhat: Enable HMM test to be used by the kselftest test suite

2022-05-16 Thread Nico Pache (via Email Bridge)
From: Nico Pache redhat: Enable HMM test to be used by the kselftest test suite This commit enables the hmm test to be compiled into the internals packaging, which will be utilized by the kselftests userspace executor. Upstream-status: RHEL-only Signed-off-by: Nico Pache diff --git

[OS-BUILD PATCH 0/4] redhat: enable VM kselftests

2022-05-16 Thread Nico Pache (via Email Bridge)
From: Nico Pache on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1783 Enable VM kselftests to increase testing capabilities. Upstream-status: RHEL-only Signed-off-by: Nico Pache --- redhat/configs/common/generic/CONFIG_TEST_HMM | 2 +-

[OS-BUILD PATCH] redhat/Makefile: Drop quotation marks around string definitions

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Drop quotation marks around string definitions dzickus reports that 'make dist-srpm-gcov' doesn't work anymore. Not only is an error reported, error: line 555: Illegal char '"' (0x22) in: Release: 0.rc7.53".gcov".fc35 error: query of specfile

Re: [OS-BUILD PATCHv3 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948629446 Sorry everyone, I had to re-push. I noticed a small bug in which the localversion was not being properly reflected in the spec file. ___

[OS-BUILD PATCHv3 16/17] redhat/Makefile: Rename PREBUILD to UPSTREAMBUILD

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename PREBUILD to UPSTREAMBUILD PREBUILD isn't a good name for this variable. It is the portion of the string that references upstream build information. Rename it to UPSTREAMBUILD. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

[OS-BUILD PATCHv3 17/17] self-test/data/create-data.sh: Avoid SINGLE_TARBALL warning

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava self-test/data/create-data.sh: Avoid SINGLE_TARBALL warning 'make dist-self-test-data' outputs the warning "Makefile:25: WARNING: SINGLE_TARBALL will be deprecated in a later release." Unset the parameter before the make calls. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv3 9/17] redhat/kernel.spec.template: Move genspec variables into one section

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Move genspec variables into one section Move the genspec variables into one section. This re-introduces the SPECKVERSION variable into the specfile. Additional fix: add a tarfile_release variable that maps to SPECTARFILE_RELEASE.

[OS-BUILD PATCHv3 15/17] redhat/Makefile: Rename BUILDID to LOCALVERSION

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename BUILDID to LOCALVERSION BUILDID isn't a very descriptive name. Rename the variable to LOCALVERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv3 14/17] redhat/Makefile: Fix dist-brew & distg-brew targets

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Fix dist-brew & distg-brew targets The dist-brew and distg-brew targets always require some variable manipulation on the command line. Hardcode DIST, DISTRO, and SCRATCH_TARGET to always create a "RHEL9" brew build. Signed-off-by: Prarit Bhargava diff

[OS-BUILD PATCHv3 13/17] redhat/Makefile: Reorganize MARKER code

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Reorganize MARKER code Reorganize the MARKER code. MARKER is always UPSTREAM_TARBALL_NAME prefixed with a 'v'. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv3 11/17] redhat/Makefile: Rename __YSTREAM and __ZSTREAM

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename __YSTREAM and __ZSTREAM The __YSTREAM and __ZSTREAM names can be replaced with YSTREAM_FLAG and ZSTREAM_FLAG. This makes future changes easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCHv3 10/17] redhat/genspec.sh: Add comment about SPECBUILDID variable

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Add comment about SPECBUILDID variable Add a comment about the non-obvious use of SPECBUILDID in the specfile. Move the definition of SPECRELEASE to a better location. Signed-off-by: Prarit Bhargava diff --git a/redhat/genspec.sh b/redhat/genspec.sh

[OS-BUILD PATCHv3 12/17] redhat/scripts/new_release.sh: Use Makefile variables

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/new_release.sh: Use Makefile variables Use Makefile variables in new_release.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -607,7 +607,7 @@

[OS-BUILD PATCHv3 8/17] redhat/kernel.spec.template: Remove kversion

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Remove kversion Remove kversion. It is unused. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 --- a/redhat/kernel.spec.template +++

[OS-BUILD PATCHv3 7/17] redhat/Makefile: Add SPECTARFILE_RELEASE comment

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add SPECTARFILE_RELEASE comment Add comment about the SPECTARFILE_RELEASE variable. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -246,11

[OS-BUILD PATCHv3 6/17] redhat/Makefile: Rename RPMVERSION to BASEVERSION

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename RPMVERSION to BASEVERSION RPMVERSION is the rpm NVR without the dist tag. It is not the RPM version so RPMVERSION is not an accurate name for this field. Rename RPMVERSION to BASEVERSION. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv3 4/17] redhat/Makefile: Move SPECRELEASE to genspec.sh

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move SPECRELEASE to genspec.sh Move SPECRELEASE to genspec.sh. It is the only place it is used. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv3 5/17] redhat/Makefile: Target whitespace cleanup

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Target whitespace cleanup Some simple whitespace cleanups. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -442,7 +442,6 @@ $(KABIDW_TARBALL):

[OS-BUILD PATCHv3 3/17] redhat/Makefile: Add kernel-NVR comment

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add kernel-NVR comment Add a comment explaining the variables used in constructing the kernel package's NVR, and reorganize the variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv3 2/17] redhat/Makefile: Use SPECFILE variable

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use SPECFILE variable Use the SPECFILE variable throughout the Makefiles. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -548,7 +548,7 @@

[OS-BUILD PATCHv3 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757 Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728 This is a collection of various improvements and fixes for the redhat/Makefile variables. These fixes

[OS-BUILD PATCHv3 1/17] redhat/Makefile: Remove KEXTRAVERSION

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove KEXTRAVERSION KEXTRAVERSION isn't used for anything and can be removed. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -147,11 +147,9 @@

Re: [OS-BUILD PATCH 0/2] Makefile: only depend on dist-buildreq-check when building actual RPMs

2022-05-16 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1781#note_948591088 I don't know that there is a better way short of us maintaining a list of required deps for that case. This gets more tricky in that if someone submits a config change that also

Re: [OS-BUILD PATCH 0/2] Makefile: only depend on dist-buildreq-check when building actual RPMs

2022-05-16 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1781#note_948589022 @hertonrk-rh agreed. There are srpm deps: https://cki- project.gitlab.io/kernel-ark/#cloning-the-repository Now I will agree that dist-buildreq-check might have swung to far in one

Re: [OS-BUILD PATCH 0/2] Makefile: only depend on dist-buildreq-check when building actual RPMs

2022-05-16 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1781#note_948563825 I think we kept build reqs check even for non rpm cases because eg. config building requires some of the buildreqs, and the buildreq check would provide that. Also, some config

[OS-BUILD PATCH 2/2] [redhat] Makefile: only depend on dist-buildreq-check when building actual RPMs

2022-05-16 Thread via Email Bridge
From: Ondrej Mosnacek [redhat] Makefile: only depend on dist-buildreq-check when building actual RPMs It only makes sense to check for the build reqs when doing a local RPM build, not when building only an SRPM or running prep. Fixes: e55e0fde769a ("[redhat] Makefile: new dist-buildreq-check

[OS-BUILD PATCH 1/2] [redhat] Makefile: drop duplicate dist-sources deps

2022-05-16 Thread via Email Bridge
From: Ondrej Mosnacek [redhat] Makefile: drop duplicate dist-sources deps do-rpmbuild itself already depends on dist-sources, thus no need to specify when we depend on do-rpmbuild already. Signed-off-by: Ondrej Mosnacek diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah

[OS-BUILD PATCH 0/2] Makefile: only depend on dist-buildreq-check when building actual RPMs

2022-05-16 Thread via Email Bridge
From: Ondrej Mosnáček on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1781 It only makes sense to check for the build reqs when doing a local RPM build, not when building only an SRPM or running prep. --- redhat/Makefile | 20 +++- 1

Re: [OS-BUILD PATCHv3] redhat/docs: Add a description of kernel naming

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1779#note_948492571 Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

[OS-BUILD PATCHv3] redhat/docs: Add a description of kernel naming

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/docs: Add a description of kernel naming Add a file that describes how kernel NVRs are constructed. Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/index.rst b/redhat/docs/index.rst index blahblah..blahblah 100644 --- a/redhat/docs/index.rst +++

Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948427545 It definitely depends on the repo. I think I had so more garbage that it inflated things. 'git gc' removed enough junk that my 'git log --oneline' is down to 12. Looking into this

Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Thorsten Leemhuis (via Email Bridge)
From: Thorsten Leemhuis on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948392278 > maybe it is just me, but a 'git log --oneline' shows 13 chars already. Does it maybe depend on the repo? for my Linux mainline checkout I get 12; for another git repo I get just

Re: [OS-BUILD PATCH] redhat/docs: Add a description of kernel naming

2022-05-16 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1779#note_948378932 A lot of the places RHEL is referenced are because they are RHEL bits. Fedora doesn't care what RHEL release is set to. The only real interaction I have with RHEL bits doing Fedora

Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948374003 maybe it is just me, but a 'git log --oneline' shows 13 chars already. git log --oneline --abbrev=8|grep -Ev "^[0-9a-f]{,10} " shows me 9 commits that are 11 chars long. I am not

Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Thorsten Leemhuis (via Email Bridge)
From: Thorsten Leemhuis on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948353077 > can you open issues for these changes? Will do, but give me a few days. And yeah, definitely feel free to mark this thread as resolved (I'd still be interested in @dzickusrh

Re: [OS-BUILD PATCH] redhat/docs: Add a description of kernel naming

2022-05-16 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1779#note_948254254 I have the same feeling as Neal, in which ark is rhel and we can have it as rhel. We have ark for historic reasons when the common kernel was introduced for rhel/fedora (except

Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948197881 Oh, I should add we're trying to get this done this week to avoid a 3-4 week slip for rebasing and -rc2/-rc3. ___ kernel mailing list --

Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948196822 @knurd42 , can you open issues for these changes? That way they'll be tracked and we can resolve this thread which doesn't impact *this* MR.