[OS-BUILD PATCH] RHMAINTAINERS: Update for Jan 6 2023

2023-01-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava RHMAINTAINERS: Update for Jan 6 2023 Update RHMAINTAINERS to latest. Signed-off-by: Prarit Bhargava diff --git a/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS b/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS index blahblah..blahblah 100644 ---

Re: [OS-BUILD PATCHv4] makefile: Add -Werror support for RHEL

2023-01-06 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230424301 We are already building with `-Werror=format-security` Though we typically do not run across many errors until a new toolchain is introduced. That is where this gets problematic to

Re: [OS-BUILD PATCHv4] makefile: Add -Werror support for RHEL

2023-01-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230405114 Yeah, I was a bit torn on this too for the same reasons; even with this change we have to 'remember' to set CONFIG_WERROR which is lame. One thing to keep in mind is that it does

[OS-BUILD PATCHv4] makefile: Add -Werror support for RHEL

2023-01-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava makefile: Add -Werror support for RHEL The -Werror flag should be enabled for RHEL. In ARK, however, it is a bit tricky to enable -Werror as a build bug occasionally leaks through upstream review and into Linus' tree. As a consequence, CONFIG_WERROR cannot be enabled in

Re: [OS-BUILD PATCHv3] makefile: Add -Werror support for RHEL

2023-01-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230393561 Oh it certainly does need that line. I'll add it. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email

Re: [OS-BUILD PATCHv3] makefile: Add -Werror support for RHEL

2023-01-06 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230246925 @prarit - hmm, ok I am torn here. I thank you for respecting the 'do not break ARK approach'. But then I wonder what is the value of this in ARK (besides the obvious don't lose

Re: [OS-BUILD PATCHv3] makefile: Add -Werror support for RHEL

2023-01-06 Thread Brian Masney (via Email Bridge)
From: Brian Masney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230234958 OK, good point about not enabling it on ARK. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv3] makefile: Add -Werror support for RHEL

2023-01-06 Thread Brian Masney (via Email Bridge)
From: Brian Masney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230232997 Do you also need to add `KBUILD_CPPFLAGS += $(KBUILD_CPPFLAGS-y)`? This is from https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit /?id=efa80b028c7a9

[OS-BUILD PATCHv3] makefile: Add -Werror support for RHEL

2023-01-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava makefile: Add -Werror support for RHEL The -Werror flag should be enabled for RHEL. In ARK, however, it is a bit tricky to enable -Werror as a build bug occasionally leaks through upstream review and into Linus' tree. As a consequence, CONFIG_WERROR cannot be enabled in

Re: [OS-BUILD PATCHv2] makefile: Add -Werror support for RHEL

2023-01-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230134074 Good point, however, as I mentioned in the commit log we still occasionally see compile warnings in upstream code and we cannot have the build fail in ARK/Fedora due to those

[OS-BUILD PATCHv2] makefile: Add -Werror support for RHEL

2023-01-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava makefile: Add -Werror support for RHEL The -Werror flag should be enabled for RHEL. In ARK, however, it is a bit tricky to enable -Werror as a build bug occasionally leaks through upstream review and into Linus' tree. As a consequence, CONFIG_WERROR cannot be enabled in

Re: [OS-BUILD PATCH] makefile: Add -Werror support for RHEL

2023-01-06 Thread Thomas Huth (via Email Bridge)
From: Thomas Huth on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1229850029 As I wrote on the mailing list: I think the hunk is not needed anymore since we do not compile the powerpc kernel with -O3 anymore (which caused the wrong warnings in RHEL7 and likely