Private bug reported:

Description:
Commit efda1b5d87cb ("acpi, nfit, libnvdimm: fix / harden ars_status output 
length handling")
Introduced additional hardening for ambiguity in the ACPI spec for
ars_status output sizing. However, it had a couple of cases mixed up.
Where it should have been checking for (and returning) "out_field[1] -
4" it was using "out_field[1] - 8" and vice versa.

This caused a four byte discrepancy in the buffer size passed on to
the command handler, and in some cases, this caused memory corruption
like:

./daxdev-errors.sh: line 76: 24104 Aborted (core dumped) ./daxdev-errors 
$busdev $region
malloc(): memory corruption
Program received signal SIGABRT, Aborted.
[...]
#5 0x00007ffff7865a2e in calloc () from /lib64/libc.so.6
#6 0x00007ffff7bc2970 in ndctl_bus_cmd_new_ars_status 
(ars_cap=ars_cap@entry=0x6153b0) at ars.c:136
#7 0x0000000000401644 in check_ars_status (check=0x7fffffffdeb0, bus=0x604c20) 
at daxdev-errors.c:144
#8 test_daxdev_clear_error (region_name=<optimized out>, bus_name=<optimized 
out>)
at daxdev-errors.c:332

Target Kernel: 4.19
Target Release: 18.10

** Affects: linux (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: intel-kernel-18.10

** Information type changed from Public to Private

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1787090

Title:
  [AEP-bug] libnvdimm: Fix a bug that overwrites and corrupts user
  memory in an ARS_STATUS command

Status in linux package in Ubuntu:
  New

Bug description:
  Description:
  Commit efda1b5d87cb ("acpi, nfit, libnvdimm: fix / harden ars_status output 
length handling")
  Introduced additional hardening for ambiguity in the ACPI spec for
  ars_status output sizing. However, it had a couple of cases mixed up.
  Where it should have been checking for (and returning) "out_field[1] -
  4" it was using "out_field[1] - 8" and vice versa.

  This caused a four byte discrepancy in the buffer size passed on to
  the command handler, and in some cases, this caused memory corruption
  like:

  ./daxdev-errors.sh: line 76: 24104 Aborted (core dumped) ./daxdev-errors 
$busdev $region
  malloc(): memory corruption
  Program received signal SIGABRT, Aborted.
  [...]
  #5 0x00007ffff7865a2e in calloc () from /lib64/libc.so.6
  #6 0x00007ffff7bc2970 in ndctl_bus_cmd_new_ars_status 
(ars_cap=ars_cap@entry=0x6153b0) at ars.c:136
  #7 0x0000000000401644 in check_ars_status (check=0x7fffffffdeb0, 
bus=0x604c20) at daxdev-errors.c:144
  #8 test_daxdev_clear_error (region_name=<optimized out>, bus_name=<optimized 
out>)
  at daxdev-errors.c:332

  Target Kernel: 4.19
  Target Release: 18.10

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1787090/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to