These patch sets are quite invasive for a stable kernel. It looks like
the default behavior is untouched if cq_cpumask is zero. However, I
would like to see some discussion with upstream as to the efficacy of
IRQ affinity with this device.
Mykyta - can you develop and send a patch for current
Sorry for the late action. I made a patch (attached) adding the nitpicks
we discussed above, and a couple others. Please take a look and let me
know what you think. If all is well, I'll submit this all to the mailing
list to be merged.
** Patch added:
I agree that it is wise to intersect cq_cpumask with online_cpumask in
cq_cpulist_set(), and if cpuset_weight(cq_cpumask & online_cpumask) == 0
-- ignore cq_cpumask and stick with default behavior.
I don't think cpu offlining is problematic here. If CPU is offlined --
the IRQ (and queue) will be
@mykizi-ericsson Could I get an update for my last comment? If CPU
hotplugging can't be addressed then perhaps it'd be alright to just mark
the new module parameter as unsafe...
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in
Thanks for the clarification, that makes sense to me now. It doesn't
look like the patch handles CPU hotplugging though; a cpumask filled
with *only* offline CPUs can be passed as a parameter, or all of the
CPUs in the cpumask can be offlined after the setup is finished. This
isn't a problem with
The permission is set to 0 on a purpose -- to prevent runtime changes.
The parameter can be still used on modprobe/insmod or on kernel command
line.
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
It looks like the supplied patch is a no-op. A module parameter is
introduced with a .set function, but the parameter does not have any
write permission specified so the .set function can never execute (since
userspace won't have permission to write to the module parameter file).
** Tags added: patch
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1831566
Title:
[realtime app] not possible to redirect drivers/nvme IRQs from
realtime cpuset
Status in linux
** Changed in: linux (Ubuntu)
Status: Incomplete => Confirmed
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1831566
Title:
[realtime app] not possible to redirect drivers/nvme
9 matches
Mail list logo
