[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-13 Thread granjerox
So far so good. No crahes since upgrade, nuc:~$ uname -a Linux nuc 5.0.0-25-generic #26~18.04.1-Ubuntu SMP Thu Aug 1 13:51:02 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux nuc:~$ uptime 11:40:24 up 22:12, 2 users, load average: 6,64, 6,65, 6,48 pagraher@nuc:~$ -- You received this bug

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-13 Thread Launchpad Bug Tracker
This bug was fixed in the package linux - 5.0.0-25.26 --- linux (5.0.0-25.26) disco; urgency=medium * CVE-2019-1125 - x86/cpufeatures: Carve out CQM features retrieval - x86/cpufeatures: Combine word 11 and 12 into a new scattered features word - x86/speculation:

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-12 Thread Guilherme G. Piccoli
Hi @granjerox, thanks for your report! Let us know how the test with -proposed goes. And thanks Kleber for the comment/advice here! @connork, I've filled a new LP with the bug I've found, thanks for the attention: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1839849 Cheers, Guilherme

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-12 Thread granjerox
Thanks @Kleber. I've just done it. I'll report any issue. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1824981 Title: cifs set_oplock buffer overflow in strcat Status in linux

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-12 Thread Kleber Sacilotto de Souza
Hi @granjerox, The fix for this bug is available in Bionic linux-hwe-18.04 version 5.0.0-25.26, which is currently in -proposed. This package is scheduled to be published in -updates soon (during the next few days). In the meantime, the fixed kernel can be installed by enabling the -proposed

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-10 Thread granjerox
My server was pretty unstable until I've installed latest mainline kernel 5.2.8-050208-generic and now it seems to work fine. The problems started when I changed from kerneel linux-image- unsigned-4.18.12-041812-generic to linux-image-generic-hwe-18.04 (5.0.0.23.80). -- You received this bug

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-10 Thread granjerox
I've just faced this crash UptoDate me@nuc:~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 18.04.3 LTS Release:18.04 Codename: bionic Aug 10 16:14:47 nuc kernel: [12755.073641] detected buffer overflow in strcat Aug 10 16:14:47 nuc

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-09 Thread Connor Kuehl
Hi Guilherme, Apologies if I missed it, but could you elaborate on the issues you're experiencing with the Disco kernel that are preventing you from verifying this fix? I saw in an earlier comment you were waiting for 5.0.0-24 but that kernel should be available in -updates now. Thanks, Connor

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-08 Thread Guilherme G. Piccoli
You're very welcome Christoph, thanks for the patch! I've verified that with Bionic, but facing some non-related issues with Disco kernel (5.x). Cheers, Guilherme -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-08 Thread Christoph Probst
Hi Guilherme, I haven't been able to verify the patch as we modified our computing pipeline to remove load from the cifs share. I might be able to create a test setup but this will take some time. Thank you for your support to get the patch into the Ubuntu kernels. I subscribed to #1795659 as

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-08-07 Thread Ubuntu Kernel Bot
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed- xenial' to 'verification-done-xenial'. If the problem still exists, change the tag

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-07-31 Thread Guilherme G. Piccoli
I've validated the -proposed kernel for Bionic (4.15.0-56) using the xfstests suite mentioned in the description - couldn't validate Disco yet due to its respin (we need to wait until 5.0.0-24 in order to validate in Disco).The same amount of tests failed in both cases, and no significant

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-07-25 Thread Ubuntu Kernel Bot
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed- bionic' to 'verification-done-bionic'. If the problem still exists, change the tag

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-07-25 Thread Ubuntu Kernel Bot
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed- disco' to 'verification-done-disco'. If the problem still exists, change the tag

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-07-24 Thread Brad Figg
** Tags added: cscc -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1824981 Title: cifs set_oplock buffer overflow in strcat Status in linux package in Ubuntu: Fix Released Status in

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-07-18 Thread Khaled El Mously
** Changed in: linux (Ubuntu Bionic) Status: In Progress => Fix Committed ** Changed in: linux (Ubuntu Disco) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-07-18 Thread Guilherme G. Piccoli
SRU sent to kernel-team mailing list: https://lists.ubuntu.com/archives /kernel-team/2019-July/102357.html -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1824981 Title: cifs set_oplock

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-07-17 Thread Guilherme G. Piccoli
** Description changed: [Impact] * We got reports of a kernel crash in cifs module with the following signature: detected buffer overflow in strcat kernel BUG at <...>/lib/string.c:1052! invalid opcode: [#1] SMP PTI RIP: 0010:fortify_panic+0x13/0x1f Call Trace: -

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-07-17 Thread Guilherme G. Piccoli
** Description changed: - Ubuntu 18.04.2 LTS - Linux SRV013 4.15.0-47-generic #50-Ubuntu SMP Wed Mar 13 10:44:52 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux + [Impact] - DELL R740, 2 CPU (40 Cores, 80 Threads), 384 GiB RAM + * We got reports of a kernel crash in cifs module with the following +

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-07-16 Thread Guilherme G. Piccoli
** Changed in: linux (Ubuntu Cosmic) Status: In Progress => Won't Fix -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1824981 Title: cifs set_oplock buffer overflow in strcat

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-05-23 Thread Guilherme G. Piccoli
Hi Christoph, thank you very much for your work in this LP! Both the debug part and finally your patch. I was looking the same set of issues in parallel, with another user that reported the same crashes. So, regarding your question in comment #15 ("are those gonna be backportet to 4.x-generic?"),

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-05-23 Thread Guilherme G. Piccoli
** Also affects: linux (Ubuntu Cosmic) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Eoan) Importance: Undecided Assignee: Christoph Probst (christophprobst) Status: Fix Released ** Also affects: linux (Ubuntu Bionic) Importance: Undecided

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-05-22 Thread Guilherme G. Piccoli
** Tags added: sts -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1824981 Title: cifs set_oplock buffer overflow in strcat Status in linux package in Ubuntu: Fix Released Bug

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-05-08 Thread Christoph Probst
Yes, there are two issues that got mixed up in this single bug report. 1) strcat Imho there are not many ways strcat could overflow in that single function. My patch (especially the strncpy()) should fix the buffer overflow and thereby my inititial issue. Your solution still had that strcat

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-05-08 Thread Kai-Heng Feng
Sorry for not following up here, I've been quite busy recently. So there are two bugs here - the first one, strcat overflow, is solved by my test kernel or by your patch. Though I am not sure it's totally correct, I'll raise my concern on mailing list. The second bug, null pointer dereference,

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-05-08 Thread Christoph Probst
From: Steve French Date: Tue, 7 May 2019 11:13:34 -0500 merged into cifs-2.6.git for-next ** Changed in: linux (Ubuntu) Status: Fix Committed => Fix Released ** Changed in: linux (Ubuntu) Assignee: (unassigned) => Christoph Probst (christophprobst) -- You received this bug

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-05-06 Thread Christoph Probst
There is now a kernel patch for cifs that is supposed to fix the buffer overflow in strcat. Details see https://patchwork.kernel.org/patch/10931327/ An alternative workaround is to downgrade the connection to SMB2 (mount option vers=2.0) as the bug only affects SMB2.1 and SMB3 code. Regarding

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-05-01 Thread Christoph Probst
We installed the latest upstream kernel 5.1.0-050100rc7-generic (Ubuntu version from https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.1-rc7/) with still triggers a NULL pointer dereference from cifsoplockd. I was hoping "CIFS: keep FileInfo handle live during oplock break"[1] might fix our

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-30 Thread Christoph Probst
And now a crash with the special 4.15.0-48-generic #51~lp1824981 kernel. So the buffer overflow is NOT fixed with any 4.15 or 4.18 kernel currently available with Ubuntu. We started some IO-intense tasks lately that didn't run the last 2 weeks. That seems to be the trigger for the bug buffer

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-29 Thread Christoph Probst
Oh no. Had a strcat buffer overflow with 4.15.0-48-generic. Issue is NOT solved. Apr 29 19:29:00 kernel: [78713.491646] detected buffer overflow in strcat Apr 29 19:29:00 kernel: [78713.491685] [ cut here ] Apr 29 19:29:00 kernel: [78713.491686] kernel BUG at

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-29 Thread Christoph Probst
4.15.0.47-generic kernel BUG at /build/linux-6ZmFRN/linux-4.15.0/lib/string.c:1052! Crashes system (requires hard reboot or SysRQ+b) 4.18.0-17-generic kernel BUG at /build/linux-hwe-4PejID/linux-hwe-4.18.0/lib/string.c:1052! Crashes system (requires hard reboot or SysRQ+b) 4.15.0-48-generic

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-24 Thread Christoph Probst
Actually there is one waiting in state flush_work, one in call_rwsem_down_read_failed and 12 in call_rwsem_down_write_failed. The "flush_work" task call trace genesplicer D0 53332 52566 0x Call Trace: __schedule+0x291/0x8a0 ? __switch_to_asm+0x40/0x70 ?

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-24 Thread Christoph Probst
The "NULL pointer dereference" bug create state D pocesses waiting in call_rwsem_down_write_failed. [ +0.000341] genesplicer D0 53349 52579 0x8000 [ +0.000362] Call Trace: [ +0.000346] __schedule+0x291/0x8a0 [ +0.000348] ? mempool_free+0x2f/0x90 [ +0.000347]

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-24 Thread Christoph Probst
Yes, it happend once with 4.18.0-17 (see kernel.log below) and once with 4.15.0-48. Haven't seen this one on 4.15.0-46-generic or 4.15.0-47-generic before. Apr 17 18:51:53 Linux version 4.18.0-17-generic (buildd@lgw01-amd64-021) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #18~18.04.1-Ubuntu

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-23 Thread Kai-Heng Feng
Does this also happen on 4.18.0-17? Apr 22 23:40:47 BUG: unable to handle kernel NULL pointer dereference at 0038 Apr 22 23:40:47 IP: smb2_push_mandatory_locks+0x104/0x3b0 [cifs] -- You received this bug notification because you are a member of Kernel Packages, which is subscribed

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-23 Thread Christoph Probst
New variant of kernel bug appeard in both 4.18.0-17 (package manager) and in 4.15.0-48 (provided by @kaihengfeng). System didn't crash (compared to "buffer overflow in strcat" where cifs can't recover). Have seen this one twice, both within 3-7 hours after reboot. Apr 22 17:28:23 Linux version

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-20 Thread Christoph Probst
Here are some details from proc what is happening on our servers. Both running 4.15.0-47-generic. server13 / uptime 2 days # cat /proc/fs/cifs/Stats Resources in use CIFS Session: 1 Share (unique mount targets): 2 SMB Request/Response Buffer: 1 Pool size: 5 SMB Small Req/Resp Buffer: 1 Pool size:

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-20 Thread Christoph Probst
I tried Ubuntu kernel "4.18.0-17-generic #18~18.04.1-Ubuntu". Crashed the same way on high load as the 4.15.0-47 does. Now testing 4.15.0-48 from Kai-Heng. Still haven't found the trigger for that bug. Seems to be load related - we're having five servers each running many threads

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-18 Thread Kai-Heng Feng
Please test this kernel: https://people.canonical.com/~khfeng/lp1824981/ -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1824981 Title: cifs set_oplock buffer overflow in strcat Status

[Kernel-packages] [Bug 1824981] Re: cifs set_oplock buffer overflow in strcat

2019-04-18 Thread You-Sheng Yang
Seems there is already a discussion thread on Linux-CIFS: https://lore.kernel.org/linux- cifs/cadjhv_utw3yi1ujrvde_kkrf4gnjwnup1tuzuihcefzbo7h...@mail.gmail.com/T/ -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.