[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-10 Thread James Hunt
The problem is not observed when the only connections to upstart are the standard upstart bridges (since they use nih_dbus_connect()). For reference, here is nih_dbus_setup() which includes one or more calls that unity seemingly should be calling itself: http://bazaar.launchpad.net/~ubuntu-

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-10 Thread James Hunt
This problem can now be demonstrated with a single connection to upstart that makes the following calls: dbus_connection_open() nih_dbus_proxy_new () The problem is not seen if the app instead calls: - nih_dbus_connect (upstart_session, disconnect_handler) -

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-10 Thread Launchpad Bug Tracker
** Branch linked: lp:~vorlon/unity8/lp.1235649 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1235649 Title: uevent spam causes session upstart to consume massive amounts of memory on

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-10 Thread James Hunt
C program to trigger this bug. Run it in an environment with UPSTART_SESSION set (such as a desktop/Touch environment), then run the about-to-be attached spam.sh script. ** Attachment added: trigger-bug-1235649.c

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-10 Thread James Hunt
Run as: $ spam.sh session_init_pid ** Attachment added: spam.sh https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1235649/+attachment/3872619/+files/spam.sh -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-10 Thread James Hunt
Program attached in #51 demonstrates the incorrect calling behaviour. To demonstrate the correct behaviour change the #if0/else/endif such that rather than calling dbus_connection_open(), the program calls nih_dbus_connect(). nih_dbus_connect(): No memory growth. dbus_connection_open(): Memory

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread James Hunt
Persistent D-Bus connections are as expected (1 / bridge and 1 for unity-panel-service). Ephemeral D-Bus connections are being handled correctly and removed from the control_conns list. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread James Hunt
Still unclear why memory is being cached in Upstart address space, but I'm starting to think this might be a libdbus issue. What is triggering the memory rise though is unity-panel-service: stopping this from running results in no memory increase within the Session Init. ** Also affects: unity

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread Oliver Grawert
note that touch images do not use unity-panel-service anywhere -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1235649 Title: uevent spam causes session upstart to consume massive

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/upstart -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1235649 Title: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread James Hunt
Right - recall that I am testing on i386 as I don't have mako/maguro :) However, note that on Touch, the upstart code in unity8 (plugins/Unity/Indicators/indicatorsmanager.cpp) is almost identical to the upstart code in unity-panel-service (unity/services/panel- service.c). Is it possible to

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread James Hunt
Re #41, interesting that unity-panel-service *is* installed on Touch image though :) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1235649 Title: uevent spam causes session upstart to

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread MichaƂ Sawicz
The above can be applied straight on device, in /usr/share/unity8/. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1235649 Title: uevent spam causes session upstart to consume massive

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread Steve Langasek
Workaround is in place in upstart package to reduce the flood of events that are causing this rapid memory growth, and we believe a fix to the unity upstart client will fix the memory leak entirely; but upstart needs to be more robust against misbehaving clients. Opening a task against upstart

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread Steve Langasek
** Also affects: upstart Importance: Undecided Status: New -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1235649 Title: uevent spam causes session upstart to consume massive

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread Launchpad Bug Tracker
This bug was fixed in the package upstart - 1.10-0ubuntu7 --- upstart (1.10-0ubuntu7) saucy; urgency=low * Ignore emitting specific udev event spam on maguro, as a workaround for LP: #1235649. -- Dmitrijs Ledkovs dmitrij.led...@ubuntu.com Wed, 09 Oct 2013 13:52:10 +0100 **

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-09 Thread Joseph Salisbury
** Changed in: linux (Ubuntu Saucy) Status: Incomplete = Invalid -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1235649 Title: uevent spam causes session upstart to consume

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-08 Thread Joseph Salisbury
** Changed in: linux (Ubuntu Saucy) Status: Confirmed = Incomplete ** Tags removed: kernel-key ** Tags added: kernel-da-key -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1235649

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-08 Thread Dmitrijs Ledkovs
After discussion on irc between ogra, pitti and I: workaround #1 - blacklist that uevent in upstart-udev-bridge, thus neither system init event will not be emitted, nor re-emitted to session upstart. workaround #2 - blacklist that uevent in systemd-udev (via socket filter) if not needed by Mir.

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-08 Thread James Hunt
The problem is triggered by init/control.c:control_emit_event_emitted(). It looks like Upstart itself is clearing up memory, but either dbus isn't, or upstart is missing a dbus unref call. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-08 Thread James Hunt
The working theory at this stage is that init/control.c:control_disconnected() is not cleaning up the dbus connections created by the upstart-udev-bridge for each event it requests upstart emit. -- You received this bug notification because you are a member of Kernel Packages, which is

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-08 Thread James Hunt
init/control.c:control_disconnected() could do with a call to dbus_connection_close(), but each connection is being unref'd correctly fwics. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.

[Kernel-packages] [Bug 1235649] Re: uevent spam causes session upstart to consume massive amounts of memory on Ubuntu Touch

2013-10-08 Thread James Hunt
To be clear, adding a call to dbus_connection_close() in control_disconnected() did not resolve the problem. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1235649 Title: uevent spam