[Kernel-packages] [Bug 1248949] Re: [PATCH] ALSA: hda - Add multifunction jack support for ALC255

2013-11-08 Thread David Henningsson
On 11/08/2013 09:19 AM, Kailang wrote: Hi David, I modified as attach patch. It included coef_idx to use coefex_idx. BR, Kailang Thanks! @Takashi, does this new patch look good enough for you? Hi Kailang, It does not matter. Choose what works best for you and I'll sort it out

[Kernel-packages] [Bug 1248949] Re: [PATCH] ALSA: hda - Add multifunction jack support for ALC255

2013-11-08 Thread Takashi Iwai
At Fri, 08 Nov 2013 11:10:48 +0100, David Henningsson wrote: On 11/08/2013 09:19 AM, Kailang wrote: Hi David, I modified as attach patch. It included coef_idx to use coefex_idx. BR, Kailang Thanks! @Takashi, does this new patch look good enough for you? Yes, I applied it

[Kernel-packages] [Bug 1248949] Re: [PATCH] ALSA: hda - Add multifunction jack support for ALC255

2013-11-07 Thread Takashi Iwai
At Thu, 7 Nov 2013 14:08:41 +0100, David Henningsson wrote: From: Kailang Yang kail...@realtek.com The new codec ALC255 needs its own set of verbs to enable multifunction jacks. (Context and whitespace adjustments by David Henningsson) BugLink: https://bugs.launchpad.net/bugs/1248949

[Kernel-packages] [Bug 1248949] Re: [PATCH] ALSA: hda - Add multifunction jack support for ALC255

2013-11-07 Thread David Henningsson
Hi, I can certainly rewrite coef_idx to use coefef_idx (I think that's a good idea), but for the comments, I know as little as you do about these verbs. Kailang, is it possible for you to add more comments to your patch so it can be applied upstream? Thanks, David On 11/07/2013 02:22 PM,

[Kernel-packages] [Bug 1248949] Re: [PATCH] ALSA: hda - Add multifunction jack support for ALC255

2013-11-07 Thread David Henningsson
Hi Kailang, It does not matter. Choose what works best for you and I'll sort it out before sending to Takashi. // David On 11/08/2013 06:48 AM, Kailang wrote: Hi David, Could I add commemts for belowing context? Or I create new patch for it. BR, Kailang Hi, I can certainly rewrite