[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
*** This bug is a duplicate of bug 1805245 *** https://bugs.launchpad.net/bugs/1805245 Just fyi, this bug is marked as a duplicate of bug 1805245 and with that no longer updated itself. Work was spent on bug 1805245 and it got Fix Released (for bionic), see: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805245 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Incomplete Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: Fix Released Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
*** This bug is a duplicate of bug 1805245 *** https://bugs.launchpad.net/bugs/1805245 ** Tags added: cscc -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Incomplete Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: Fix Released Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
*** This bug is a duplicate of bug 1805245 *** https://bugs.launchpad.net/bugs/1805245 ** This bug has been marked a duplicate of bug 1805245 powerpc/powernv/pci: Work around races in PCI bridge enabling -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Incomplete Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: Fix Released Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
** Changed in: linux (Ubuntu) Assignee: Joseph Salisbury (jsalisbury) => Canonical Kernel Team (canonical-kernel-team) ** Changed in: linux (Ubuntu Xenial) Assignee: Joseph Salisbury (jsalisbury) => Canonical Kernel Team (canonical-kernel-team) ** Changed in: linux (Ubuntu Bionic) Assignee: Joseph Salisbury (jsalisbury) => Canonical Kernel Team (canonical-kernel-team) ** Changed in: linux (Ubuntu Cosmic) Assignee: Joseph Salisbury (jsalisbury) => Canonical Kernel Team (canonical-kernel-team) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Incomplete Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: Fix Released Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
Marking as Incomplete while awaiting feedback on testing status. ** Changed in: ubuntu-power-systems Status: In Progress => Incomplete -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Incomplete Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: Fix Released Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
@Mike, do you feel comfortable with the testing you've done to submit an SRU request? Or would you like to perform some additional testing? ** Changed in: linux (Ubuntu Cosmic) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: In Progress Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: Fix Released Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
** Changed in: ubuntu-power-systems Status: Triaged => In Progress -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: In Progress Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: In Progress Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
** Changed in: linux (Ubuntu) Status: Incomplete => In Progress ** Changed in: linux (Ubuntu Xenial) Status: Incomplete => In Progress ** Changed in: linux (Ubuntu Bionic) Status: Incomplete => In Progress ** Changed in: linux (Ubuntu Cosmic) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Triaged Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: In Progress Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
** Changed in: ubuntu-power-systems Status: Incomplete => Triaged -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Triaged Status in linux package in Ubuntu: Incomplete Status in linux source package in Xenial: Incomplete Status in linux source package in Bionic: Incomplete Status in linux source package in Cosmic: Incomplete Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
I've tried this on two systems and tried some different testing - I can't recreate the original problem that is is intermittent and can require quite a few devices, but I did not see any regressions. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Incomplete Status in linux package in Ubuntu: Incomplete Status in linux source package in Xenial: Incomplete Status in linux source package in Bionic: Incomplete Status in linux source package in Cosmic: Incomplete Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
** Changed in: linux (Ubuntu) Status: In Progress => Incomplete ** Changed in: linux (Ubuntu Xenial) Status: In Progress => Incomplete ** Changed in: linux (Ubuntu Bionic) Status: In Progress => Incomplete ** Changed in: linux (Ubuntu Cosmic) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Incomplete Status in linux package in Ubuntu: Incomplete Status in linux source package in Xenial: Incomplete Status in linux source package in Bionic: Incomplete Status in linux source package in Cosmic: Incomplete Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
IBM is currently testing the test kernel from the PPA referred to in comment #2. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Incomplete Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: In Progress Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
** Changed in: ubuntu-power-systems Status: In Progress => Incomplete -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: Incomplete Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: In Progress Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
IBM, could you please verify the PPA test kernels provided by the kernel team, and report back here. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: In Progress Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: In Progress Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
I also built a Xenial test kernel with commit db2173198b9513f7add8009f225afa1f1c79bcc6, since it was requested in bug 1788850. That bug is now marked as a duplicate of this bug. The Xenial test kernel is available from: http://kernel.ubuntu.com/~jsalisbury/lp1788549/xenial -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: In Progress Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: In Progress Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
** Also affects: linux (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: linux (Ubuntu Xenial) Status: New => In Progress ** Changed in: linux (Ubuntu Xenial) Importance: Undecided => Critical ** Changed in: linux (Ubuntu Xenial) Assignee: (unassigned) => Joseph Salisbury (jsalisbury) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: In Progress Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: In Progress Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
** Changed in: ubuntu-power-systems Status: New => In Progress -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: In Progress Status in linux package in Ubuntu: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: In Progress Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
I built a test kernel with commit db2173198b95. The test kernel can be downloaded from: http://kernel.ubuntu.com/~jsalisbury/lp1788549 Can you test this kernel and see if it resolves this bug? Note about installing test kernels: • If the test kernel is prior to 4.15(Bionic) you need to install the linux-image and linux-image-extra .deb packages. • If the test kernel is 4.15(Bionic) or newer, you need to install the linux-modules, linux-modules-extra and linux-image-unsigned .deb packages. Thanks in advance! -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: New Status in linux package in Ubuntu: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: In Progress Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
** Also affects: linux (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Cosmic) Importance: Undecided Assignee: Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) Status: New ** Changed in: linux (Ubuntu Bionic) Status: New => In Progress ** Changed in: linux (Ubuntu Cosmic) Status: New => In Progress ** Changed in: linux (Ubuntu Bionic) Importance: Undecided => Critical ** Changed in: linux (Ubuntu Cosmic) Importance: Undecided => Critical ** Changed in: linux (Ubuntu Bionic) Assignee: (unassigned) => Joseph Salisbury (jsalisbury) ** Changed in: linux (Ubuntu Cosmic) Assignee: Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) => Joseph Salisbury (jsalisbury) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: New Status in linux package in Ubuntu: In Progress Status in linux source package in Bionic: In Progress Status in linux source package in Cosmic: In Progress Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1788549] Re: powerpc/powernv/pci: Work around races in PCI bridge enabling
** Also affects: ubuntu-power-systems Importance: Undecided Status: New ** Changed in: ubuntu-power-systems Assignee: (unassigned) => Canonical Kernel Team (canonical-kernel-team) ** Changed in: ubuntu-power-systems Importance: Undecided => Critical ** Tags added: triage-g ** Package changed: kernel-package (Ubuntu) => linux (Ubuntu) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1788549 Title: powerpc/powernv/pci: Work around races in PCI bridge enabling Status in The Ubuntu-power-systems project: New Status in linux package in Ubuntu: New Bug description: == Comment: #0 - Michael Ranweiler - 2018-08-21 13:52:03 == +++ This bug was initially created as a clone of Bug #170766 +++ Please apply the following kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next=db2173198b9513f7add8009f225afa1f1c79bcc6 powerpc/powernv/pci: Work around races in PCI bridge enabling The generic code is racy when multiple children of a PCI bridge try to enable it simultaneously. This leads to drivers trying to access a device through a not-yet-enabled bridge, and this EEH errors under various circumstances when using parallel driver probing. There is work going on to fix that properly in the PCI core but it will take some time. x86 gets away with it because (outside of hotplug), the BIOS enables all the bridges at boot time. This patch does the same thing on powernv by enabling all bridges that have child devices at boot time, thus avoiding subsequent races. It's suitable for backporting to stable and distros, while the proper PCI fix will probably be significantly more invasive. Signed-off-by: Benjamin Herrenschmidt Cc: sta...@vger.kernel.org Signed-off-by: Michael Ellerman == Comment: #2 - Michael Ranweiler - 2018-08-21 18:23:35 == This has some fuzz and also move it back from the pci macro to dev_err so we'll attach the backported patch. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1788549/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
