Public bug reported:
[Impact]
Can't wake up by touching the touchpad.
[Fix]
1.gpio: With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")'
gpiolib overrides irqchip's irq_enable and irq_disable callbacks. If
irq_disable
callback is implemented then genirq takes unlazy path to disable irq.
Underlying irqchip
may not want to implement irq_disable callback to lazy disable irq
when client drivers invokes disable_irq(). By overriding irq_disable
callback,
gpiolib ends up always unlazy disabling IRQ.
Allow gpiolib to lazy disable IRQs by overriding irq_disable callback only
if irqchip implemented irq_disable. In cases where irq_disable is not
implemented irq_mask is overridden. Similarly override irq_enable callback
only if irqchip implemented irq_enable otherwise irq_unmask is overridden.
2. hid: Many laptops can be woken up from Suspend-to-Idle by touchpad. This is
also the default behavior on other OSes.
However, if touchpad and touchscreen contact to each other when lid is
closed, wakeup events can be triggered inadventertly.
So let's disable the wakeup by default, but enable the wakeup capability
so users can enable it at their own discretion.
[test]
With the patch and enable HID's power/wakeup, the system can wake up by
touching the touchpad.
[Regression Potential]
Low. The two patches are already landed in the upstream.
** Affects: linux-oem-5.6 (Ubuntu)
Importance: Undecided
Status: New
** Affects: linux-oem-5.6 (Ubuntu Focal)
Importance: Undecided
Assignee: koba (kobako)
Status: In Progress
** Package changed: linux (Ubuntu) => linux-oem-5.6 (Ubuntu)
** Also affects: linux-oem-5.6 (Ubuntu Focal)
Importance: Undecided
Status: New
** Changed in: linux-oem-5.6 (Ubuntu Focal)
Assignee: (unassigned) => koba (kobako)
** Changed in: linux-oem-5.6 (Ubuntu Focal)
Status: New => In Progress
** Summary changed:
- Touchpad cannot wakeup the system Edit
+ Touchpad cannot wakeup the system
** Summary changed:
- Touchpad cannot wakeup the system
+ Wakeup the system by touching the touchpad
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1888331
Title:
Wakeup the system by touching the touchpad
Status in linux-oem-5.6 package in Ubuntu:
New
Status in linux-oem-5.6 source package in Focal:
In Progress
Bug description:
[Impact]
Can't wake up by touching the touchpad.
[Fix]
1.gpio: With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")'
gpiolib overrides irqchip's irq_enable and irq_disable callbacks. If
irq_disable
callback is implemented then genirq takes unlazy path to disable irq.
Underlying irqchip
may not want to implement irq_disable callback to lazy disable irq
when client drivers invokes disable_irq(). By overriding irq_disable
callback,
gpiolib ends up always unlazy disabling IRQ.
Allow gpiolib to lazy disable IRQs by overriding irq_disable callback only
if irqchip implemented irq_disable. In cases where irq_disable is not
implemented irq_mask is overridden. Similarly override irq_enable callback
only if irqchip implemented irq_enable otherwise irq_unmask is overridden.
2. hid: Many laptops can be woken up from Suspend-to-Idle by touchpad. This is
also the default behavior on other OSes.
However, if touchpad and touchscreen contact to each other when lid is
closed, wakeup events can be triggered inadventertly.
So let's disable the wakeup by default, but enable the wakeup capability
so users can enable it at their own discretion.
[test]
With the patch and enable HID's power/wakeup, the system can wake up by
touching the touchpad.
[Regression Potential]
Low. The two patches are already landed in the upstream.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-oem-5.6/+bug/1888331/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
