[Kernel-packages] [Bug 1889625] Re: Bug fix for ktls feature
Marking this invalid. While I was working on it, it was already resolved by an upstream sync and handled by this bug: https://bugs.launchpad.net/kernel-sru-workflow/+bug/1893050 ** Changed in: linux (Ubuntu) Status: In Progress => Invalid ** Changed in: linux (Ubuntu Focal) Status: In Progress => Invalid -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1889625 Title: Bug fix for ktls feature Status in linux package in Ubuntu: Invalid Status in linux source package in Focal: Invalid Bug description: [IMPACT] Clearing the sock TX queue in sk_set_socket() might cause unexpected out-of-order transmit when called from sock_orphan(), as outstanding packets can pick a different TX queue and bypass the ones already queued. This is undesired in general. More specifically, it breaks the in-order scheduling property guarantee for device-offloaded TLS sockets. Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it explicitly only where needed. [FIXES] e022f0b4a03f "net: Introduce sk_tx_queue_mapping" This cleanly cherry picks into 5.4 from 5.8. It can be checked out in my branch here: https://git.launchpad.net/~bladernr/ubuntu/+source/linux/+git/focal 1889625-mxl-ktls-bugfix [REGRESSION RISK] low! [TEST] reproducing the bug is not trivial. in general terms: nic: ConnectX6-dx with crypto enabled send intense encrypted tcp traffic with tls offload between many clients and one server. * clients may run on the same machine. * clients continuously opens and closes connection to server at some point decryption errores might arise on some of the clients. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1889625/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1889625] Re: Bug fix for ktls feature
** Description changed: [IMPACT] Clearing the sock TX queue in sk_set_socket() might cause unexpected out-of-order transmit when called from sock_orphan(), as outstanding packets can pick a different TX queue and bypass the ones already queued. This is undesired in general. More specifically, it breaks the in-order scheduling property guarantee for device-offloaded TLS sockets. Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it explicitly only where needed. - [FIXES] e022f0b4a03f "net: Introduce sk_tx_queue_mapping" This cleanly cherry picks into 5.4 from 5.8. It can be checked out in my branch here: https://git.launchpad.net/~bladernr/ubuntu/+source/linux/+git/focal 1889625-mxl-ktls-bugfix [REGRESSION RISK] - + low! [TEST] + reproducing the bug is not trivial. in general terms: + nic: ConnectX6-dx with crypto enabled + send intense encrypted tcp traffic with tls offload between many clients and one server. + * clients may run on the same machine. + * clients continuously opens and closes connection to server + + at some point decryption errores might arise on some of the clients. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1889625 Title: Bug fix for ktls feature Status in linux package in Ubuntu: In Progress Status in linux source package in Focal: In Progress Bug description: [IMPACT] Clearing the sock TX queue in sk_set_socket() might cause unexpected out-of-order transmit when called from sock_orphan(), as outstanding packets can pick a different TX queue and bypass the ones already queued. This is undesired in general. More specifically, it breaks the in-order scheduling property guarantee for device-offloaded TLS sockets. Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it explicitly only where needed. [FIXES] e022f0b4a03f "net: Introduce sk_tx_queue_mapping" This cleanly cherry picks into 5.4 from 5.8. It can be checked out in my branch here: https://git.launchpad.net/~bladernr/ubuntu/+source/linux/+git/focal 1889625-mxl-ktls-bugfix [REGRESSION RISK] low! [TEST] reproducing the bug is not trivial. in general terms: nic: ConnectX6-dx with crypto enabled send intense encrypted tcp traffic with tls offload between many clients and one server. * clients may run on the same machine. * clients continuously opens and closes connection to server at some point decryption errores might arise on some of the clients. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1889625/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1889625] Re: Bug fix for ktls feature
** Description changed:
- The bellow upstream commit fixes a bug in Ktls feature.
- It is applied cleanly above the ubuntu-focal tree and passed basic sanity
testing.
- We would like it to be backported ubuntu-focal
- Thanks,
- Amir
+ [IMPACT]
- commit 41b14fb8724d5a4b382a63cb4a1a61880347ccb8
- Author: Tariq Toukan
- Date: Mon Jun 22 23:26:04 2020 +0300
+ Clearing the sock TX queue in sk_set_socket() might cause unexpected
+ out-of-order transmit when called from sock_orphan(), as outstanding
+ packets can pick a different TX queue and bypass the ones already queued.
- net: Do not clear the sock TX queue in sk_set_socket()
-
- Clearing the sock TX queue in sk_set_socket() might cause unexpected
- out-of-order transmit when called from sock_orphan(), as outstanding
- packets can pick a different TX queue and bypass the ones already queued.
-
- This is undesired in general. More specifically, it breaks the in-order
- scheduling property guarantee for device-offloaded TLS sockets.
-
- Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it
- explicitly only where needed.
-
- Fixes: e022f0b4a03f ("net: Introduce sk_tx_queue_mapping")
- Signed-off-by: Tariq Toukan
- Reviewed-by: Boris Pismenny
- Signed-off-by: David S. Miller
+ This is undesired in general. More specifically, it breaks the in-order
+ scheduling property guarantee for device-offloaded TLS sockets.
+
+ Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it
+ explicitly only where needed.
+
+
+ [FIXES]
+
+ e022f0b4a03f "net: Introduce sk_tx_queue_mapping"
+
+ This cleanly cherry picks into 5.4 from 5.8.
+
+ It can be checked out in my branch here:
+
+ https://git.launchpad.net/~bladernr/ubuntu/+source/linux/+git/focal
+ 1889625-mxl-ktls-bugfix
+
+ [REGRESSION RISK]
+
+
+ [TEST]
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1889625
Title:
Bug fix for ktls feature
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Focal:
In Progress
Bug description:
[IMPACT]
Clearing the sock TX queue in sk_set_socket() might cause unexpected
out-of-order transmit when called from sock_orphan(), as outstanding
packets can pick a different TX queue and bypass the ones already queued.
This is undesired in general. More specifically, it breaks the in-order
scheduling property guarantee for device-offloaded TLS sockets.
Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it
explicitly only where needed.
[FIXES]
e022f0b4a03f "net: Introduce sk_tx_queue_mapping"
This cleanly cherry picks into 5.4 from 5.8.
It can be checked out in my branch here:
https://git.launchpad.net/~bladernr/ubuntu/+source/linux/+git/focal
1889625-mxl-ktls-bugfix
[REGRESSION RISK]
[TEST]
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1889625/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1889625] Re: Bug fix for ktls feature
** Changed in: linux (Ubuntu Focal)
Status: New => In Progress
** Changed in: linux (Ubuntu Focal)
Importance: Undecided => Medium
** Changed in: linux (Ubuntu Focal)
Assignee: (unassigned) => Jeff Lane (bladernr)
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1889625
Title:
Bug fix for ktls feature
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Focal:
In Progress
Bug description:
The bellow upstream commit fixes a bug in Ktls feature.
It is applied cleanly above the ubuntu-focal tree and passed basic sanity
testing.
We would like it to be backported ubuntu-focal
Thanks,
Amir
commit 41b14fb8724d5a4b382a63cb4a1a61880347ccb8
Author: Tariq Toukan
Date: Mon Jun 22 23:26:04 2020 +0300
net: Do not clear the sock TX queue in sk_set_socket()
Clearing the sock TX queue in sk_set_socket() might cause unexpected
out-of-order transmit when called from sock_orphan(), as outstanding
packets can pick a different TX queue and bypass the ones already queued.
This is undesired in general. More specifically, it breaks the in-order
scheduling property guarantee for device-offloaded TLS sockets.
Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it
explicitly only where needed.
Fixes: e022f0b4a03f ("net: Introduce sk_tx_queue_mapping")
Signed-off-by: Tariq Toukan
Reviewed-by: Boris Pismenny
Signed-off-by: David S. Miller
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1889625/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1889625] Re: Bug fix for ktls feature
** Changed in: linux (Ubuntu)
Status: Incomplete => In Progress
** Changed in: linux (Ubuntu)
Importance: Undecided => Medium
** Changed in: linux (Ubuntu)
Assignee: (unassigned) => Jeff Lane (bladernr)
** Also affects: linux (Ubuntu Focal)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1889625
Title:
Bug fix for ktls feature
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Focal:
New
Bug description:
The bellow upstream commit fixes a bug in Ktls feature.
It is applied cleanly above the ubuntu-focal tree and passed basic sanity
testing.
We would like it to be backported ubuntu-focal
Thanks,
Amir
commit 41b14fb8724d5a4b382a63cb4a1a61880347ccb8
Author: Tariq Toukan
Date: Mon Jun 22 23:26:04 2020 +0300
net: Do not clear the sock TX queue in sk_set_socket()
Clearing the sock TX queue in sk_set_socket() might cause unexpected
out-of-order transmit when called from sock_orphan(), as outstanding
packets can pick a different TX queue and bypass the ones already queued.
This is undesired in general. More specifically, it breaks the in-order
scheduling property guarantee for device-offloaded TLS sockets.
Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it
explicitly only where needed.
Fixes: e022f0b4a03f ("net: Introduce sk_tx_queue_mapping")
Signed-off-by: Tariq Toukan
Reviewed-by: Boris Pismenny
Signed-off-by: David S. Miller
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1889625/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
