[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-09-15 Thread Launchpad Bug Tracker
This bug was fixed in the package linux - 5.13.0-16.16

---
linux (5.13.0-16.16) impish; urgency=medium

  * impish/linux: 5.13.0-16.16 -proposed tracker (LP: #1942611)

  * Miscellaneous Ubuntu changes
- [Config] update toolchain in configs

  * Miscellaneous upstream changes
- Revert "UBUNTU: [Config] Enable CONFIG_UBSAN_BOUNDS"

 -- Andrea Righi   Fri, 03 Sep 2021 16:21:14
+0200

** Changed in: linux (Ubuntu Impish)
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1935040

Title:
  dev_forward_skb: do not scrub skb mark within the same name space

Status in linux package in Ubuntu:
  Fix Released
Status in linux source package in Bionic:
  Fix Released
Status in linux source package in Focal:
  Fix Released
Status in linux source package in Hirsute:
  Fix Released
Status in linux source package in Impish:
  Fix Released

Bug description:
  [Impact]

  The ebpf function 'bpf_redirect' reset the mark when used with the flag 
BPF_F_INGRESS.
  There are two main problems with that:
   - it's not consistent between legacy tunnels and ebpf;
   - it's not consistent between ingress and egress.

  In fact, the eBPF program can easily reset the mark, but it cannot
  preserve it.

  This kind of patch was already done in the past, see commit
  963a88b31ddb ("tunnels: harmonize cleanup done on skb on xmit path"),
  commit ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx
  path") and commit 213dd74aee76 ("skbuff: Do not scrub skb mark within
  the same name space").

  This is fixed upstream with commit ff70202b2d1a ("dev_forward_skb: do
  not scrub skb mark within the same name space").

  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff70202b2d1a

  [Test Case]

  Mark a packet in the POSTROUTING hook, redirect it to another
  interface and display it with a netfilter log rule to check the mark.

  [Regression Potential]

  A user could expect that the mark is reset after a call to
  bpf_redirect(BPF_F_INGRESS), but he could easily reset it in the eBPF
  program himself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1935040/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-09-07 Thread Launchpad Bug Tracker
This bug was fixed in the package linux - 4.15.0-156.163

---
linux (4.15.0-156.163) bionic; urgency=medium

  * bionic/linux: 4.15.0-156.163 -proposed tracker (LP: #1940162)

  * linux (LP: #1940564)
- SAUCE: Revert "scsi: core: Cap scsi_host cmd_per_lun at can_queue"

  * fails to launch linux L2 guests on AMD (LP: #1940134) // CVE-2021-3653
- KVM: nSVM: avoid picking up unsupported bits from L2 in int_ctl
  (CVE-2021-3653)

  * fails to launch linux L2 guests on AMD (LP: #1940134)
- SAUCE: Revert "UBUNTU: SAUCE: KVM: nSVM: avoid picking up unsupported bits
  from L2 in int_ctl"

linux (4.15.0-155.162) bionic; urgency=medium

  * bionic/linux: 4.15.0-155.162 -proposed tracker (LP: #1939833)

  * Packaging resync (LP: #1786013)
- debian/dkms-versions -- update from kernel-versions (main/2021.08.16)

  * CVE-2021-3656
- SAUCE: KVM: nSVM: always intercept VMLOAD/VMSAVE when nested

  * CVE-2021-3653
- SAUCE: KVM: nSVM: avoid picking up unsupported bits from L2 in int_ctl

  * dev_forward_skb: do not scrub skb mark within the same name space
(LP: #1935040)
- dev_forward_skb: do not scrub skb mark within the same name space

  * 'ptrace trace' needed to readlink() /proc/*/ns/* files on older kernels
(LP: #1890848)
- apparmor: fix ptrace read check

  * Bionic update: upstream stable patchset 2021-08-03 (LP: #1938824)
- ALSA: usb-audio: fix rate on Ozone Z90 USB headset
- media: dvb-usb: fix wrong definition
- Input: usbtouchscreen - fix control-request directions
- net: can: ems_usb: fix use-after-free in ems_usb_disconnect()
- usb: gadget: eem: fix echo command packet response issue
- USB: cdc-acm: blacklist Heimann USB Appset device
- ntfs: fix validity check for file name attribute
- iov_iter_fault_in_readable() should do nothing in xarray case
- Input: joydev - prevent use of not validated data in JSIOCSBTNMAP ioctl
- ARM: dts: at91: sama5d4: fix pinctrl muxing
- btrfs: send: fix invalid path for unlink operations after parent
  orphanization
- btrfs: clear defrag status of a root if starting transaction fails
- ext4: cleanup in-core orphan list if ext4_truncate() failed to get a
  transaction handle
- ext4: fix kernel infoleak via ext4_extent_header
- ext4: correct the cache_nr in tracepoint ext4_es_shrink_exit
- ext4: remove check for zero nr_to_scan in ext4_es_scan()
- ext4: fix avefreec in find_group_orlov
- ext4: use ext4_grp_locked_error in mb_find_extent
- can: gw: synchronize rcu operations before removing gw job entry
- can: peak_pciefd: pucan_handle_status(): fix a potential starvation issue 
in
  TX path
- SUNRPC: Fix the batch tasks count wraparound.
- SUNRPC: Should wake up the privileged task firstly.
- s390/cio: dont call css_wait_for_slow_path() inside a lock
- rtc: stm32: Fix unbalanced clk_disable_unprepare() on probe error path
- iio: ltr501: mark register holding upper 8 bits of ALS_DATA{0,1} and 
PS_DATA
  as volatile, too
- iio: ltr501: ltr559: fix initialization of LTR501_ALS_CONTR
- iio: ltr501: ltr501_read_ps(): add missing endianness conversion
- serial: sh-sci: Stop dmaengine transfer in sci_stop_tx()
- serial_cs: Add Option International GSM-Ready 56K/ISDN modem
- serial_cs: remove wrong GLOBETROTTER.cis entry
- ath9k: Fix kernel NULL pointer dereference during ath_reset_internal()
- ssb: sdio: Don't overwrite const buffer if block_write fails
- rsi: Assign beacon rate settings to the correct rate_info descriptor field
- seq_buf: Make trace_seq_putmem_hex() support data longer than 8
- fuse: check connected before queueing on fpq->io
- spi: Make of_register_spi_device also set the fwnode
- spi: spi-loopback-test: Fix 'tx_buf' might be 'rx_buf'
- spi: spi-topcliff-pch: Fix potential double free in
  pch_spi_process_messages()
- spi: omap-100k: Fix the length judgment problem
- crypto: nx - add missing MODULE_DEVICE_TABLE
- media: cpia2: fix memory leak in cpia2_usb_probe
- media: cobalt: fix race condition in setting HPD
- media: pvrusb2: fix warning in pvr2_i2c_core_done
- crypto: qat - check return code of qat_hal_rd_rel_reg()
- crypto: qat - remove unused macro in FW loader
- media: em28xx: Fix possible memory leak of em28xx struct
- media: v4l2-core: Avoid the dangling pointer in v4l2_fh_release
- media: bt8xx: Fix a missing check bug in bt878_probe
- media: st-hva: Fix potential NULL pointer dereferences
- media: dvd_usb: memory leak in cinergyt2_fe_attach
- mmc: via-sdmmc: add a check against NULL pointer dereference
- crypto: shash - avoid comparing pointers to exported functions under CFI
- media: dvb_net: avoid speculation from net slot
- media: siano: fix device register error path
- btrfs: fix error handling in __btrfs_update_delayed_inode
- btrfs: abort transaction if 

[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-09-07 Thread Launchpad Bug Tracker
This bug was fixed in the package linux - 5.11.0-34.36

---
linux (5.11.0-34.36) hirsute; urgency=medium

  * hirsute/linux: 5.11.0-34.36 -proposed tracker (LP: #1941766)

  * Server boot failure after adding checks for ACPI IRQ override (LP: #1941657)
- Revert "ACPI: resources: Add checks for ACPI IRQ override"

linux (5.11.0-33.35) hirsute; urgency=medium

  * hirsute/linux: 5.11.0-33.35 -proposed tracker (LP: #1940101)

  * libvirtd fails to create VM (LP: #1940107)
- sched: Stop PF_NO_SETAFFINITY from being inherited by various init system
  threads

linux (5.11.0-32.34) hirsute; urgency=medium

  * hirsute/linux: 5.11.0-32.34 -proposed tracker (LP: #1939769)

  * Packaging resync (LP: #1786013)
- debian/dkms-versions -- update from kernel-versions (main/2021.08.16)

  * CVE-2021-3656
- SAUCE: KVM: nSVM: always intercept VMLOAD/VMSAVE when nested

  * CVE-2021-3653
- SAUCE: KVM: nSVM: avoid picking up unsupported bits from L2 in int_ctl

  * [regression] USB device is not detected during boot (LP: #1939638)
- SAUCE: Revert "usb: core: reduce power-on-good delay time of root hub"

  * Support builtin revoked certificates (LP: #1932029)
- [Packaging] build canonical-revoked-certs.pem from branch/arch certs
- [Packaging] Revoke 2012 UEFI signing certificate as built-in
- [Config] Configure CONFIG_SYSTEM_REVOCATION_KEYS with revoked keys

  * Support importing mokx keys into revocation list from the mok table
(LP: #1928679)
- SAUCE: integrity: add informational messages when revoking certs

  * Support importing mokx keys into revocation list from the mok table
(LP: #1928679) // CVE-2020-26541 when certificates are revoked via
MokListXRT.
- SAUCE: integrity: Load mokx certs from the EFI MOK config table

  * Include product_sku info to modalias (LP: #1938143)
- firmware/dmi: Include product_sku info to modalias

  * Fix Ethernet not working by hotplug - RTL8106E (LP: #1930645)
- net: phy: rename PHY_IGNORE_INTERRUPT to PHY_MAC_INTERRUPT
- SAUCE: r8169: Use PHY_POLL when RTL8106E enable ASPM

  * [SRU][H/OEM-5.10/OEM-5.13/U] Fix system hang after unplug tbt dock
(LP: #1938689)
- SAUCE: igc: fix page fault when thunderbolt is unplugged

  * [Regression] Audio card [8086:9d71] not detected after upgrade from linux
5.4 to 5.8 (LP: #1915117)
- [Config] set CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC to y

  * Backlight (screen brightness) on Lenovo P14s AMD Gen2 inop (LP: #1934557)
- drm/amdgpu/display: only enable aux backlight control for OLED panels

  * Touchpad not working with ASUS TUF F15 (LP: #1937056)
- pinctrl: tigerlake: Fix GPIO mapping for newer version of software

  * dev_forward_skb: do not scrub skb mark within the same name space
(LP: #1935040)
- dev_forward_skb: do not scrub skb mark within the same name space

  * Fix display output on HP hybrid GFX laptops (LP: #1936296)
- drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

  * [SRU][OEM-5.10/H] UBUNTU: SAUCE: Fix backlight control on Samsung 16727
panel (LP: #1930527)
- SAUCE: drm/i915: Force DPCD backlight mode for Samsung 16727 panel

  * XPS 9510 (TGL) Screen Brightness could not be changed (LP: #1933566)
- SAUCE: drm/i915: Force DPCD backlight mode for Dell XPS 9510(TGL)

  * [21.10 FEAT] KVM: Provide a secure guest indication (LP: #1933173)
- s390/uv: add prot virt guest/host indication files
- s390/uv: fix prot virt host indication compilation

  * Skip rtcpie test in kselftests/timers if the default RTC device does not
exist (LP: #1937991)
- selftests: timers: rtcpie: skip test if default RTC device does not exist

  * On TGL platforms screen shows garbage when browsing website by scrolling
mouse (LP: #1926579)
- drm/i915/display: Disable PSR2 if TGL Display stepping is B1 from A0

  * USB Type-C hotplug event not handled properly in TGL-H system during s2idle
(LP: #1931072)
- drm/i915/gen9_bc: Introduce HPD pin mappings for TGP PCH + CML combos
- drm/i915: Force a TypeC PHY disconnect during suspend/shutdown

  * NIC unavailable after suspend to RAM (LP: #1931301)
- SAUCE: Revert "ethernet: alx: fix order of calls on resume"

  * Make Intel GPUs choose YCbCr420 encoding automatically when required for 4k
60Hz output  (LP: #1934489)
- drm/i915: Use intel_hdmi_port_clock() more
- drm/i915/display: New function to avoid duplicate code in upcomming
- drm/i915/display: Restructure output format computation for better
  expandability
- drm/i915/display: Use YCbCr420 as fallback when RGB fails

  * Hirsute update: upstream stable patchset 2021-07-28 (LP: #1938340)
- Bluetooth: hci_qca: fix potential GPF
- Bluetooth: btqca: Don't modify firmware contents in-place
- Bluetooth: Remove spurious error message
- ALSA: usb-audio: fix rate on Ozone Z90 USB headset
- ALSA: usb-audio: Fix OOB access at proc output

[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-09-07 Thread Launchpad Bug Tracker
This bug was fixed in the package linux - 5.4.0-84.94

---
linux (5.4.0-84.94) focal; urgency=medium

  * focal/linux: 5.4.0-84.94 -proposed tracker (LP: #1941767)

  * Server boot failure after adding checks for ACPI IRQ override (LP: #1941657)
- Revert "ACPI: resources: Add checks for ACPI IRQ override"

linux (5.4.0-83.93) focal; urgency=medium

  * focal/linux: 5.4.0-83.93 -proposed tracker (LP: #1940159)

  * fails to launch linux L2 guests on AMD (LP: #1940134) // CVE-2021-3653
- KVM: nSVM: avoid picking up unsupported bits from L2 in int_ctl
  (CVE-2021-3653)

  * fails to launch linux L2 guests on AMD (LP: #1940134)
- SAUCE: Revert "UBUNTU: SAUCE: KVM: nSVM: avoid picking up unsupported bits
  from L2 in int_ctl"

linux (5.4.0-82.92) focal; urgency=medium

  * focal/linux: 5.4.0-82.92 -proposed tracker (LP: #1939799)

  * Packaging resync (LP: #1786013)
- debian/dkms-versions -- update from kernel-versions (main/2021.08.16)

  * CVE-2021-3656
- SAUCE: KVM: nSVM: always intercept VMLOAD/VMSAVE when nested

  * CVE-2021-3653
- SAUCE: KVM: nSVM: avoid picking up unsupported bits from L2 in int_ctl

  * [regression] USB device is not detected during boot (LP: #1939638)
- SAUCE: Revert "usb: core: reduce power-on-good delay time of root hub"

  * dev_forward_skb: do not scrub skb mark within the same name space
(LP: #1935040)
- dev_forward_skb: do not scrub skb mark within the same name space

  * XPS 9510 (TGL) Screen Brightness could not be changed (LP: #1933566)
- SAUCE: drm/i915: Force DPCD backlight mode for Dell XPS 9510(TGL)

  * Acer Aspire 5 sound driver issues (LP: #1930188)
- ALSA: hda/realtek: headphone and mic don't work on an Acer laptop

  * Sony Dualshock 4 usb dongle crashes the whole system (LP: #1935846)
- HID: sony: Workaround for DS4 dongle hotplug kernel crash.

  * [21.10 FEAT] KVM: Provide a secure guest indication (LP: #1933173)
- s390/uv: add prot virt guest/host indication files
- s390/uv: fix prot virt host indication compilation

  * Skip rtcpie test in kselftests/timers if the default RTC device does not
exist (LP: #1937991)
- selftests: timers: rtcpie: skip test if default RTC device does not exist

  * Focal update: v5.4.133 upstream stable release (LP: #1938713)
- drm/mxsfb: Don't select DRM_KMS_FB_HELPER
- drm/zte: Don't select DRM_KMS_FB_HELPER
- drm/amd/amdgpu/sriov disable all ip hw status by default
- drm/vc4: fix argument ordering in vc4_crtc_get_margins()
- net: pch_gbe: Use proper accessors to BE data in pch_ptp_match()
- drm/amd/display: fix use_max_lb flag for 420 pixel formats
- hugetlb: clear huge pte during flush function on mips platform
- atm: iphase: fix possible use-after-free in ia_module_exit()
- mISDN: fix possible use-after-free in HFC_cleanup()
- atm: nicstar: Fix possible use-after-free in nicstar_cleanup()
- net: Treat __napi_schedule_irqoff() as __napi_schedule() on PREEMPT_RT
- drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init()
- reiserfs: add check for invalid 1st journal block
- drm/virtio: Fix double free on probe failure
- drm/sched: Avoid data corruptions
- udf: Fix NULL pointer dereference in udf_symlink function
- e100: handle eeprom as little endian
- igb: handle vlan types with checker enabled
- drm/bridge: cdns: Fix PM reference leak in cdns_dsi_transfer()
- clk: renesas: r8a77995: Add ZA2 clock
- clk: tegra: Ensure that PLLU configuration is applied properly
- ipv6: use prandom_u32() for ID generation
- RDMA/cxgb4: Fix missing error code in create_qp()
- dm space maps: don't reset space map allocation cursor when committing
- pinctrl: mcp23s08: fix race condition in irq handler
- ice: set the value of global config lock timeout longer
- virtio_net: Remove BUG() to avoid machine dead
- net: bcmgenet: check return value after calling platform_get_resource()
- net: mvpp2: check return value after calling platform_get_resource()
- net: micrel: check return value after calling platform_get_resource()
- drm/amd/display: Update scaling settings on modeset
- drm/amd/display: Release MST resources on switch from MST to SST
- drm/amd/display: Set DISPCLK_MAX_ERRDET_CYCLES to 7
- drm/amdkfd: use allowed domain for vmbo validation
- fjes: check return value after calling platform_get_resource()
- selinux: use __GFP_NOWARN with GFP_NOWAIT in the AVC
- r8169: avoid link-up interrupt issue on RTL8106e if user enables ASPM
- drm/amd/display: Verify Gamma & Degamma LUT sizes in 
amdgpu_dm_atomic_check
- xfrm: Fix error reporting in xfrm_state_construct.
- wlcore/wl12xx: Fix wl12xx get_mac error if device is in ELP
- wl1251: Fix possible buffer overflow in wl1251_cmd_scan
- cw1200: add missing MODULE_DEVICE_TABLE
- bpf: Fix up register-based shifts in interpreter to silence KUBSAN
- 

[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-08-23 Thread Nicolas Dichtel
** Tags removed: verification-needed-bionic
** Tags added: verification-done-bionic

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1935040

Title:
  dev_forward_skb: do not scrub skb mark within the same name space

Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Focal:
  Fix Committed
Status in linux source package in Hirsute:
  Fix Committed
Status in linux source package in Impish:
  In Progress

Bug description:
  [Impact]

  The ebpf function 'bpf_redirect' reset the mark when used with the flag 
BPF_F_INGRESS.
  There are two main problems with that:
   - it's not consistent between legacy tunnels and ebpf;
   - it's not consistent between ingress and egress.

  In fact, the eBPF program can easily reset the mark, but it cannot
  preserve it.

  This kind of patch was already done in the past, see commit
  963a88b31ddb ("tunnels: harmonize cleanup done on skb on xmit path"),
  commit ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx
  path") and commit 213dd74aee76 ("skbuff: Do not scrub skb mark within
  the same name space").

  This is fixed upstream with commit ff70202b2d1a ("dev_forward_skb: do
  not scrub skb mark within the same name space").

  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff70202b2d1a

  [Test Case]

  Mark a packet in the POSTROUTING hook, redirect it to another
  interface and display it with a netfilter log rule to check the mark.

  [Regression Potential]

  A user could expect that the mark is reset after a call to
  bpf_redirect(BPF_F_INGRESS), but he could easily reset it in the eBPF
  program himself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1935040/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-08-23 Thread Nicolas Dichtel
** Tags removed: verification-needed-hirsute
** Tags added: verification-done-hirsute

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1935040

Title:
  dev_forward_skb: do not scrub skb mark within the same name space

Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Focal:
  Fix Committed
Status in linux source package in Hirsute:
  Fix Committed
Status in linux source package in Impish:
  In Progress

Bug description:
  [Impact]

  The ebpf function 'bpf_redirect' reset the mark when used with the flag 
BPF_F_INGRESS.
  There are two main problems with that:
   - it's not consistent between legacy tunnels and ebpf;
   - it's not consistent between ingress and egress.

  In fact, the eBPF program can easily reset the mark, but it cannot
  preserve it.

  This kind of patch was already done in the past, see commit
  963a88b31ddb ("tunnels: harmonize cleanup done on skb on xmit path"),
  commit ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx
  path") and commit 213dd74aee76 ("skbuff: Do not scrub skb mark within
  the same name space").

  This is fixed upstream with commit ff70202b2d1a ("dev_forward_skb: do
  not scrub skb mark within the same name space").

  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff70202b2d1a

  [Test Case]

  Mark a packet in the POSTROUTING hook, redirect it to another
  interface and display it with a netfilter log rule to check the mark.

  [Regression Potential]

  A user could expect that the mark is reset after a call to
  bpf_redirect(BPF_F_INGRESS), but he could easily reset it in the eBPF
  program himself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1935040/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-08-23 Thread Nicolas Dichtel
** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1935040

Title:
  dev_forward_skb: do not scrub skb mark within the same name space

Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Focal:
  Fix Committed
Status in linux source package in Hirsute:
  Fix Committed
Status in linux source package in Impish:
  In Progress

Bug description:
  [Impact]

  The ebpf function 'bpf_redirect' reset the mark when used with the flag 
BPF_F_INGRESS.
  There are two main problems with that:
   - it's not consistent between legacy tunnels and ebpf;
   - it's not consistent between ingress and egress.

  In fact, the eBPF program can easily reset the mark, but it cannot
  preserve it.

  This kind of patch was already done in the past, see commit
  963a88b31ddb ("tunnels: harmonize cleanup done on skb on xmit path"),
  commit ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx
  path") and commit 213dd74aee76 ("skbuff: Do not scrub skb mark within
  the same name space").

  This is fixed upstream with commit ff70202b2d1a ("dev_forward_skb: do
  not scrub skb mark within the same name space").

  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff70202b2d1a

  [Test Case]

  Mark a packet in the POSTROUTING hook, redirect it to another
  interface and display it with a netfilter log rule to check the mark.

  [Regression Potential]

  A user could expect that the mark is reset after a call to
  bpf_redirect(BPF_F_INGRESS), but he could easily reset it in the eBPF
  program himself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1935040/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-08-20 Thread Ubuntu Kernel Bot
This bug is awaiting verification that the kernel in -proposed solves
the problem. Please test the kernel and update this bug with the
results. If the problem is solved, change the tag 'verification-needed-
bionic' to 'verification-done-bionic'. If the problem still exists,
change the tag 'verification-needed-bionic' to 'verification-failed-
bionic'.

If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!


** Tags added: verification-needed-bionic

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1935040

Title:
  dev_forward_skb: do not scrub skb mark within the same name space

Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Focal:
  Fix Committed
Status in linux source package in Hirsute:
  Fix Committed
Status in linux source package in Impish:
  In Progress

Bug description:
  [Impact]

  The ebpf function 'bpf_redirect' reset the mark when used with the flag 
BPF_F_INGRESS.
  There are two main problems with that:
   - it's not consistent between legacy tunnels and ebpf;
   - it's not consistent between ingress and egress.

  In fact, the eBPF program can easily reset the mark, but it cannot
  preserve it.

  This kind of patch was already done in the past, see commit
  963a88b31ddb ("tunnels: harmonize cleanup done on skb on xmit path"),
  commit ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx
  path") and commit 213dd74aee76 ("skbuff: Do not scrub skb mark within
  the same name space").

  This is fixed upstream with commit ff70202b2d1a ("dev_forward_skb: do
  not scrub skb mark within the same name space").

  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff70202b2d1a

  [Test Case]

  Mark a packet in the POSTROUTING hook, redirect it to another
  interface and display it with a netfilter log rule to check the mark.

  [Regression Potential]

  A user could expect that the mark is reset after a call to
  bpf_redirect(BPF_F_INGRESS), but he could easily reset it in the eBPF
  program himself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1935040/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-08-20 Thread Ubuntu Kernel Bot
This bug is awaiting verification that the kernel in -proposed solves
the problem. Please test the kernel and update this bug with the
results. If the problem is solved, change the tag 'verification-needed-
focal' to 'verification-done-focal'. If the problem still exists, change
the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!


** Tags added: verification-needed-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1935040

Title:
  dev_forward_skb: do not scrub skb mark within the same name space

Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Focal:
  Fix Committed
Status in linux source package in Hirsute:
  Fix Committed
Status in linux source package in Impish:
  In Progress

Bug description:
  [Impact]

  The ebpf function 'bpf_redirect' reset the mark when used with the flag 
BPF_F_INGRESS.
  There are two main problems with that:
   - it's not consistent between legacy tunnels and ebpf;
   - it's not consistent between ingress and egress.

  In fact, the eBPF program can easily reset the mark, but it cannot
  preserve it.

  This kind of patch was already done in the past, see commit
  963a88b31ddb ("tunnels: harmonize cleanup done on skb on xmit path"),
  commit ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx
  path") and commit 213dd74aee76 ("skbuff: Do not scrub skb mark within
  the same name space").

  This is fixed upstream with commit ff70202b2d1a ("dev_forward_skb: do
  not scrub skb mark within the same name space").

  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff70202b2d1a

  [Test Case]

  Mark a packet in the POSTROUTING hook, redirect it to another
  interface and display it with a netfilter log rule to check the mark.

  [Regression Potential]

  A user could expect that the mark is reset after a call to
  bpf_redirect(BPF_F_INGRESS), but he could easily reset it in the eBPF
  program himself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1935040/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-08-17 Thread Ubuntu Kernel Bot
This bug is awaiting verification that the kernel in -proposed solves
the problem. Please test the kernel and update this bug with the
results. If the problem is solved, change the tag 'verification-needed-
hirsute' to 'verification-done-hirsute'. If the problem still exists,
change the tag 'verification-needed-hirsute' to 'verification-failed-
hirsute'.

If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!


** Tags added: verification-needed-hirsute

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1935040

Title:
  dev_forward_skb: do not scrub skb mark within the same name space

Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Focal:
  Fix Committed
Status in linux source package in Hirsute:
  Fix Committed
Status in linux source package in Impish:
  In Progress

Bug description:
  [Impact]

  The ebpf function 'bpf_redirect' reset the mark when used with the flag 
BPF_F_INGRESS.
  There are two main problems with that:
   - it's not consistent between legacy tunnels and ebpf;
   - it's not consistent between ingress and egress.

  In fact, the eBPF program can easily reset the mark, but it cannot
  preserve it.

  This kind of patch was already done in the past, see commit
  963a88b31ddb ("tunnels: harmonize cleanup done on skb on xmit path"),
  commit ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx
  path") and commit 213dd74aee76 ("skbuff: Do not scrub skb mark within
  the same name space").

  This is fixed upstream with commit ff70202b2d1a ("dev_forward_skb: do
  not scrub skb mark within the same name space").

  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff70202b2d1a

  [Test Case]

  Mark a packet in the POSTROUTING hook, redirect it to another
  interface and display it with a netfilter log rule to check the mark.

  [Regression Potential]

  A user could expect that the mark is reset after a call to
  bpf_redirect(BPF_F_INGRESS), but he could easily reset it in the eBPF
  program himself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1935040/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-08-12 Thread Kelsey Skunberg
** Changed in: linux (Ubuntu Bionic)
   Status: In Progress => Fix Committed

** Changed in: linux (Ubuntu Focal)
   Status: In Progress => Fix Committed

** Changed in: linux (Ubuntu Hirsute)
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1935040

Title:
  dev_forward_skb: do not scrub skb mark within the same name space

Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Focal:
  Fix Committed
Status in linux source package in Hirsute:
  Fix Committed
Status in linux source package in Impish:
  In Progress

Bug description:
  [Impact]

  The ebpf function 'bpf_redirect' reset the mark when used with the flag 
BPF_F_INGRESS.
  There are two main problems with that:
   - it's not consistent between legacy tunnels and ebpf;
   - it's not consistent between ingress and egress.

  In fact, the eBPF program can easily reset the mark, but it cannot
  preserve it.

  This kind of patch was already done in the past, see commit
  963a88b31ddb ("tunnels: harmonize cleanup done on skb on xmit path"),
  commit ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx
  path") and commit 213dd74aee76 ("skbuff: Do not scrub skb mark within
  the same name space").

  This is fixed upstream with commit ff70202b2d1a ("dev_forward_skb: do
  not scrub skb mark within the same name space").

  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff70202b2d1a

  [Test Case]

  Mark a packet in the POSTROUTING hook, redirect it to another
  interface and display it with a netfilter log rule to check the mark.

  [Regression Potential]

  A user could expect that the mark is reset after a call to
  bpf_redirect(BPF_F_INGRESS), but he could easily reset it in the eBPF
  program himself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1935040/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1935040] Re: dev_forward_skb: do not scrub skb mark within the same name space

2021-07-29 Thread Tim Gardner
** Also affects: linux (Ubuntu Impish)
   Importance: Undecided
   Status: New

** Also affects: linux (Ubuntu Bionic)
   Importance: Undecided
   Status: New

** Also affects: linux (Ubuntu Hirsute)
   Importance: Undecided
   Status: New

** Also affects: linux (Ubuntu Focal)
   Importance: Undecided
   Status: New

** Changed in: linux (Ubuntu Bionic)
   Status: New => In Progress

** Changed in: linux (Ubuntu Focal)
   Status: New => In Progress

** Changed in: linux (Ubuntu Hirsute)
   Status: New => In Progress

** Changed in: linux (Ubuntu Impish)
   Status: New => In Progress

** Changed in: linux (Ubuntu Bionic)
   Importance: Undecided => Medium

** Changed in: linux (Ubuntu Focal)
   Importance: Undecided => Medium

** Changed in: linux (Ubuntu Hirsute)
   Importance: Undecided => Medium

** Changed in: linux (Ubuntu Impish)
   Importance: Undecided => Medium

** Changed in: linux (Ubuntu Bionic)
 Assignee: (unassigned) => Nicolas Dichtel (nicolas-dichtel)

** Changed in: linux (Ubuntu Focal)
 Assignee: (unassigned) => Nicolas Dichtel (nicolas-dichtel)

** Changed in: linux (Ubuntu Hirsute)
 Assignee: (unassigned) => Nicolas Dichtel (nicolas-dichtel)

** Changed in: linux (Ubuntu Impish)
 Assignee: (unassigned) => Nicolas Dichtel (nicolas-dichtel)

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1935040

Title:
  dev_forward_skb: do not scrub skb mark within the same name space

Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Bionic:
  In Progress
Status in linux source package in Focal:
  In Progress
Status in linux source package in Hirsute:
  In Progress
Status in linux source package in Impish:
  In Progress

Bug description:
  [Impact]

  The ebpf function 'bpf_redirect' reset the mark when used with the flag 
BPF_F_INGRESS.
  There are two main problems with that:
   - it's not consistent between legacy tunnels and ebpf;
   - it's not consistent between ingress and egress.

  In fact, the eBPF program can easily reset the mark, but it cannot
  preserve it.

  This kind of patch was already done in the past, see commit
  963a88b31ddb ("tunnels: harmonize cleanup done on skb on xmit path"),
  commit ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx
  path") and commit 213dd74aee76 ("skbuff: Do not scrub skb mark within
  the same name space").

  This is fixed upstream with commit ff70202b2d1a ("dev_forward_skb: do
  not scrub skb mark within the same name space").

  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff70202b2d1a

  [Test Case]

  Mark a packet in the POSTROUTING hook, redirect it to another
  interface and display it with a netfilter log rule to check the mark.

  [Regression Potential]

  A user could expect that the mark is reset after a call to
  bpf_redirect(BPF_F_INGRESS), but he could easily reset it in the eBPF
  program himself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1935040/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp