[Kernel-packages] [Bug 1984011] Re: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal
All verifications have been completed w.r.t this bug. Is any action needed here? Please advise. Thanks, Karan -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1984011 Title: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal Status in linux package in Ubuntu: Invalid Status in linux source package in Focal: Fix Released Bug description: [Impact] fNIC driver controls print messages based on the flag fnic_log_level. shost_printk is not controlled via this flag. This issue is resolved by using some of the print macros that have been defined in fnic. This has negligible impact. The resid was being set irrespective of whether we saw an underflow or not. It needs to be set only when we see an underflow. The impact here is negligible. When we don't receive link events, we could go into a loop before sending fw reset. The patch for the issue resolves this, and we break out of the loop. Prior to checking the remote port, fnic driver must check if the io_req is valid. If not, there could be a crash. The patch resolves this issue. [Fix] The following patches need to be pulled from upstream to update the fnic driver to 1.6.0.53: https://marc.info/?l=linux-scsi=160591061813369=2 https://marc.info/?l=linux-scsi=160592183315837=2 https://marc.info/?l=linux-scsi=160592283315997=2 https://marc.info/?l=linux-scsi=160592363016122=2 https://marc.info/?l=linux-scsi=160592616516616=2 Here's a description of each issue: 1. https://marc.info/?l=linux-scsi=160591061813369=2 FNIC_FCS_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_fip_handler_timer with this print so that it can be controlled. 2. https://marc.info/?l=linux-scsi=160592183315837=2 When fnic is in TRANS ETH state, and when there are no link events, we must not loop before sending fw reset. 3. https://marc.info/?l=linux-scsi=160592283315997=2 FNIC_MAIN_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_handle_link with this print so that it can be controlled. 4. https://marc.info/?l=linux-scsi=160592363016122=2 Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is set. 5. https://marc.info/?l=linux-scsi=160592616516616=2 Check for a valid io_req before we check other data. [Test Plan] Runnings IOs with multiple link flaps would be a good test case to validate all the patches above. It is suggested to run these IOs with a data integrity check. We do this as a standard practice. [Where problems could occur] The print messages are innocuous. It is not expected to run into any issues. Problems could occur with storage arrays that have a non-standard response. If the sanity test fails, there could be issues in the scsi midlayer or fnic driver. All the patches present low regression risk. [Other Info] https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/fnic_cisco_ver3 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1984011/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984011] Re: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal
This bug is awaiting verification that the linux-xilinx- zynqmp/5.4.0-1020.24 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification- done-focal'. If the problem still exists, change the tag 'verification- needed-focal' to 'verification-failed-focal'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags removed: verification-done-focal ** Tags added: kernel-spammed-focal-linux-xilinx-zynqmp verification-needed-focal -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1984011 Title: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal Status in linux package in Ubuntu: Invalid Status in linux source package in Focal: Fix Released Bug description: [Impact] fNIC driver controls print messages based on the flag fnic_log_level. shost_printk is not controlled via this flag. This issue is resolved by using some of the print macros that have been defined in fnic. This has negligible impact. The resid was being set irrespective of whether we saw an underflow or not. It needs to be set only when we see an underflow. The impact here is negligible. When we don't receive link events, we could go into a loop before sending fw reset. The patch for the issue resolves this, and we break out of the loop. Prior to checking the remote port, fnic driver must check if the io_req is valid. If not, there could be a crash. The patch resolves this issue. [Fix] The following patches need to be pulled from upstream to update the fnic driver to 1.6.0.53: https://marc.info/?l=linux-scsi=160591061813369=2 https://marc.info/?l=linux-scsi=160592183315837=2 https://marc.info/?l=linux-scsi=160592283315997=2 https://marc.info/?l=linux-scsi=160592363016122=2 https://marc.info/?l=linux-scsi=160592616516616=2 Here's a description of each issue: 1. https://marc.info/?l=linux-scsi=160591061813369=2 FNIC_FCS_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_fip_handler_timer with this print so that it can be controlled. 2. https://marc.info/?l=linux-scsi=160592183315837=2 When fnic is in TRANS ETH state, and when there are no link events, we must not loop before sending fw reset. 3. https://marc.info/?l=linux-scsi=160592283315997=2 FNIC_MAIN_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_handle_link with this print so that it can be controlled. 4. https://marc.info/?l=linux-scsi=160592363016122=2 Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is set. 5. https://marc.info/?l=linux-scsi=160592616516616=2 Check for a valid io_req before we check other data. [Test Plan] Runnings IOs with multiple link flaps would be a good test case to validate all the patches above. It is suggested to run these IOs with a data integrity check. We do this as a standard practice. [Where problems could occur] The print messages are innocuous. It is not expected to run into any issues. Problems could occur with storage arrays that have a non-standard response. If the sanity test fails, there could be issues in the scsi midlayer or fnic driver. All the patches present low regression risk. [Other Info] https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/fnic_cisco_ver3 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1984011/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984011] Re: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal
This bug was fixed in the package linux - 5.4.0-126.142 --- linux (5.4.0-126.142) focal; urgency=medium * focal/linux: 5.4.0-126.142 -proposed tracker (LP: #1987819) * [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal (LP: #1984011) - scsi: fnic: Change shost_printk() to FNIC_FCS_DBG() - scsi: fnic: Avoid looping in TRANS ETH on unload - scsi: fnic: Change shost_printk() to FNIC_MAIN_DBG() - scsi: fnic: Set scsi_set_resid() only for underflow - scsi: fnic: Validate io_req before others * Focal update: v5.4.203 upstream stable release (LP: #1986999) - drm: remove drm_fb_helper_modinit - powerpc/ftrace: Remove ftrace init tramp once kernel init is complete - kexec_file: drop weak attribute from arch_kexec_apply_relocations[_add] - net: mscc: ocelot: allow unregistered IP multicast flooding - ARM: 8989/1: use .fpu assembler directives instead of assembler arguments - ARM: 8990/1: use VFP assembler mnemonics in register load/store macros - ARM: 8971/1: replace the sole use of a symbol with its definition - crypto: arm/sha256-neon - avoid ADRL pseudo instruction - crypto: arm/sha512-neon - avoid ADRL pseudo instruction - ARM: 8933/1: replace Sun/Solaris style flag on section directive - ARM: 8929/1: use APSR_nzcv instead of r15 as mrc operand - ARM: OMAP2+: drop unnecessary adrl - ARM: 9029/1: Make iwmmxt.S support Clang's integrated assembler - crypto: arm - use Kconfig based compiler checks for crypto opcodes - crypto: arm/ghash-ce - define fpu before fpu registers are referenced - Linux 5.4.203 * Focal update: v5.4.202 upstream stable release (LP: #1986995) - random: schedule mix_interrupt_randomness() less often - ALSA: hda/via: Fix missing beep setup - ALSA: hda/conexant: Fix missing beep setup - ALSA: hda/realtek - ALC897 headset MIC no sound - ALSA: hda/realtek: Add quirk for Clevo PD70PNT - net: openvswitch: fix parsing of nw_proto for IPv6 fragments - mmc: sdhci-pci-o2micro: Fix card detect by dealing with debouncing - ata: libata: add qc->flags in ata_qc_complete_template tracepoint - dm era: commit metadata in postsuspend after worker stops - dm mirror log: clear log bits up to BITS_PER_LONG boundary - random: quiet urandom warning ratelimit suppression message - USB: serial: option: add Telit LE910Cx 0x1250 composition - USB: serial: option: add Quectel EM05-G modem - USB: serial: option: add Quectel RM500K module support - bpf: Fix request_sock leak in sk lookup helpers - phy: aquantia: Fix AN when higher speeds than 1G are not advertised - bonding: ARP monitor spams NETDEV_NOTIFY_PEERS notifiers - net/sched: sch_netem: Fix arithmetic in netem_dump() for 32-bit platforms - drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf - erspan: do not assume transport header is always set - net/tls: fix tls_sk_proto_close executed repeatedly - udmabuf: add back sanity check - x86/xen: Remove undefined behavior in setup_features() - MIPS: Remove repetitive increase irq_err_count - afs: Fix dynamic root getattr - ice: ethtool: advertise 1000M speeds properly - regmap-irq: Fix a bug in regmap_irq_enable() for type_in_mask chips - igb: Make DMA faster when CPU is active on the PCIe link - virtio_net: fix xdp_rxq_info bug after suspend/resume - Revert "net/tls: fix tls_sk_proto_close executed repeatedly" - gpio: winbond: Fix error code in winbond_gpio_get() - s390/cpumf: Handle events cycles and instructions identical - iio: adc: vf610: fix conversion mode sysfs node name - xhci: turn off port power in shutdown - usb: chipidea: udc: check request status before setting device address - iio:chemical:ccs811: rearrange iio trigger get and register - iio:accel:bma180: rearrange iio trigger get and register - iio:accel:mxc4005: rearrange iio trigger get and register - iio: accel: mma8452: ignore the return value of reset operation - iio: gyro: mpu3050: Fix the error handling in mpu3050_power_up() - iio: trigger: sysfs: fix use-after-free on remove - iio: adc: stm32: fix maximum clock rate for stm32mp15x - iio: adc: axp288: Override TS pin bias current for some models - xtensa: xtfpga: Fix refcount leak bug in setup - xtensa: Fix refcount leak bug in time.c - parisc: Enable ARCH_HAS_STRICT_MODULE_RWX - powerpc: Enable execve syscall exit tracepoint - powerpc/rtas: Allow ibm,platform-dump RTAS call with null buffer address - powerpc/powernv: wire up rng during setup_arch - ARM: dts: imx6qdl: correct PU regulator ramp delay - ARM: exynos: Fix refcount leak in exynos_map_pmu - soc: bcm: brcmstb: pm: pm-arm: Fix refcount leak in brcmstb_pm_probe - ARM: Fix refcount leak in axxia_boot_secondary - ARM: cns3xxx: Fix refcount leak in cns3xxx_init - modpost: fix section mismatch check for
[Kernel-packages] [Bug 1984011] Re: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal
** Tags added: verification-done-focal -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1984011 Title: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal Status in linux package in Ubuntu: Invalid Status in linux source package in Focal: Fix Committed Bug description: [Impact] fNIC driver controls print messages based on the flag fnic_log_level. shost_printk is not controlled via this flag. This issue is resolved by using some of the print macros that have been defined in fnic. This has negligible impact. The resid was being set irrespective of whether we saw an underflow or not. It needs to be set only when we see an underflow. The impact here is negligible. When we don't receive link events, we could go into a loop before sending fw reset. The patch for the issue resolves this, and we break out of the loop. Prior to checking the remote port, fnic driver must check if the io_req is valid. If not, there could be a crash. The patch resolves this issue. [Fix] The following patches need to be pulled from upstream to update the fnic driver to 1.6.0.53: https://marc.info/?l=linux-scsi=160591061813369=2 https://marc.info/?l=linux-scsi=160592183315837=2 https://marc.info/?l=linux-scsi=160592283315997=2 https://marc.info/?l=linux-scsi=160592363016122=2 https://marc.info/?l=linux-scsi=160592616516616=2 Here's a description of each issue: 1. https://marc.info/?l=linux-scsi=160591061813369=2 FNIC_FCS_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_fip_handler_timer with this print so that it can be controlled. 2. https://marc.info/?l=linux-scsi=160592183315837=2 When fnic is in TRANS ETH state, and when there are no link events, we must not loop before sending fw reset. 3. https://marc.info/?l=linux-scsi=160592283315997=2 FNIC_MAIN_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_handle_link with this print so that it can be controlled. 4. https://marc.info/?l=linux-scsi=160592363016122=2 Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is set. 5. https://marc.info/?l=linux-scsi=160592616516616=2 Check for a valid io_req before we check other data. [Test Plan] Runnings IOs with multiple link flaps would be a good test case to validate all the patches above. It is suggested to run these IOs with a data integrity check. We do this as a standard practice. [Where problems could occur] The print messages are innocuous. It is not expected to run into any issues. Problems could occur with storage arrays that have a non-standard response. If the sanity test fails, there could be issues in the scsi midlayer or fnic driver. All the patches present low regression risk. [Other Info] https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/fnic_cisco_ver3 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1984011/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984011] Re: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal
This bug is awaiting verification that the linux/5.4.0-126.142 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1984011 Title: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal Status in linux package in Ubuntu: Invalid Status in linux source package in Focal: Fix Committed Bug description: [Impact] fNIC driver controls print messages based on the flag fnic_log_level. shost_printk is not controlled via this flag. This issue is resolved by using some of the print macros that have been defined in fnic. This has negligible impact. The resid was being set irrespective of whether we saw an underflow or not. It needs to be set only when we see an underflow. The impact here is negligible. When we don't receive link events, we could go into a loop before sending fw reset. The patch for the issue resolves this, and we break out of the loop. Prior to checking the remote port, fnic driver must check if the io_req is valid. If not, there could be a crash. The patch resolves this issue. [Fix] The following patches need to be pulled from upstream to update the fnic driver to 1.6.0.53: https://marc.info/?l=linux-scsi=160591061813369=2 https://marc.info/?l=linux-scsi=160592183315837=2 https://marc.info/?l=linux-scsi=160592283315997=2 https://marc.info/?l=linux-scsi=160592363016122=2 https://marc.info/?l=linux-scsi=160592616516616=2 Here's a description of each issue: 1. https://marc.info/?l=linux-scsi=160591061813369=2 FNIC_FCS_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_fip_handler_timer with this print so that it can be controlled. 2. https://marc.info/?l=linux-scsi=160592183315837=2 When fnic is in TRANS ETH state, and when there are no link events, we must not loop before sending fw reset. 3. https://marc.info/?l=linux-scsi=160592283315997=2 FNIC_MAIN_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_handle_link with this print so that it can be controlled. 4. https://marc.info/?l=linux-scsi=160592363016122=2 Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is set. 5. https://marc.info/?l=linux-scsi=160592616516616=2 Check for a valid io_req before we check other data. [Test Plan] Runnings IOs with multiple link flaps would be a good test case to validate all the patches above. It is suggested to run these IOs with a data integrity check. We do this as a standard practice. [Where problems could occur] The print messages are innocuous. It is not expected to run into any issues. Problems could occur with storage arrays that have a non-standard response. If the sanity test fails, there could be issues in the scsi midlayer or fnic driver. All the patches present low regression risk. [Other Info] https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/fnic_cisco_ver3 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1984011/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984011] Re: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal
** Changed in: linux (Ubuntu) Status: In Progress => Invalid ** Changed in: linux (Ubuntu Focal) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1984011 Title: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal Status in linux package in Ubuntu: Invalid Status in linux source package in Focal: Fix Committed Bug description: [Impact] fNIC driver controls print messages based on the flag fnic_log_level. shost_printk is not controlled via this flag. This issue is resolved by using some of the print macros that have been defined in fnic. This has negligible impact. The resid was being set irrespective of whether we saw an underflow or not. It needs to be set only when we see an underflow. The impact here is negligible. When we don't receive link events, we could go into a loop before sending fw reset. The patch for the issue resolves this, and we break out of the loop. Prior to checking the remote port, fnic driver must check if the io_req is valid. If not, there could be a crash. The patch resolves this issue. [Fix] The following patches need to be pulled from upstream to update the fnic driver to 1.6.0.53: https://marc.info/?l=linux-scsi=160591061813369=2 https://marc.info/?l=linux-scsi=160592183315837=2 https://marc.info/?l=linux-scsi=160592283315997=2 https://marc.info/?l=linux-scsi=160592363016122=2 https://marc.info/?l=linux-scsi=160592616516616=2 Here's a description of each issue: 1. https://marc.info/?l=linux-scsi=160591061813369=2 FNIC_FCS_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_fip_handler_timer with this print so that it can be controlled. 2. https://marc.info/?l=linux-scsi=160592183315837=2 When fnic is in TRANS ETH state, and when there are no link events, we must not loop before sending fw reset. 3. https://marc.info/?l=linux-scsi=160592283315997=2 FNIC_MAIN_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_handle_link with this print so that it can be controlled. 4. https://marc.info/?l=linux-scsi=160592363016122=2 Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is set. 5. https://marc.info/?l=linux-scsi=160592616516616=2 Check for a valid io_req before we check other data. [Test Plan] Runnings IOs with multiple link flaps would be a good test case to validate all the patches above. It is suggested to run these IOs with a data integrity check. We do this as a standard practice. [Where problems could occur] The print messages are innocuous. It is not expected to run into any issues. Problems could occur with storage arrays that have a non-standard response. If the sanity test fails, there could be issues in the scsi midlayer or fnic driver. All the patches present low regression risk. [Other Info] https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/fnic_cisco_ver3 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1984011/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984011] Re: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal
** Description changed: [Impact] fNIC driver controls print messages based on the flag fnic_log_level. shost_printk is not controlled via this flag. This issue is resolved by using some of the print macros that have been defined in fnic. This has negligible impact. The resid was being set irrespective of whether we saw an underflow or not. It needs to be set only when we see an underflow. The impact here is negligible. When we don't receive link events, we could go into a loop before sending fw reset. The patch for the issue resolves this, and we break out of the loop. Prior to checking the remote port, fnic driver must check if the io_req is valid. If not, there could be a crash. The patch resolves this issue. [Fix] The following patches need to be pulled from upstream to update the fnic driver to 1.6.0.53: https://marc.info/?l=linux-scsi=160591061813369=2 https://marc.info/?l=linux-scsi=160592183315837=2 https://marc.info/?l=linux-scsi=160592283315997=2 https://marc.info/?l=linux-scsi=160592363016122=2 https://marc.info/?l=linux-scsi=160592616516616=2 Here's a description of each issue: 1. https://marc.info/?l=linux-scsi=160591061813369=2 FNIC_FCS_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_fip_handler_timer with this print so that it can be controlled. 2. https://marc.info/?l=linux-scsi=160592183315837=2 When fnic is in TRANS ETH state, and when there are no link events, we must not loop before sending fw reset. 3. https://marc.info/?l=linux-scsi=160592283315997=2 FNIC_MAIN_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_handle_link with this print so that it can be controlled. 4. https://marc.info/?l=linux-scsi=160592363016122=2 Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is set. 5. https://marc.info/?l=linux-scsi=160592616516616=2 Check for a valid io_req before we check other data. [Test Plan] Runnings IOs with multiple link flaps would be a good test case to validate all the patches above. It is suggested to run these IOs with a data integrity check. We do this as a standard practice. [Where problems could occur] The print messages are innocuous. It is not expected to run into any issues. Problems could occur with storage arrays that have a non-standard response. If the sanity test fails, there could be issues in the scsi midlayer or fnic driver. All the patches present low regression risk. [Other Info] - - https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/cisco_fnic_update - - See original description - Add tags Tag help + https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/fnic_cisco_ver3 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1984011 Title: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal Status in linux package in Ubuntu: In Progress Status in linux source package in Focal: In Progress Bug description: [Impact] fNIC driver controls print messages based on the flag fnic_log_level. shost_printk is not controlled via this flag. This issue is resolved by using some of the print macros that have been defined in fnic. This has negligible impact. The resid was being set irrespective of whether we saw an underflow or not. It needs to be set only when we see an underflow. The impact here is negligible. When we don't receive link events, we could go into a loop before sending fw reset. The patch for the issue resolves this, and we break out of the loop. Prior to checking the remote port, fnic driver must check if the io_req is valid. If not, there could be a crash. The patch resolves this issue. [Fix] The following patches need to be pulled from upstream to update the fnic driver to 1.6.0.53: https://marc.info/?l=linux-scsi=160591061813369=2 https://marc.info/?l=linux-scsi=160592183315837=2 https://marc.info/?l=linux-scsi=160592283315997=2 https://marc.info/?l=linux-scsi=160592363016122=2 https://marc.info/?l=linux-scsi=160592616516616=2 Here's a description of each issue: 1. https://marc.info/?l=linux-scsi=160591061813369=2 FNIC_FCS_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_fip_handler_timer with this print so that it can be controlled. 2. https://marc.info/?l=linux-scsi=160592183315837=2 When fnic is in TRANS ETH state, and when there are no link events, we must not loop before sending fw reset. 3. https://marc.info/?l=linux-scsi=160592283315997=2 FNIC_MAIN_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_handle_link with this print so that it can be controlled. 4. https://marc.info/?l=linux-scsi=160592363016122=2 Fix to set scsi_set_resid() only if
[Kernel-packages] [Bug 1984011] Re: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal
** Changed in: linux (Ubuntu) Assignee: (unassigned) => Michael Reed (mreed8855) ** Changed in: linux (Ubuntu Focal) Assignee: (unassigned) => Michael Reed (mreed8855) ** Changed in: linux (Ubuntu) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Focal) Importance: Undecided => Medium ** Changed in: linux (Ubuntu) Status: Incomplete => In Progress ** Changed in: linux (Ubuntu Focal) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1984011 Title: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal Status in linux package in Ubuntu: In Progress Status in linux source package in Focal: In Progress Bug description: [Impact] fNIC driver controls print messages based on the flag fnic_log_level. shost_printk is not controlled via this flag. This issue is resolved by using some of the print macros that have been defined in fnic. This has negligible impact. The resid was being set irrespective of whether we saw an underflow or not. It needs to be set only when we see an underflow. The impact here is negligible. When we don't receive link events, we could go into a loop before sending fw reset. The patch for the issue resolves this, and we break out of the loop. Prior to checking the remote port, fnic driver must check if the io_req is valid. If not, there could be a crash. The patch resolves this issue. [Fix] The following patches need to be pulled from upstream to update the fnic driver to 1.6.0.53: https://marc.info/?l=linux-scsi=160591061813369=2 https://marc.info/?l=linux-scsi=160592183315837=2 https://marc.info/?l=linux-scsi=160592283315997=2 https://marc.info/?l=linux-scsi=160592363016122=2 https://marc.info/?l=linux-scsi=160592616516616=2 Here's a description of each issue: 1. https://marc.info/?l=linux-scsi=160591061813369=2 FNIC_FCS_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_fip_handler_timer with this print so that it can be controlled. 2. https://marc.info/?l=linux-scsi=160592183315837=2 When fnic is in TRANS ETH state, and when there are no link events, we must not loop before sending fw reset. 3. https://marc.info/?l=linux-scsi=160592283315997=2 FNIC_MAIN_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_handle_link with this print so that it can be controlled. 4. https://marc.info/?l=linux-scsi=160592363016122=2 Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is set. 5. https://marc.info/?l=linux-scsi=160592616516616=2 Check for a valid io_req before we check other data. [Test Plan] Runnings IOs with multiple link flaps would be a good test case to validate all the patches above. It is suggested to run these IOs with a data integrity check. We do this as a standard practice. [Where problems could occur] The print messages are innocuous. It is not expected to run into any issues. Problems could occur with storage arrays that have a non-standard response. If the sanity test fails, there could be issues in the scsi midlayer or fnic driver. All the patches present low regression risk. [Other Info] https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/cisco_fnic_update See original description Add tags Tag help To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1984011/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984011] Re: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal
Thanks for the new kernel Michael. I've updated the kernel and verified that the new driver is present. We're all set. Thanks for your help with this. This bug can be resolved. ** Attachment added: "modinfo output" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1984011/+attachment/5607407/+files/lp1984011_log.txt -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1984011 Title: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal Status in linux package in Ubuntu: Incomplete Status in linux source package in Focal: Incomplete Bug description: [Impact] fNIC driver controls print messages based on the flag fnic_log_level. shost_printk is not controlled via this flag. This issue is resolved by using some of the print macros that have been defined in fnic. This has negligible impact. The resid was being set irrespective of whether we saw an underflow or not. It needs to be set only when we see an underflow. The impact here is negligible. When we don't receive link events, we could go into a loop before sending fw reset. The patch for the issue resolves this, and we break out of the loop. Prior to checking the remote port, fnic driver must check if the io_req is valid. If not, there could be a crash. The patch resolves this issue. [Fix] The following patches need to be pulled from upstream to update the fnic driver to 1.6.0.53: https://marc.info/?l=linux-scsi=160591061813369=2 https://marc.info/?l=linux-scsi=160592183315837=2 https://marc.info/?l=linux-scsi=160592283315997=2 https://marc.info/?l=linux-scsi=160592363016122=2 https://marc.info/?l=linux-scsi=160592616516616=2 Here's a description of each issue: 1. https://marc.info/?l=linux-scsi=160591061813369=2 FNIC_FCS_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_fip_handler_timer with this print so that it can be controlled. 2. https://marc.info/?l=linux-scsi=160592183315837=2 When fnic is in TRANS ETH state, and when there are no link events, we must not loop before sending fw reset. 3. https://marc.info/?l=linux-scsi=160592283315997=2 FNIC_MAIN_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_handle_link with this print so that it can be controlled. 4. https://marc.info/?l=linux-scsi=160592363016122=2 Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is set. 5. https://marc.info/?l=linux-scsi=160592616516616=2 Check for a valid io_req before we check other data. [Test Plan] Runnings IOs with multiple link flaps would be a good test case to validate all the patches above. It is suggested to run these IOs with a data integrity check. We do this as a standard practice. [Where problems could occur] The print messages are innocuous. It is not expected to run into any issues. Problems could occur with storage arrays that have a non-standard response. If the sanity test fails, there could be issues in the scsi midlayer or fnic driver. All the patches present low regression risk. [Other Info] https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/cisco_fnic_update See original description Add tags Tag help To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1984011/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984011] Re: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal
I have updated the link with a new test kernel. https://people.canonical.com/~mreed/cisco/lp_1978247_fnic/ After installing this test kernel you should see kernel version 5.4.0-123.139. I installed it and verified the updated driver is present. $ uname -a Linux hogplum 5.4.0-123-generic #139 SMP Thu Aug 4 21:28:51 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux $ modinfo fnic filename: /lib/modules/5.4.0-123-generic/kernel/drivers/scsi/fnic/fnic.ko version: 1.6.0.53 license: GPL v2 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1984011 Title: [SRU] fnic driver on needs to be updated to 1.6.0.53 on Focal Status in linux package in Ubuntu: New Status in linux source package in Focal: New Bug description: [Impact] fNIC driver controls print messages based on the flag fnic_log_level. shost_printk is not controlled via this flag. This issue is resolved by using some of the print macros that have been defined in fnic. This has negligible impact. The resid was being set irrespective of whether we saw an underflow or not. It needs to be set only when we see an underflow. The impact here is negligible. When we don't receive link events, we could go into a loop before sending fw reset. The patch for the issue resolves this, and we break out of the loop. Prior to checking the remote port, fnic driver must check if the io_req is valid. If not, there could be a crash. The patch resolves this issue. [Fix] The following patches need to be pulled from upstream to update the fnic driver to 1.6.0.53: https://marc.info/?l=linux-scsi=160591061813369=2 https://marc.info/?l=linux-scsi=160592183315837=2 https://marc.info/?l=linux-scsi=160592283315997=2 https://marc.info/?l=linux-scsi=160592363016122=2 https://marc.info/?l=linux-scsi=160592616516616=2 Here's a description of each issue: 1. https://marc.info/?l=linux-scsi=160591061813369=2 FNIC_FCS_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_fip_handler_timer with this print so that it can be controlled. 2. https://marc.info/?l=linux-scsi=160592183315837=2 When fnic is in TRANS ETH state, and when there are no link events, we must not loop before sending fw reset. 3. https://marc.info/?l=linux-scsi=160592283315997=2 FNIC_MAIN_DBG print is controlled by fnic_log_level flag. Replace shost_printk in fnic_handle_link with this print so that it can be controlled. 4. https://marc.info/?l=linux-scsi=160592363016122=2 Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is set. 5. https://marc.info/?l=linux-scsi=160592616516616=2 Check for a valid io_req before we check other data. [Test Plan] Runnings IOs with multiple link flaps would be a good test case to validate all the patches above. It is suggested to run these IOs with a data integrity check. We do this as a standard practice. [Where problems could occur] The print messages are innocuous. It is not expected to run into any issues. Problems could occur with storage arrays that have a non-standard response. If the sanity test fails, there could be issues in the scsi midlayer or fnic driver. All the patches present low regression risk. [Other Info] https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/cisco_fnic_update See original description Add tags Tag help To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1984011/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
