[Kernel-packages] [Bug 1243636] Re: ecryptfs currupts files over 4GB size on i686
Patch works for me on 3.12-rc6.
Thanks Colin and Tyler!
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1243636
Title:
ecryptfs currupts files over 4GB size on i686
Status in eCryptfs:
In Progress
Status in “linux” package in Ubuntu:
In Progress
Bug description:
[SRU Justification]
Commit 24d15266bd86b7961f309a962fa3aa177a78c49f introduced a data corruption
regression on 32 bit architectures when writing past the 4 GB.
[Impact]
32 bit users experience corruption of large files.
[Fix]
A cast is needed when shifting the page's index. Colin and I independently
identified the problem. It is a simple fix that is currently located in the
eCryptfs next branch:
http://git.kernel.org/cgit/linux/kernel/git/tyhicks/ecryptfs.git/commit/?h=nextid=43b7c6c6a4e3916edd186ceb61be0c67d1e0969e
I've sent a pull request to Linus, but he has not yet had a chance to pull in
the change:
https://lkml.org/lkml/2013/10/24/424
[Test Case]
Inside of an eCryptfs mount on an i686 Ubuntu install, create a file
containing
4 GB + 1 page worth (4096 bytes) of zeros. Then inspect the file for non-zero
bytes.
$ rm zeros
$ dd if=/dev/zero of=zeros bs=4096 count=$((4*1024*1024*1024/4096+4096))
1052672+0 records in
1052672+0 records out
4311744512 bytes (4.3 GB) copied, 226.133 s, 19.1 MB/s
$ hexdump -C zeros
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ||
*
10100
The hexdump output should show all zeros. A non patched kernel will show
non-zero bytes.
[Original Bug Report]
on extracting files with extracted size 4 GB files are getting currupted.
interestingly file gets currupted in the very moment the file size gets more
than 4GB.
ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: linux-image-3.11.0-12-generic 3.11.0-12.19
ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3
Uname: Linux 3.11.0-12-generic i686
ApportVersion: 2.12.5-0ubuntu2
Architecture: i386
Date: Wed Oct 23 12:11:43 2013
EcryptfsInUse: Yes
InstallationDate: Installed on 2013-07-20 (94 days ago)
InstallationMedia: Ubuntu 13.04 Raring Ringtail - Release i386 (20130424)
MarkForUpload: True
ProcEnviron:
TERM=xterm
PATH=(custom, no user)
XDG_RUNTIME_DIR=set
LANG=de_DE.UTF-8
SHELL=/bin/bash
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.11.0-12-generic
root=UUID=e97431f7-60b7-4fbe-b22f-5ca3304f2d50 ro quiet splash vt.handoff=7
SourcePackage: linux
UpgradeStatus: Upgraded to saucy on 2013-09-08 (45 days ago)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ecryptfs/+bug/1243636/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1243636] Re: ecryptfs currupts files over 4GB size on i686
** Summary changed: - ecryptfs currupts files over 4GB size + ecryptfs currupts files over 4GB size on i686 ** Changed in: ecryptfs Status: Triaged = In Progress ** Changed in: linux (Ubuntu) Status: Triaged = In Progress -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1243636 Title: ecryptfs currupts files over 4GB size on i686 Status in eCryptfs: In Progress Status in “linux” package in Ubuntu: In Progress Bug description: on extracting files with extracted size 4 GB files are getting currupted. interestingly file gets currupted in the very moment the file size gets more than 4GB. ProblemType: Bug DistroRelease: Ubuntu 13.10 Package: linux-image-3.11.0-12-generic 3.11.0-12.19 ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3 Uname: Linux 3.11.0-12-generic i686 ApportVersion: 2.12.5-0ubuntu2 Architecture: i386 Date: Wed Oct 23 12:11:43 2013 EcryptfsInUse: Yes InstallationDate: Installed on 2013-07-20 (94 days ago) InstallationMedia: Ubuntu 13.04 Raring Ringtail - Release i386 (20130424) MarkForUpload: True ProcEnviron: TERM=xterm PATH=(custom, no user) XDG_RUNTIME_DIR=set LANG=de_DE.UTF-8 SHELL=/bin/bash ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.11.0-12-generic root=UUID=e97431f7-60b7-4fbe-b22f-5ca3304f2d50 ro quiet splash vt.handoff=7 SourcePackage: linux UpgradeStatus: Upgraded to saucy on 2013-09-08 (45 days ago) To manage notifications about this bug go to: https://bugs.launchpad.net/ecryptfs/+bug/1243636/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1243636] Re: ecryptfs currupts files over 4GB size on i686
Tyler, the attached diff helps me read/write files over 4GB. I think some of the changes may be redundant, so I'm checking to see what is the minimal set of changes required. ** Patch added: 32-bit-fixes.diff https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1243636/+attachment/3889738/+files/32-bit-fixes.diff -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1243636 Title: ecryptfs currupts files over 4GB size on i686 Status in eCryptfs: In Progress Status in “linux” package in Ubuntu: In Progress Bug description: on extracting files with extracted size 4 GB files are getting currupted. interestingly file gets currupted in the very moment the file size gets more than 4GB. ProblemType: Bug DistroRelease: Ubuntu 13.10 Package: linux-image-3.11.0-12-generic 3.11.0-12.19 ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3 Uname: Linux 3.11.0-12-generic i686 ApportVersion: 2.12.5-0ubuntu2 Architecture: i386 Date: Wed Oct 23 12:11:43 2013 EcryptfsInUse: Yes InstallationDate: Installed on 2013-07-20 (94 days ago) InstallationMedia: Ubuntu 13.04 Raring Ringtail - Release i386 (20130424) MarkForUpload: True ProcEnviron: TERM=xterm PATH=(custom, no user) XDG_RUNTIME_DIR=set LANG=de_DE.UTF-8 SHELL=/bin/bash ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.11.0-12-generic root=UUID=e97431f7-60b7-4fbe-b22f-5ca3304f2d50 ro quiet splash vt.handoff=7 SourcePackage: linux UpgradeStatus: Upgraded to saucy on 2013-09-08 (45 days ago) To manage notifications about this bug go to: https://bugs.launchpad.net/ecryptfs/+bug/1243636/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1243636] Re: ecryptfs currupts files over 4GB size on i686
Tyler, reduced it down to a one line fix. Tested with a 0.5GB, 2GB, 4GB, 8GB, 32GB test file with a sanity check on each byte. Patch attached below. Not yet tested with ecryptfs tests, but it looks like the root issue. ** Patch added: potential fix https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1243636/+attachment/3889786/+files/0001-eCryptfs-fix-32-bit-corruption-issue-LP-1243636.patch -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1243636 Title: ecryptfs currupts files over 4GB size on i686 Status in eCryptfs: In Progress Status in “linux” package in Ubuntu: In Progress Bug description: on extracting files with extracted size 4 GB files are getting currupted. interestingly file gets currupted in the very moment the file size gets more than 4GB. ProblemType: Bug DistroRelease: Ubuntu 13.10 Package: linux-image-3.11.0-12-generic 3.11.0-12.19 ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3 Uname: Linux 3.11.0-12-generic i686 ApportVersion: 2.12.5-0ubuntu2 Architecture: i386 Date: Wed Oct 23 12:11:43 2013 EcryptfsInUse: Yes InstallationDate: Installed on 2013-07-20 (94 days ago) InstallationMedia: Ubuntu 13.04 Raring Ringtail - Release i386 (20130424) MarkForUpload: True ProcEnviron: TERM=xterm PATH=(custom, no user) XDG_RUNTIME_DIR=set LANG=de_DE.UTF-8 SHELL=/bin/bash ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.11.0-12-generic root=UUID=e97431f7-60b7-4fbe-b22f-5ca3304f2d50 ro quiet splash vt.handoff=7 SourcePackage: linux UpgradeStatus: Upgraded to saucy on 2013-09-08 (45 days ago) To manage notifications about this bug go to: https://bugs.launchpad.net/ecryptfs/+bug/1243636/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1243636] Re: ecryptfs currupts files over 4GB size on i686
** Tags added: tasty -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1243636 Title: ecryptfs currupts files over 4GB size on i686 Status in eCryptfs: In Progress Status in “linux” package in Ubuntu: In Progress Bug description: on extracting files with extracted size 4 GB files are getting currupted. interestingly file gets currupted in the very moment the file size gets more than 4GB. ProblemType: Bug DistroRelease: Ubuntu 13.10 Package: linux-image-3.11.0-12-generic 3.11.0-12.19 ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3 Uname: Linux 3.11.0-12-generic i686 ApportVersion: 2.12.5-0ubuntu2 Architecture: i386 Date: Wed Oct 23 12:11:43 2013 EcryptfsInUse: Yes InstallationDate: Installed on 2013-07-20 (94 days ago) InstallationMedia: Ubuntu 13.04 Raring Ringtail - Release i386 (20130424) MarkForUpload: True ProcEnviron: TERM=xterm PATH=(custom, no user) XDG_RUNTIME_DIR=set LANG=de_DE.UTF-8 SHELL=/bin/bash ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.11.0-12-generic root=UUID=e97431f7-60b7-4fbe-b22f-5ca3304f2d50 ro quiet splash vt.handoff=7 SourcePackage: linux UpgradeStatus: Upgraded to saucy on 2013-09-08 (45 days ago) To manage notifications about this bug go to: https://bugs.launchpad.net/ecryptfs/+bug/1243636/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1243636] Re: ecryptfs currupts files over 4GB size on i686
** Tags added: patch -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1243636 Title: ecryptfs currupts files over 4GB size on i686 Status in eCryptfs: In Progress Status in “linux” package in Ubuntu: In Progress Bug description: on extracting files with extracted size 4 GB files are getting currupted. interestingly file gets currupted in the very moment the file size gets more than 4GB. ProblemType: Bug DistroRelease: Ubuntu 13.10 Package: linux-image-3.11.0-12-generic 3.11.0-12.19 ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3 Uname: Linux 3.11.0-12-generic i686 ApportVersion: 2.12.5-0ubuntu2 Architecture: i386 Date: Wed Oct 23 12:11:43 2013 EcryptfsInUse: Yes InstallationDate: Installed on 2013-07-20 (94 days ago) InstallationMedia: Ubuntu 13.04 Raring Ringtail - Release i386 (20130424) MarkForUpload: True ProcEnviron: TERM=xterm PATH=(custom, no user) XDG_RUNTIME_DIR=set LANG=de_DE.UTF-8 SHELL=/bin/bash ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.11.0-12-generic root=UUID=e97431f7-60b7-4fbe-b22f-5ca3304f2d50 ro quiet splash vt.handoff=7 SourcePackage: linux UpgradeStatus: Upgraded to saucy on 2013-09-08 (45 days ago) To manage notifications about this bug go to: https://bugs.launchpad.net/ecryptfs/+bug/1243636/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1243636] Re: ecryptfs currupts files over 4GB size on i686
Thanks Colin! As I mentioned in IRC, I came up with the same patch last night and successfully ran tests against it overnight. We'll go with your patch since it already has a commit message. I targeted it for 3.11+ stable and will push it to Linus today. I'll also get the Ubuntu SRU prepared. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1243636 Title: ecryptfs currupts files over 4GB size on i686 Status in eCryptfs: In Progress Status in “linux” package in Ubuntu: In Progress Bug description: on extracting files with extracted size 4 GB files are getting currupted. interestingly file gets currupted in the very moment the file size gets more than 4GB. ProblemType: Bug DistroRelease: Ubuntu 13.10 Package: linux-image-3.11.0-12-generic 3.11.0-12.19 ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3 Uname: Linux 3.11.0-12-generic i686 ApportVersion: 2.12.5-0ubuntu2 Architecture: i386 Date: Wed Oct 23 12:11:43 2013 EcryptfsInUse: Yes InstallationDate: Installed on 2013-07-20 (94 days ago) InstallationMedia: Ubuntu 13.04 Raring Ringtail - Release i386 (20130424) MarkForUpload: True ProcEnviron: TERM=xterm PATH=(custom, no user) XDG_RUNTIME_DIR=set LANG=de_DE.UTF-8 SHELL=/bin/bash ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.11.0-12-generic root=UUID=e97431f7-60b7-4fbe-b22f-5ca3304f2d50 ro quiet splash vt.handoff=7 SourcePackage: linux UpgradeStatus: Upgraded to saucy on 2013-09-08 (45 days ago) To manage notifications about this bug go to: https://bugs.launchpad.net/ecryptfs/+bug/1243636/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1243636] Re: ecryptfs currupts files over 4GB size on i686
** Description changed:
+ [SRU Justification]
+
+ Commit 24d15266bd86b7961f309a962fa3aa177a78c49f introduced a data corruption
+ regression on 32 bit architectures when writing past the 4 GB.
+
+ [Impact]
+
+ 32 bit users experience corruption of large files.
+
+ [Fix]
+
+ A cast is needed when shifting the page's index. Colin and I independently
+ identified the problem. It is a simple fix that is currently located in the
+ eCryptfs next branch:
+
+
http://git.kernel.org/cgit/linux/kernel/git/tyhicks/ecryptfs.git/commit/?h=nextid=43b7c6c6a4e3916edd186ceb61be0c67d1e0969e
+
+ I've sent a pull request to Linus, but he has not yet had a chance to pull in
+ the change:
+
+ https://lkml.org/lkml/2013/10/24/424
+
+ [Test Case]
+
+ Inside of an eCryptfs mount on an i686 Ubuntu install, create a file
containing
+ 4 GB + 1 page worth (4096 bytes) of zeros. Then inspect the file for non-zero
+ bytes.
+
+ $ rm zeros
+ $ dd if=/dev/zero of=zeros bs=4096 count=$((4*1024*1024*1024/4096+4096))
+ 1052672+0 records in
+ 1052672+0 records out
+ 4311744512 bytes (4.3 GB) copied, 226.133 s, 19.1 MB/s
+ $ hexdump -C zeros
+ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ||
+ *
+ 10100
+
+ The hexdump output should show all zeros. A non patched kernel will show
+ non-zero bytes.
+
+ [Original Bug Report]
+
on extracting files with extracted size 4 GB files are getting currupted.
interestingly file gets currupted in the very moment the file size gets more
than 4GB.
ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: linux-image-3.11.0-12-generic 3.11.0-12.19
ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3
Uname: Linux 3.11.0-12-generic i686
ApportVersion: 2.12.5-0ubuntu2
Architecture: i386
Date: Wed Oct 23 12:11:43 2013
EcryptfsInUse: Yes
InstallationDate: Installed on 2013-07-20 (94 days ago)
InstallationMedia: Ubuntu 13.04 Raring Ringtail - Release i386 (20130424)
MarkForUpload: True
ProcEnviron:
- TERM=xterm
- PATH=(custom, no user)
- XDG_RUNTIME_DIR=set
- LANG=de_DE.UTF-8
- SHELL=/bin/bash
+ TERM=xterm
+ PATH=(custom, no user)
+ XDG_RUNTIME_DIR=set
+ LANG=de_DE.UTF-8
+ SHELL=/bin/bash
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.11.0-12-generic
root=UUID=e97431f7-60b7-4fbe-b22f-5ca3304f2d50 ro quiet splash vt.handoff=7
SourcePackage: linux
UpgradeStatus: Upgraded to saucy on 2013-09-08 (45 days ago)
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1243636
Title:
ecryptfs currupts files over 4GB size on i686
Status in eCryptfs:
In Progress
Status in “linux” package in Ubuntu:
In Progress
Bug description:
[SRU Justification]
Commit 24d15266bd86b7961f309a962fa3aa177a78c49f introduced a data corruption
regression on 32 bit architectures when writing past the 4 GB.
[Impact]
32 bit users experience corruption of large files.
[Fix]
A cast is needed when shifting the page's index. Colin and I independently
identified the problem. It is a simple fix that is currently located in the
eCryptfs next branch:
http://git.kernel.org/cgit/linux/kernel/git/tyhicks/ecryptfs.git/commit/?h=nextid=43b7c6c6a4e3916edd186ceb61be0c67d1e0969e
I've sent a pull request to Linus, but he has not yet had a chance to pull in
the change:
https://lkml.org/lkml/2013/10/24/424
[Test Case]
Inside of an eCryptfs mount on an i686 Ubuntu install, create a file
containing
4 GB + 1 page worth (4096 bytes) of zeros. Then inspect the file for non-zero
bytes.
$ rm zeros
$ dd if=/dev/zero of=zeros bs=4096 count=$((4*1024*1024*1024/4096+4096))
1052672+0 records in
1052672+0 records out
4311744512 bytes (4.3 GB) copied, 226.133 s, 19.1 MB/s
$ hexdump -C zeros
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ||
*
10100
The hexdump output should show all zeros. A non patched kernel will show
non-zero bytes.
[Original Bug Report]
on extracting files with extracted size 4 GB files are getting currupted.
interestingly file gets currupted in the very moment the file size gets more
than 4GB.
ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: linux-image-3.11.0-12-generic 3.11.0-12.19
ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3
Uname: Linux 3.11.0-12-generic i686
ApportVersion: 2.12.5-0ubuntu2
Architecture: i386
Date: Wed Oct 23 12:11:43 2013
EcryptfsInUse: Yes
InstallationDate: Installed on 2013-07-20 (94 days ago)
InstallationMedia: Ubuntu 13.04 Raring Ringtail - Release i386 (20130424)
MarkForUpload: True
ProcEnviron:
TERM=xterm
PATH=(custom, no user)
XDG_RUNTIME_DIR=set
LANG=de_DE.UTF-8
SHELL=/bin/bash
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.11.0-12-generic
root=UUID=e97431f7-60b7-4fbe-b22f-5ca3304f2d50 ro quiet splash vt.handoff=7
SourcePackage: linux
UpgradeStatus:
