[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-09-13 Thread Matthias Klose
reconfirmed with Seth that this is good to go. Please add it to a seed or as a dependency to some package. ** Changed in: thunderbolt-tools (Ubuntu) Milestone: ubuntu-18.03 => ubuntu-18.10 -- You received this bug notification because you are a member of Kernel Packages, which is

Re: [Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-04-10 Thread Seth Arnold
On Tue, Apr 10, 2018 at 05:12:22AM -, Mario Limonciello wrote: > > Did I get the interpretation of these rules correct? > At a glance it looks like what you thought, but dig a little deeper. > If it's not in the ACL it exits. Ah! Thanks Mario! -- You received this bug notification because

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-04-09 Thread Mario Limonciello
> Did I get the interpretation of these rules correct? At a glance it looks like what you thought, but dig a little deeper. 1. The rule calls tbtacl add (https://github.com/intel/thunderbolt-software-user-space/blob/master/tbtacl/tbtacl.rules.in#L2) 2. tbtacl add calls authorize:

Re: [Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-04-09 Thread Seth Arnold
On Sat, Apr 07, 2018 at 10:09:29PM -, Yehezkel Bernat wrote: > I'd like to get a bit more details about some of the comments to > understand what steps I can take to improve it. Please let me know if > you prefer to take this discussion to another medium. Hello Yehezkel, > > - udev rules --

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-04-09 Thread Colin Ian King
@Seth, Thanks for the MIR review. I removed the duplicated udev rules - bug 1762187 so I think we're now good to go. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thunderbolt-tools in Ubuntu. Matching subscriptions: Kernel Packages

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-04-07 Thread Yehezkel Bernat
Thanks for the review! I'd like to get a bit more details about some of the comments to understand what steps I can take to improve it. Please let me know if you prefer to take this discussion to another medium. > - udev rules -- appear to be configured for works-by-default behaviour, > some

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-04-06 Thread Seth Arnold
I reviewed thunderbolt-tools version 0.9.3-1 as checked into bionic. This shouldn't be considered a full security audit but rather a quick gauge of maintainability. - No CVEs in our database - thunderbolt-tools provides a simple interface to authorize thunderbolt devices that are being added

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-04-06 Thread Colin Ian King
The above issue is reported against bug 1761757 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thunderbolt-tools in Ubuntu. Matching subscriptions: Kernel Packages https://bugs.launchpad.net/bugs/1748157 Title: [MIR]

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-04-05 Thread Seth Arnold
One of the udev rules files appears to be untranslated: ./thunderbolt-tools_0.9.3-1_amd64/lib/udev/rules.d/tbtacl.rules: # Thunderbolt udev rules for ACL (device auto approval) SUBSYSTEM=="thunderbolt" ENV{DEVTYPE}=="thunderbolt_device" ACTION=="add" ATTR{authorized}=="0"

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-28 Thread Sebastien Bacher
Bolt upstream has contacted the thunderbolt-tools upstream about using the same ACL before starting writting their code but never got a reply on the topic apparently, let's see what they say but bolt is providing desktop integration and a command line utility and they plan to have the networking

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-27 Thread Yehezkel Bernat
(Sorry, I meant: https://gitlab.freedesktop.org/bolt/bolt/issues/78) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thunderbolt-tools in Ubuntu. Matching subscriptions: Kernel Packages https://bugs.launchpad.net/bugs/1748157 Title:

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-27 Thread Yehezkel Bernat
Seth, It was disabled as the project is now handled at freedesktop's GitLab. I opened an issue there: https://github.com/intel/thunderbolt-software-user-space/issues/60 ** Bug watch added: github.com/intel/thunderbolt-software-user-space/issues #60

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-26 Thread Seth Arnold
Mario, thanks for the feedback. I'll try to get to the Intel Thunderbolt tools in time for the Bionic release. Yehezkel, any chance you can communicate your desire to upstream Bolt folks? The github issues for Bolt appears to have been disabled. Thanks -- You received this bug notification

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-26 Thread Mario Limonciello
At the time Colin and I discussed getting thunderbolt-tools into Debian and then eventually into Ubuntu (& of course main via this MIR) bolt's GUI wasn't available yet and bolt was still under some pretty heavy development. >From a client (general purpose laptop or desktop) system perspective

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-21 Thread Yehezkel Bernat
My 2 cents: I think bolt and thunderbolt-tools must agree on the ACL (device whitelist for auto-approve on next connection) location and format and then I assume they can co-exist happily without stepping on each other's toes. Even if both try to authorize the same device on connection, it

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-21 Thread Will Cooke
AFAIK, Bolt (https://christian.kellner.me/2017/12/14/introducing-bolt- thunderbolt-3-security-levels-for-gnulinux/) will allow us to provide UI for managing security levels for Thunderbolt connected devices. It uses the Intel provided sysfs devices for configuration. If thunderbolt- tools also

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-20 Thread Seth Arnold
Will, can you provide some advice? Thanks -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thunderbolt-tools in Ubuntu. Matching subscriptions: Kernel Packages https://bugs.launchpad.net/bugs/1748157 Title: [MIR] thunderbolt-tools

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-20 Thread Colin Ian King
@Seth, thunderbolt-tools was requested by Dell to be part of Ubuntu Bionic, I believe it's for some specific Dell laptops, but I can't provide any more specific details as Mario from Dell is on vacation right now. -- You received this bug notification because you are a member of Kernel Packages,

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-20 Thread Colin Ian King
Seems like "bolt" was handled before my MIR, which is perplexing as my request was for a Dell requested package that was filed earlier back in 2018-02-08 where as bolt was filed in 2018-02-27. I'm not sure about bolt, this seems to be a Ubuntu package and not one that is in Debian. @Mario, any

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-20 Thread Seth Arnold
This appears to be duplicating functionality from bolt: https://bugs.launchpad.net/ubuntu/+source/bolt/+bug/1752056 Are both packages truly desired? Thanks -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thunderbolt-tools in Ubuntu.

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-20 Thread Mathieu Trudel-Lapierre
Assigning to security as per the description... ** Changed in: thunderbolt-tools (Ubuntu) Assignee: (unassigned) => Ubuntu Security Team (ubuntu-security) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thunderbolt-tools in Ubuntu.

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-03-01 Thread Colin Ian King
** Changed in: thunderbolt-tools (Ubuntu) Importance: High => Critical -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thunderbolt-tools in Ubuntu. Matching subscriptions: Kernel Packages https://bugs.launchpad.net/bugs/1748157 Title:

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-02-09 Thread Colin Ian King
** Changed in: thunderbolt-tools (Ubuntu) Importance: Undecided => High ** Changed in: thunderbolt-tools (Ubuntu) Milestone: None => ubuntu-18.03 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thunderbolt-tools in Ubuntu.

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-02-08 Thread Mario Limonciello
** Package changed: linux (Ubuntu) => thunderbolt-tools (Ubuntu) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thunderbolt-tools in Ubuntu. Matching subscriptions: Kernel Packages https://bugs.launchpad.net/bugs/1748157 Title: [MIR]

[Kernel-packages] [Bug 1748157] Re: [MIR] thunderbolt-tools

2018-02-08 Thread Mario Limonciello
Logs N/A for this type of bug. ** Changed in: linux (Ubuntu) Status: Incomplete => New ** Changed in: linux (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.