[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
Great news Arthur, I'm glad the issue is solved!
Thanks for the report and testing,
Guilherme
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Xenial:
Fix Released
Status in linux source package in Bionic:
Fix Released
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
Hi Guilherme,
Thanks for the update! I tested and it works!
Cheers,
Arthur
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Xenial:
Fix Released
Status in linux source package in Bionic:
Fix Released
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
Hi Arthur, good news - there are currently Bionic and Xenial AMIs with
the fix! I've tried the following AMIs, and they have the fix:
ubuntu/images/hvm-ssd/ubuntu-bionic-18.04-amd64-server-20200610 -
ami-025201fa53cf4d031
ubuntu/images/hvm-ssd/ubuntu-xenial-16.04-amd64-server-20200610 -
ami-0a0ddd875a1ea2c7f
Note that the first one (Ubuntu 18.04) includes kernel 5.3, which contains the
fix.
Let me know if you have more questions, and thanks again for the report!
Cheers,
Guilherme
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Xenial:
Fix Released
Status in linux source package in Bionic:
Fix Released
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
Hi Guilherme,
Thanks for your reply.
No need for an exact ETA, but can you give me some sort of feeling, maybe how
often do these amis get released? once a month? 2 months?
Cheers,
Arthur
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Xenial:
Fix Released
Status in linux source package in Bionic:
Fix Released
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
Hi Arthur, I discussed this topic today with the responsible for AMIs on
AWS, and I was then told that new AMIs should be built for testing next
hours. After internal testing, they should get released, I don't have an
ETA.
Cheers,
Guilherme
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Xenial:
Fix Released
Status in linux source package in Bionic:
Fix Released
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
Question - when is this fix expected to be released to the official Bionic and
Xenial AMIs in AWS?
Thank!
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Xenial:
Fix Released
Status in linux source package in Bionic:
Fix Released
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
** Changed in: linux (Ubuntu)
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Xenial:
Fix Released
Status in linux source package in Bionic:
Fix Released
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
This bug was fixed in the package linux - 4.4.0-184.214
---
linux (4.4.0-184.214) xenial; urgency=medium
* CVE-2020-0543
- SAUCE: x86/cpu: Add a steppings field to struct x86_cpu_id
- SAUCE: x86/cpu: Add 'table' argument to cpu_matches()
- SAUCE: x86/speculation: Add Special Register Buffer Data Sampling (SRBDS)
mitigation
- SAUCE: x86/speculation: Add SRBDS vulnerability and mitigation
documentation
- SAUCE: x86/speculation: Add Ivy Bridge to affected list
linux (4.4.0-181.211) xenial; urgency=medium
* xenial/linux: 4.4.0-181.211 -proposed tracker (LP: #1881170)
* CVE-2020-12769
- spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls
* I2C bus on Dell Edge Gateway stops working after upgrading to
Ubuntu-4.4.0-180.210 (LP: #1881124)
- SAUCE: Revert: Revert "ACPI / LPSS: allow to use specific PM domain during
->probe()"
linux (4.4.0-180.210) xenial; urgency=medium
* xenial/linux: 4.4.0-180.210 -proposed tracker (LP: #1878873)
* Xenial update: 4.4.223 upstream stable release (LP: #1878232)
- mwifiex: fix PCIe register information for 8997 chipset
- drm/qxl: qxl_release use after free
- drm/qxl: qxl_release leak in qxl_draw_dirty_fb()
- staging: rtl8192u: Fix crash due to pointers being "confusing"
- usb: gadget: f_acm: Fix configfs attr name
- usb: gadged: pch_udc: get rid of redundant assignments
- usb: gadget: pch_udc: reorder spin_[un]lock to avoid deadlock
- usb: gadget: udc: core: don't starve DMA resources
- MIPS: Fix macro typo
- MIPS: ptrace: Drop cp0_tcstatus from regoffset_table[]
- MIPS: BMIPS: Fix PRID_IMP_BMIPS5000 masking for BMIPS5200
- MIPS: smp-cps: Stop printing EJTAG exceptions to UART
- MIPS: scall: Handle seccomp filters which redirect syscalls
- MIPS: BMIPS: BMIPS5000 has I cache filing from D cache
- MIPS: BMIPS: Clear MIPS_CACHE_ALIASES earlier
- MIPS: BMIPS: local_r4k___flush_cache_all needs to blast S-cache
- MIPS: BMIPS: Pretty print BMIPS5200 processor name
- MIPS: Fix HTW config on XPA kernel without LPA enabled
- MIPS: BMIPS: Adjust mips-hpt-frequency for BCM7435
- MIPS: math-emu: Fix BC1{EQ,NE}Z emulation
- MIPS: Fix BC1{EQ,NE}Z return offset calculation
- MIPS: perf: Fix I6400 event numbers
- MIPS: KVM: Fix translation of MFC0 ErrCtl
- MIPS: SMP: Update cpu_foreign_map on CPU disable
- MIPS: c-r4k: Fix protected_writeback_scache_line for EVA
- MIPS: Octeon: Off by one in octeon_irq_gpio_map()
- bpf, mips: fix off-by-one in ctx offset allocation
- MIPS: RM7000: Double locking bug in rm7k_tc_disable()
- MIPS: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO
- mips/panic: replace smp_send_stop() with kdump friendly version in panic
path
- ARM: dts: armadillo800eva Correct extal1 frequency to 24 MHz
- ARM: imx: select SRC for i.MX7
- ARM: dts: kirkwood: gpio pin fixes for linkstation ls-wxl/wsxl
- ARM: dts: kirkwood: gpio pin fixes for linkstation ls-wvl/vl
- ARM: dts: kirkwood: gpio-leds fixes for linkstation ls-wxl/wsxl
- ARM: dts: kirkwood: gpio-leds fixes for linkstation ls-wvl/vl
- ARM: dts: orion5x: gpio pin fixes for linkstation lswtgl
- ARM: dts: orion5x: fix the missing mtd flash on linkstation lswtgl
- ARM: dts: kirkwood: use unique machine name for ds112
- ARM: dts: kirkwood: add kirkwood-ds112.dtb to Makefile
- ARM: OMAP2+: hwmod: fix _idle() hwmod state sanity check sequence
- perf/x86: Fix filter_events() bug with event mappings
- x86/LDT: Print the real LDT base address
- x86/apic/uv: Silence a shift wrapping warning
- ALSA: fm801: explicitly free IRQ line
- ALSA: fm801: propagate TUNER_ONLY bit when autodetected
- ALSA: fm801: detect FM-only card earlier
- netfilter: nfnetlink: use original skbuff when acking batches
- xfrm: fix crash in XFRM_MSG_GETSA netlink handler
- mwifiex: fix IBSS data path issue.
- mwifiex: add missing check for PCIe8997 chipset
- iwlwifi: set max firmware version of 7265 to 17
- Bluetooth: btmrvl: fix hung task warning dump
- dccp: limit sk_filter trim to payload
- net/mlx4_core: Do not BUG_ON during reset when PCI is offline
- mlxsw: pci: Correctly determine if descriptor queue is full
- PCI: Supply CPU physical address (not bus address) to iomem_is_exclusive()
- alpha/PCI: Call iomem_is_exclusive() for IORESOURCE_MEM, but not
IORESOURCE_IO
- vfio/pci: Allow VPD short read
- mlxsw: Treat local port 64 as valid
- IB/mlx4: Initialize hop_limit when creating address handle
- GRE: Disable segmentation offloads w/ CSUM and we are encapsulated via FOU
- powerpc/pci/of: Parse unassigned resources
- firmware: actually return NULL on failed request_firmware_nowait()
- c8sectpfe: Rework firmware loading mechanism
- net/mlx5: Avoid passing dma address 0 to firmware
- IB/mlx5: Fix RC
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
This bug was fixed in the package linux - 4.15.0-106.107 --- linux (4.15.0-106.107) bionic; urgency=medium * CVE-2020-0543 - SAUCE: x86/cpu: Add a steppings field to struct x86_cpu_id - SAUCE: x86/cpu: Add 'table' argument to cpu_matches() - SAUCE: x86/speculation: Add Special Register Buffer Data Sampling (SRBDS) mitigation - SAUCE: x86/speculation: Add SRBDS vulnerability and mitigation documentation - SAUCE: x86/speculation: Add Ivy Bridge to affected list linux (4.15.0-103.104) bionic; urgency=medium * bionic/linux: 4.15.0-103.104 -proposed tracker (LP: #1881272) * "BUG: unable to handle kernel paging request" when testing ubuntu_kvm_smoke_test.kvm_smoke_test with B-KVM in proposed (LP: #1881072) - KVM: VMX: Explicitly reference RCX as the vmx_vcpu pointer in asm blobs - KVM: VMX: Mark RCX, RDX and RSI as clobbered in vmx_vcpu_run()'s asm blob linux (4.15.0-102.103) bionic; urgency=medium * bionic/linux: 4.15.0-102.103 -proposed tracker (LP: #1878856) * Packaging resync (LP: #1786013) - update dkms package versions * debian/scripts/file-downloader does not handle positive failures correctly (LP: #1878897) - [Packaging] file-downloader not handling positive failures correctly * Kernel log flood "ceph: Failed to find inode for 1" (LP: #1875884) - ceph: don't check quota for snap inode - ceph: quota: cache inode pointer in ceph_snap_realm * [UBUNTU 18.04] zpcictl --reset - contribution for kernel (LP: #1870320) - s390/pci: Recover handle in clp_set_pci_fn() - s390/pci: Fix possible deadlock in recover_store() * Bionic update: upstream stable patchset 2020-05-12 (LP: #1878256) - drm/edid: Fix off-by-one in DispID DTD pixel clock - drm/qxl: qxl_release leak in qxl_draw_dirty_fb() - drm/qxl: qxl_release leak in qxl_hw_surface_alloc() - drm/qxl: qxl_release use after free - btrfs: fix block group leak when removing fails - btrfs: fix partial loss of prealloc extent past i_size after fsync - mmc: sdhci-xenon: fix annoying 1.8V regulator warning - mmc: sdhci-pci: Fix eMMC driver strength for BYT-based controllers - ALSA: hda/realtek - Two front mics on a Lenovo ThinkCenter - ALSA: hda/hdmi: fix without unlocked before return - ALSA: pcm: oss: Place the plugin buffer overflow checks correctly - PM: ACPI: Output correct message on target power state - PM: hibernate: Freeze kernel threads in software_resume() - dm verity fec: fix hash block number in verity_fec_decode - RDMA/mlx5: Set GRH fields in query QP on RoCE - RDMA/mlx4: Initialize ib_spec on the stack - vfio: avoid possible overflow in vfio_iommu_type1_pin_pages - vfio/type1: Fix VA->PA translation for PFNMAP VMAs in vaddr_get_pfn() - iommu/qcom: Fix local_base status check - scsi: target/iblock: fix WRITE SAME zeroing - iommu/amd: Fix legacy interrupt remapping for x2APIC-enabled system - ALSA: opti9xx: shut up gcc-10 range warning - nfs: Fix potential posix_acl refcnt leak in nfs3_set_acl - dmaengine: dmatest: Fix iteration non-stop logic - selinux: properly handle multiple messages in selinux_netlink_send() - ASoC: tas571x: disable regulators on failed probe - ASoC: wm8960: Fix wrong clock after suspend & resume - rxrpc: Fix DATA Tx to disable nofrag for UDP on AF_INET6 socket - xfs: acquire superblock freeze protection on eofblocks scans - cpumap: Avoid warning when CONFIG_DEBUG_PER_CPU_MAPS is enabled - net: fec: set GPR bit on suspend by DT configuration. - ALSA: hda: Keep the controller initialization even if no codecs found - ALSA: hda: Explicitly permit using autosuspend if runtime PM is supported - ALSA: hda: call runtime_allow() for all hda controllers - scsi: qla2xxx: check UNLOADING before posting async work - RDMA/core: Fix race between destroy and release FD object - btrfs: transaction: Avoid deadlock due to bad initialization timing of fs_info::journal_info - mmc: sdhci-msm: Enable host capabilities pertains to R1b response - mmc: meson-mx-sdio: Set MMC_CAP_WAIT_WHILE_BUSY - mmc: meson-mx-sdio: remove the broken ->card_busy() op * Bionic update: upstream stable patchset 2020-05-07 (LP: #1877461) - ext4: fix extent_status fragmentation for plain files - net: ipv4: avoid unused variable warning for sysctl - crypto: mxs-dcp - make symbols 'sha1_null_hash' and 'sha256_null_hash' static - vti4: removed duplicate log message. - watchdog: reset last_hw_keepalive time at start - scsi: lpfc: Fix kasan slab-out-of-bounds error in lpfc_unreg_login - ceph: return ceph_mdsc_do_request() errors from __get_parent() - ceph: don't skip updating wanted caps when cap is stale - pwm: rcar: Fix late Runtime PM enablement - scsi: iscsi: Report unbind session event when the target has been removed - ASoC: Intel: atom: Take the drv->lock
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
I was able to verify it on AWS using the test procedure on description, in the
following linux-aws proposed kernels:
4.4.0-1108-aws (Xenial / 16.04)
4.15.0-1068-aws (Bionic / 18.04)
Also, I've done a code inspection in generic proposed kernels (4.4.0-180/Xenial
and 4.15.0-102/Bionic) and the patch is there, hence marking it as verified for
both kernels.
Cheers,
Guilherme
** Tags removed: verification-needed-bionic verification-needed-xenial
** Tags added: verification-done-bionic verification-done-xenial
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Xenial:
Fix Committed
Status in linux source package in Bionic:
Fix Committed
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
This bug is awaiting verification that the kernel in -proposed solves
the problem. Please test the kernel and update this bug with the
results. If the problem is solved, change the tag 'verification-needed-
bionic' to 'verification-done-bionic'. If the problem still exists,
change the tag 'verification-needed-bionic' to 'verification-failed-
bionic'.
If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.
See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!
** Tags added: verification-needed-bionic
** Tags added: verification-needed-xenial
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Xenial:
Fix Committed
Status in linux source package in Bionic:
Fix Committed
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
This bug is awaiting verification that the kernel in -proposed solves
the problem. Please test the kernel and update this bug with the
results. If the problem is solved, change the tag 'verification-needed-
xenial' to 'verification-done-xenial'. If the problem still exists,
change the tag 'verification-needed-xenial' to 'verification-failed-
xenial'.
If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.
See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Xenial:
Fix Committed
Status in linux source package in Bionic:
Fix Committed
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
** Changed in: linux (Ubuntu Xenial)
Status: In Progress => Fix Committed
** Changed in: linux (Ubuntu Bionic)
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Xenial:
Fix Committed
Status in linux source package in Bionic:
Fix Committed
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
SRU submitted to kernel mailing-list: https://lists.ubuntu.com/archives
/kernel-team/2020-May/109697.html
Cheers,
Guilherme
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Xenial:
In Progress
Status in linux source package in Bionic:
In Progress
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the TX/RX ring size to a legal number within boundaries -
works!
4. Change the TX/RX ring size to an illegal number (such as 2048 for
TX) with the command - "sudo ethtool -G ens5 tx 2048".
Expected behavior - "Cannot set device ring parameters: Invalid argument"
Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
[Regression Potential]
Since that the commit is present in kernels v4.16+ (including Ubuntu)
and is quite small and self-contained, the regression risk is very
reduced.
One potential "regression" would be if some driver has bugs and
provide bad values on get_ringparams, then the validation would be
broken (allowing illegal values or refusing legal ones), but this
wouldn't be a regression in the hereby proposed patch itself, it'd be
only exposed by the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
** Description changed:
- Upstream linux kernel implemented ring parameter boundaries check in commit:
- 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds during
SRINGPARAM")
+ [Impact]
+ * There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
- (see link
- https://patchwork.ozlabs.org/project/netdev/patch/1515420026-11970-2
- -git-send-email-tar...@mellanox.com/)
+ * Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
+ Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
- Due to this commit, the community doesn't allow ring parameter boundary
- checks in driver code.
+ * Xenial/Bionic kernels don't include this patch, and some network
+ drivers (like ena) rely on this patch for boundary checking of ring
+ params. So, we are hereby requesting the commit inclusion in these
+ kernel versions.
- The Bionic ubuntu kernel does not include this patch. And some network
drivers rely on this patch for
- boundary checking of ring params.
+ [Test case]
+ 1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
- This causes bugs in case a ringparam was given an illegal value.
-
- Reproduction steps in AWS:
-
- 1. Create new c5.4xlarge instance with the ubuntu 18.04 official ami (uses
the ENA network driver) and update to latest kernel using apt-get dist-upgrade
and reboot for the new kernel to load.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
- 3. Change the tx ring size to a legal number within boundaries - works!
- 4. Change the tx ring size to an illegal number such as 2048 with the command
- sudo ethtool -G ens5 tx 2048.
- Expected behavior - operation not allowed
- Actual behavior - causes a crash of the driver since boundaries are not
checked by ethtool.
+ 3. Change the TX/RX ring size to a legal number within boundaries -
+ works!
- Proposed fix - include the above commit 37e2d99b59c4 ("ethtool: Ensure
- new ring parameters are within bounds during SRINGPARAM") in bionic (and
- probably other ubuntu releases as well)
+ 4. Change the TX/RX ring size to an illegal number (such as 2048 for TX)
+ with the command - "sudo ethtool -G ens5 tx 2048".
+ Expected behavior - "Cannot set device ring parameters: Invalid argument"
+ Actual behavior - causes a driver hang since boundaries are not checked by
ethtool, effectively hanging the instance (given that AWS has no console to
allow system manipulation).
- More data about the machine where the bug occured:
+ [Regression Potential]
- ubuntu@ip-172-31-80-28:~/bionic$ lsb_release -rd
- Description: Ubuntu 18.04.4 LTS
- Release: 18.04
+ Since that the commit is present in kernels v4.16+ (including Ubuntu)
+ and is quite small and self-contained, the regression risk is very
+ reduced.
- ubuntu@ip-172-31-80-28:~/bionic$ uname -r
- 4.15.0-1065-aws
+ One potential "regression" would be if some driver has bugs and provide
+ bad values on get_ringparams, then the validation would be broken
+ (allowing illegal values or refusing legal ones), but this wouldn't be a
+ regression in the hereby proposed patch itself, it'd be only exposed by
+ the patch.
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Xenial:
In Progress
Status in linux source package in Bionic:
In Progress
Bug description:
[Impact]
* There's a bad behavior in the ena driver ringparam setting on kernels 4.4
and 4.15, if an invalid ringparam is provided to ethtool.
* Upstream Linux kernel implemented ring parameter boundaries check in
commit: 37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds
during SRINGPARAM") [ git.kernel.org/linus/37e2d99b59c4 ].
Due to this commit, the community doesn't usually allow ring parameter
boundary checks in driver code.
* Xenial/Bionic kernels don't include this patch, and some network
drivers (like ena) rely on this patch for boundary checking of ring
params. So, we are hereby requesting the commit inclusion in these
kernel versions.
[Test case]
1. In AWS, create a new c5.4xlarge instance with the Ubuntu 18.04 official
ami (uses the ENA network driver) and update to latest kernel/reboot.
2. Run ethtool -g ens5
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
Hi Arthur, thanks a lot for the report and for providing a test case and a fix
suggestion - basically you did all the work heheh
I've just built kernels 4.4 (Xenial) and 4.15 (Bionic) with your suggested fix
and indeed it prevented the failure; I'm working on the SRU request, so we can
get that merged for the next kernel cycle [0].
Cheers,
Guilherme
[0] https://kernel.ubuntu.com
** Tags added: sts xenial
** Also affects: linux (Ubuntu Bionic)
Importance: Undecided
Status: New
** Also affects: linux (Ubuntu Xenial)
Importance: Undecided
Status: New
** Changed in: linux (Ubuntu)
Status: Confirmed => In Progress
** Changed in: linux (Ubuntu Xenial)
Status: New => In Progress
** Changed in: linux (Ubuntu Bionic)
Status: New => In Progress
** Changed in: linux (Ubuntu Xenial)
Importance: Undecided => High
** Changed in: linux (Ubuntu Bionic)
Importance: Undecided => High
** Changed in: linux (Ubuntu)
Assignee: (unassigned) => Guilherme G. Piccoli (gpiccoli)
** Changed in: linux (Ubuntu Xenial)
Assignee: (unassigned) => Guilherme G. Piccoli (gpiccoli)
** Changed in: linux (Ubuntu Bionic)
Assignee: (unassigned) => Guilherme G. Piccoli (gpiccoli)
** Changed in: linux (Ubuntu)
Importance: Undecided => High
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Xenial:
In Progress
Status in linux source package in Bionic:
In Progress
Bug description:
Upstream linux kernel implemented ring parameter boundaries check in commit:
37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds during
SRINGPARAM")
(see link
https://patchwork.ozlabs.org/project/netdev/patch/1515420026-11970-2
-git-send-email-tar...@mellanox.com/)
Due to this commit, the community doesn't allow ring parameter
boundary checks in driver code.
The Bionic ubuntu kernel does not include this patch. And some network
drivers rely on this patch for
boundary checking of ring params.
This causes bugs in case a ringparam was given an illegal value.
Reproduction steps in AWS:
1. Create new c5.4xlarge instance with the ubuntu 18.04 official ami (uses
the ENA network driver) and update to latest kernel using apt-get dist-upgrade
and reboot for the new kernel to load.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the tx ring size to a legal number within boundaries - works!
4. Change the tx ring size to an illegal number such as 2048 with the command
- sudo ethtool -G ens5 tx 2048.
Expected behavior - operation not allowed
Actual behavior - causes a crash of the driver since boundaries are not
checked by ethtool.
Proposed fix - include the above commit 37e2d99b59c4 ("ethtool: Ensure
new ring parameters are within bounds during SRINGPARAM") in bionic
(and probably other ubuntu releases as well)
More data about the machine where the bug occured:
ubuntu@ip-172-31-80-28:~/bionic$ lsb_release -rd
Description: Ubuntu 18.04.4 LTS
Release: 18.04
ubuntu@ip-172-31-80-28:~/bionic$ uname -r
4.15.0-1065-aws
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
Hi,
Bumping this ticket up.
Is there still something missing in the ticket that I can provide to make it
workable?
Thanks!
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
Confirmed
Bug description:
Upstream linux kernel implemented ring parameter boundaries check in commit:
37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds during
SRINGPARAM")
(see link
https://patchwork.ozlabs.org/project/netdev/patch/1515420026-11970-2
-git-send-email-tar...@mellanox.com/)
Due to this commit, the community doesn't allow ring parameter
boundary checks in driver code.
The Bionic ubuntu kernel does not include this patch. And some network
drivers rely on this patch for
boundary checking of ring params.
This causes bugs in case a ringparam was given an illegal value.
Reproduction steps in AWS:
1. Create new c5.4xlarge instance with the ubuntu 18.04 official ami (uses
the ENA network driver) and update to latest kernel using apt-get dist-upgrade
and reboot for the new kernel to load.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the tx ring size to a legal number within boundaries - works!
4. Change the tx ring size to an illegal number such as 2048 with the command
- sudo ethtool -G ens5 tx 2048.
Expected behavior - operation not allowed
Actual behavior - causes a crash of the driver since boundaries are not
checked by ethtool.
Proposed fix - include the above commit 37e2d99b59c4 ("ethtool: Ensure
new ring parameters are within bounds during SRINGPARAM") in bionic
(and probably other ubuntu releases as well)
More data about the machine where the bug occured:
ubuntu@ip-172-31-80-28:~/bionic$ lsb_release -rd
Description: Ubuntu 18.04.4 LTS
Release: 18.04
ubuntu@ip-172-31-80-28:~/bionic$ uname -r
4.15.0-1065-aws
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
Tried running apport-collect but since my machine has no guy I couldn't
authorize.
Tried running apport-cli --save file.out - this also failed with:
"No pending crash reports. Try --help for more information."
I have no idea how to continue here, and I don't see the point as it is
fairly easy to run an ubuntu instance with the latest ubuntu 18.04 ami
to reproduce the issue and I filled all the necessary information on how
to fix the issue as well.
Moving the status to Confirmed.
** Changed in: linux (Ubuntu)
Status: Incomplete => Opinion
** Changed in: linux (Ubuntu)
Status: Opinion => Confirmed
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
Confirmed
Bug description:
Upstream linux kernel implemented ring parameter boundaries check in commit:
37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds during
SRINGPARAM")
(see link
https://patchwork.ozlabs.org/project/netdev/patch/1515420026-11970-2
-git-send-email-tar...@mellanox.com/)
Due to this commit, the community doesn't allow ring parameter
boundary checks in driver code.
The Bionic ubuntu kernel does not include this patch. And some network
drivers rely on this patch for
boundary checking of ring params.
This causes bugs in case a ringparam was given an illegal value.
Reproduction steps in AWS:
1. Create new c5.4xlarge instance with the ubuntu 18.04 official ami (uses
the ENA network driver) and update to latest kernel using apt-get dist-upgrade
and reboot for the new kernel to load.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the tx ring size to a legal number within boundaries - works!
4. Change the tx ring size to an illegal number such as 2048 with the command
- sudo ethtool -G ens5 tx 2048.
Expected behavior - operation not allowed
Actual behavior - causes a crash of the driver since boundaries are not
checked by ethtool.
Proposed fix - include the above commit 37e2d99b59c4 ("ethtool: Ensure
new ring parameters are within bounds during SRINGPARAM") in bionic
(and probably other ubuntu releases as well)
More data about the machine where the bug occured:
ubuntu@ip-172-31-80-28:~/bionic$ lsb_release -rd
Description: Ubuntu 18.04.4 LTS
Release: 18.04
ubuntu@ip-172-31-80-28:~/bionic$ uname -r
4.15.0-1065-aws
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1874444] Re: Bionic ubuntu ethtool doesn't check ring parameters boundaries
This can't be fixed in ethtool, it has to be fixed in the kernel.
** Package changed: ethtool (Ubuntu) => linux (Ubuntu)
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/187
Title:
Bionic ubuntu ethtool doesn't check ring parameters boundaries
Status in linux package in Ubuntu:
New
Bug description:
Upstream linux kernel implemented ring parameter boundaries check in commit:
37e2d99b59c4 ("ethtool: Ensure new ring parameters are within bounds during
SRINGPARAM")
(see link
https://patchwork.ozlabs.org/project/netdev/patch/1515420026-11970-2
-git-send-email-tar...@mellanox.com/)
Due to this commit, the community doesn't allow ring parameter
boundary checks in driver code.
The Bionic ubuntu kernel does not include this patch. And some network
drivers rely on this patch for
boundary checking of ring params.
This causes bugs in case a ringparam was given an illegal value.
Reproduction steps in AWS:
1. Create new c5.4xlarge instance with the ubuntu 18.04 official ami (uses
the ENA network driver) and update to latest kernel using apt-get dist-upgrade
and reboot for the new kernel to load.
2. Run ethtool -g ens5
output:
Ring parameters for ens5:
Pre-set maximums:
RX: 16384
RX Mini: 0
RX Jumbo: 0
TX: 1024
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
3. Change the tx ring size to a legal number within boundaries - works!
4. Change the tx ring size to an illegal number such as 2048 with the command
- sudo ethtool -G ens5 tx 2048.
Expected behavior - operation not allowed
Actual behavior - causes a crash of the driver since boundaries are not
checked by ethtool.
Proposed fix - include the above commit 37e2d99b59c4 ("ethtool: Ensure
new ring parameters are within bounds during SRINGPARAM") in bionic
(and probably other ubuntu releases as well)
More data about the machine where the bug occured:
ubuntu@ip-172-31-80-28:~/bionic$ lsb_release -rd
Description: Ubuntu 18.04.4 LTS
Release: 18.04
ubuntu@ip-172-31-80-28:~/bionic$ uname -r
4.15.0-1065-aws
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/187/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
