Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

2009-12-02 Thread Pavel Machek
On Wed 2009-12-02 22:25:16, Mel Gorman wrote: > On Wed, Dec 02, 2009 at 11:15:24PM +0100, Pavel Machek wrote: > > On Wed 2009-12-02 22:07:18, Mel Gorman wrote: > > > On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: > > > > On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > > > > > The o

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

2009-12-02 Thread Rafael J. Wysocki
On Wednesday 02 December 2009, Mel Gorman wrote: > On Wed, Dec 02, 2009 at 11:15:24PM +0100, Pavel Machek wrote: > > On Wed 2009-12-02 22:07:18, Mel Gorman wrote: > > > On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: > > > > On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > > > > > Th

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

2009-12-02 Thread Mel Gorman
On Wed, Dec 02, 2009 at 11:15:24PM +0100, Pavel Machek wrote: > On Wed 2009-12-02 22:07:18, Mel Gorman wrote: > > On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: > > > On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > > > > The original in-kernel suspend (swsusp) frees the in-memory h

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

2009-12-02 Thread Pavel Machek
On Wed 2009-12-02 22:07:18, Mel Gorman wrote: > On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: > > On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > > > The original in-kernel suspend (swsusp) frees the in-memory hibernation > > > image before powering off the machine. s2disk doesn'

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

2009-12-02 Thread Mel Gorman
On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: > On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > > The original in-kernel suspend (swsusp) frees the in-memory hibernation > > image before powering off the machine. s2disk doesn't, so there is > > _much_ less free memory when it tri

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

2009-12-02 Thread Rafael J. Wysocki
On Wednesday 02 December 2009, Alan Jenkins wrote: > The original in-kernel suspend (swsusp) frees the in-memory hibernation > image before powering off the machine. s2disk doesn't, so there is > _much_ less free memory when it tries to power off. > > This is a gratuitous difference. The userspa

Re: still getting allocation failures (was Re: [PATCH] vmscan: Stop kswapd waiting on congestion when the min watermark is not being met V2)

2009-12-02 Thread Tobias Oetiker
Hi Mel, Today Mel Gorman wrote: > On Sun, Nov 29, 2009 at 08:42:09AM +0100, Tobi Oetiker wrote: > > Hi Mel, > > > > Thursday Tobias Oetiker wrote: > > > Hi Mel, > > > > > > Nov 13 Mel Gorman wrote: > > > > > > > The last version has a stupid bug in it. Sorry. > > > > > > > > Changelog since V1 >

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

2009-12-02 Thread Pavel Machek
On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > The original in-kernel suspend (swsusp) frees the in-memory hibernation > image before powering off the machine. s2disk doesn't, so there is > _much_ less free memory when it tries to power off. > > This is a gratuitous difference. The userspace

[PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

2009-12-02 Thread Alan Jenkins
The original in-kernel suspend (swsusp) frees the in-memory hibernation image before powering off the machine. s2disk doesn't, so there is _much_ less free memory when it tries to power off. This is a gratuitous difference. The userspace suspend interface /dev/snapshot only allows the hibernati

Re: Bisected: s2disk (uswsusp only) hangs just before poweroff

2009-12-02 Thread Alan Jenkins
On 12/2/09, Mel Gorman wrote: > On Wed, Dec 02, 2009 at 11:49:47AM +, Alan Jenkins wrote: >> Rafael J. Wysocki wrote: >>> On Tuesday 01 December 2009, Mel Gorman wrote: >>> On Tue, Dec 01, 2009 at 07:59:40PM +, Alan Jenkins wrote: > Hi > > Suspend to disk is (sometime

Re: Bisected: s2disk (uswsusp only) hangs just before poweroff

2009-12-02 Thread Mel Gorman
On Wed, Dec 02, 2009 at 11:49:47AM +, Alan Jenkins wrote: > Rafael J. Wysocki wrote: >> On Tuesday 01 December 2009, Mel Gorman wrote: >> >>> On Tue, Dec 01, 2009 at 07:59:40PM +, Alan Jenkins wrote: >>> Hi Suspend to disk is (sometimes) hanging for me in 2.6.32-rc.

Re: Bisected: s2disk (uswsusp only) hangs just before poweroff

2009-12-02 Thread Alan Jenkins
Rafael J. Wysocki wrote: On Tuesday 01 December 2009, Mel Gorman wrote: On Tue, Dec 01, 2009 at 07:59:40PM +, Alan Jenkins wrote: Hi Suspend to disk is (sometimes) hanging for me in 2.6.32-rc. I finally got around to bisecting it, which blamed the following commit by Mel: 5f8d

Re: Bisected: s2disk (uswsusp only) hangs just before poweroff

2009-12-02 Thread Alan Jenkins
Mel Gorman wrote: On Wed, Dec 02, 2009 at 08:57:05AM +, Alan Jenkins wrote: Mel Gorman wrote: On Tue, Dec 01, 2009 at 07:59:40PM +, Alan Jenkins wrote: Hi Suspend to disk is (sometimes) hanging for me in 2.6.32-rc. I finally got around to bisecting it, which blame

Re: still getting allocation failures (was Re: [PATCH] vmscan: Stop kswapd waiting on congestion when the min watermark is not being met V2)

2009-12-02 Thread Mel Gorman
On Sun, Nov 29, 2009 at 08:42:09AM +0100, Tobi Oetiker wrote: > Hi Mel, > > Thursday Tobias Oetiker wrote: > > Hi Mel, > > > > Nov 13 Mel Gorman wrote: > > > > > The last version has a stupid bug in it. Sorry. > > > > > > Changelog since V1 > > > o Fix incorrect negation > > > o Rename kswapd_

Re: Bisected: s2disk (uswsusp only) hangs just before poweroff

2009-12-02 Thread Alan Jenkins
Mel Gorman wrote: On Tue, Dec 01, 2009 at 07:59:40PM +, Alan Jenkins wrote: Hi Suspend to disk is (sometimes) hanging for me in 2.6.32-rc. I finally got around to bisecting it, which blamed the following commit by Mel: 5f8dcc2 "page-allocator: split per-cpu list into one-list-per-mi

Re: Bisected: s2disk (uswsusp only) hangs just before poweroff

2009-12-02 Thread Mel Gorman
On Wed, Dec 02, 2009 at 08:57:05AM +, Alan Jenkins wrote: > Mel Gorman wrote: >> On Tue, Dec 01, 2009 at 07:59:40PM +, Alan Jenkins wrote: >> >>> Hi >>> >>> Suspend to disk is (sometimes) hanging for me in 2.6.32-rc. I >>> finally got around to bisecting it, which blamed the following

Re: Bisected: s2disk (uswsusp only) hangs just before poweroff

2009-12-02 Thread Alan Jenkins
Mel Gorman wrote: On Tue, Dec 01, 2009 at 07:59:40PM +, Alan Jenkins wrote: Hi Suspend to disk is (sometimes) hanging for me in 2.6.32-rc. I finally got around to bisecting it, which blamed the following commit by Mel: 5f8dcc2 "page-allocator: split per-cpu list into one-list-per-mi