Re: [PATCH] [RFC] EEE PC hangs when booting off battery

2009-05-16 Thread Alan Jenkins
Rafael J. Wysocki wrote: > On Wednesday 29 April 2009, Alan Jenkins wrote: > >> Alan Jenkins wrote: >> >>> Johannes Berg wrote: >>> >>> That doesn't seem relevant, this just does some initialisation. However, you definitely missed adding a call to wep_free(). >>>

Re: [PATCH] [RFC] EEE PC hangs when booting off battery

2009-05-15 Thread Rafael J. Wysocki
On Wednesday 29 April 2009, Alan Jenkins wrote: > Alan Jenkins wrote: > > Johannes Berg wrote: > > > >> That doesn't seem relevant, this just does some initialisation. However, > >> you definitely missed adding a call to wep_free(). > >> > >> > > > > Hah, I should have realized something

Re: [PATCH] [RFC] EEE PC hangs when booting off battery

2009-04-29 Thread Johannes Berg
On Wed, 2009-04-29 at 12:14 +0100, Alan Jenkins wrote: > From c5e9dc036247e70956d1a28e8850c3810385dda0 Mon Sep 17 00:00:00 2001 > From: Alan Jenkins > Date: Wed, 29 Apr 2009 11:41:24 +0100 > Subject: [PATCH] mac80211: fix modprobe deadlock by not calling wep_init > under rtnl_lock > > - ieee80

Re: [PATCH] [RFC] EEE PC hangs when booting off battery

2009-04-29 Thread Alan Jenkins
Alan Jenkins wrote: > Johannes Berg wrote: > >> That doesn't seem relevant, this just does some initialisation. However, >> you definitely missed adding a call to wep_free(). >> >> > > Hah, I should have realized something was wrong when I noticed I was > removing more lines that I added

Re: [PATCH] [RFC] EEE PC hangs when booting off battery

2009-04-28 Thread Alan Jenkins
Johannes Berg wrote: > It seems the only reason lockdep doesn't warn is the detour to userspace > (modprobe) and the waiting for a userspace task (waiting isn't lockdep > annotated and I don't think it can be) > > It seems you cannot load a module while under _any_ lock, ever, since > userspace mig

Re: [PATCH] [RFC] EEE PC hangs when booting off battery

2009-04-28 Thread Johannes Berg
On Tue, 2009-04-28 at 11:27 +0100, Alan Jenkins wrote: > > Can you point out where? I can't find that. > > I posted the calltraces earlier at > . > > wait_for_completion > flush_cpu_workqueue > ? wq_barrier_func > flush_workqueue > flush

Re: [PATCH] [RFC] EEE PC hangs when booting off battery

2009-04-28 Thread Johannes Berg
It seems the only reason lockdep doesn't warn is the detour to userspace (modprobe) and the waiting for a userspace task (waiting isn't lockdep annotated and I don't think it can be) It seems you cannot load a module while under _any_ lock, ever, since userspace might turn around and do something

[PATCH] [RFC] EEE PC hangs when booting off battery

2009-04-28 Thread Alan Jenkins
I found a regression where my EEE hangs at boot time, if the battery is present. I'm confident it's a regression because it disappears if I revert Arjan's asynchronous battery initialisation. However, the evidence points to a deadlock in the wireless stack which has simply been uncovered by timin