Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Fri 2009-12-11 10:53:52, Mel Gorman wrote: > On Tue, Dec 08, 2009 at 12:37:36AM +, Alan Jenkins wrote: > > >> > > >> Here's a new datum: > > >> > > >> Applying this patch has left a less frequent hang. So far it has > > >> happened twice. (Once playing last night, and once today testing >

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Tue, Dec 08, 2009 at 12:37:36AM +, Alan Jenkins wrote: > >> > >> Here's a new datum: > >> > >> Applying this patch has left a less frequent hang. So far it has > >> happened twice. (Once playing last night, and once today testing > >> hibernation with KMS enabled). > >> > >> This hang hap

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On 12/3/09, Mel Gorman wrote: > On Thu, Dec 03, 2009 at 12:57:28PM +, Alan Jenkins wrote: >> Pavel Machek wrote: >>> On Wed 2009-12-02 22:25:16, Mel Gorman wrote: >>> On Wed, Dec 02, 2009 at 11:15:24PM +0100, Pavel Machek wrote: > On Wed 2009-12-02 22:07:18, Mel Gorman wrote: >>>

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

Hi! > What's wrong with it? The hang is likely because the allocator has no > memory to work with. The patch in question makes small changes to the > amount of available memory but it shouldn't matter on uni-core. Some > structures are slightly larger but it's extremely borderline.

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Thursday 03 December 2009, Alan Jenkins wrote: > Pavel Machek wrote: > > On Wed 2009-12-02 22:25:16, Mel Gorman wrote: > > > >> On Wed, Dec 02, 2009 at 11:15:24PM +0100, Pavel Machek wrote: > >> > >>> On Wed 2009-12-02 22:07:18, Mel Gorman wrote: > >>> > On Wed, Dec 02, 2009

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Thu, Dec 03, 2009 at 12:57:28PM +, Alan Jenkins wrote: > Pavel Machek wrote: >> On Wed 2009-12-02 22:25:16, Mel Gorman wrote: >> >>> On Wed, Dec 02, 2009 at 11:15:24PM +0100, Pavel Machek wrote: >>> On Wed 2009-12-02 22:07:18, Mel Gorman wrote: > On Wed, Dec 02,

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

Pavel Machek wrote: On Wed 2009-12-02 22:25:16, Mel Gorman wrote: On Wed, Dec 02, 2009 at 11:15:24PM +0100, Pavel Machek wrote: On Wed 2009-12-02 22:07:18, Mel Gorman wrote: On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: On Wed 2009-12-02 14:28:12, Alan

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Wed 2009-12-02 22:25:16, Mel Gorman wrote: > On Wed, Dec 02, 2009 at 11:15:24PM +0100, Pavel Machek wrote: > > On Wed 2009-12-02 22:07:18, Mel Gorman wrote: > > > On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: > > > > On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > > > > > The o

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Wednesday 02 December 2009, Mel Gorman wrote: > On Wed, Dec 02, 2009 at 11:15:24PM +0100, Pavel Machek wrote: > > On Wed 2009-12-02 22:07:18, Mel Gorman wrote: > > > On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: > > > > On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > > > > > Th

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Wed, Dec 02, 2009 at 11:15:24PM +0100, Pavel Machek wrote: > On Wed 2009-12-02 22:07:18, Mel Gorman wrote: > > On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: > > > On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > > > > The original in-kernel suspend (swsusp) frees the in-memory h

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Wed 2009-12-02 22:07:18, Mel Gorman wrote: > On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: > > On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > > > The original in-kernel suspend (swsusp) frees the in-memory hibernation > > > image before powering off the machine. s2disk doesn'

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Wed, Dec 02, 2009 at 10:11:07PM +0100, Pavel Machek wrote: > On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > > The original in-kernel suspend (swsusp) frees the in-memory hibernation > > image before powering off the machine. s2disk doesn't, so there is > > _much_ less free memory when it tri

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Wednesday 02 December 2009, Alan Jenkins wrote: > The original in-kernel suspend (swsusp) frees the in-memory hibernation > image before powering off the machine. s2disk doesn't, so there is > _much_ less free memory when it tries to power off. > > This is a gratuitous difference. The userspa

Re: [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

On Wed 2009-12-02 14:28:12, Alan Jenkins wrote: > The original in-kernel suspend (swsusp) frees the in-memory hibernation > image before powering off the machine. s2disk doesn't, so there is > _much_ less free memory when it tries to power off. > > This is a gratuitous difference. The userspace

[PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it

The original in-kernel suspend (swsusp) frees the in-memory hibernation image before powering off the machine. s2disk doesn't, so there is _much_ less free memory when it tries to power off. This is a gratuitous difference. The userspace suspend interface /dev/snapshot only allows the hibernati